Or the button could just say "Cancel All" and "Reinstate All" maybe? I think it's probably clear enough as long as it has different wording than the instance version, and has the word "all" or "entire" or "whole" or "series" or something on there: the dialog can clarify exactly what it means.

I just think it might not look pretty on standard resolutions (like my Mac)

Maybe it's fine to just use "Reinstate All Recurrences", and then explain what that means in the dialog? I suspect we aren't going to find a succinct, clear wording for "Reinstate All Currently Un-Cancelled Recurrences".

Technically I suppose you could have cancelled an instance after using "Cancel All Recurrences", which might make the word "previously" misleading -- "prior to now" is correct but "prior to the time when you cancelled all recurrences" might be the interpretation. So maybe "Reinstate All Currently Un-Cancelled Instances" is perhaps even more clear?

Alternatively, we can make reinstating a series un-cancel all cancelled instances. That would make some sense to me.

"Cancel All Recurrences" works because it will keep already cancelled instances that way. When you reinstate the series, all the individually cancelled instances won't be un-cancelled, so "Reinstate All Instances" doesn't really cover it. It should be more like "Reinstate All Previously Un-cancelled Instances". How would we put that succinctly?

This is not a demo or test install. Please don't make a mess! You can launch a demo install on Phacility if you want to poke around and try things out.

Sorry for testing this here. Please remove :(

(I got an error when I created this bug report, which is why I went and added another one. Then, I discover they're BOTH in existence. Meh. Merged duplicate into T10766: Calendar - Unhandled Exception, since I referenced that task elsewhere.)

This would make Calendar actually useful for us.

Not sure what to say about this, because the problem I was experiencing originally wasn't with recurring events, but with all day events.

A treatment that might be nice is to add an "Events" sidebar panel, similar to the existing "Badges" panel. It could have a link to view their full (public) calendar (in the Calendar app), and show a quick view of current/upcoming events.

I think there may be a different/better fix to D13354, or maybe I'm not remembering why we made some decisions.

This no longer needs to wait for T5873, since enough of that has been sorted out in EditEngine and related work that it can move forward.

I think this is in good shape now, T9606 can track itself.

I think this is in good shape -- Herald is probably a ways out, and the only other chunk here is EditEngine which has a separate task (T9275).

I think this isn't tremendously important for Countdown but should definitely be sorted out before we unbeta Calendar.

See Prototype.

There's also mode=recurring... all these seem to do is change different default options on the form. Should I try to implement form edit engine support for this @epriestley? Would you be prepared to review it?

I did some digging through the source code and found PhabricatorCalendarEvent::initializeNewCalendarEvent which does this:

if ($mode == 'public') {
  $view_policy = PhabricatorPolicies::getMostOpenPolicy();
}

Thanks to you guys for helping through my first commit. Probably took longer to review,c comment, approve than to just do it yourself. Appreciate the hand holding, looking forward to other contributes in the future.

Resolved by D15207. Thanks!

go for it!

I'm more than happy to take on this task as my first contribution to Phabricator, but in reading the contributor guide it says all feature requests/bug reports should be first discussed.

These seem alright, I haven't been bothered by them.

I can confirm this as well. (I also tried to find where this was to fix it...couldn't locate it. @epriestley, if you point me to the file this bug would be coming from, I'd love to tackle this.)