Page MenuHomePhabricator
Feed Advanced Search

Mar 12 2016

epriestley created 2016 Week 11 (Mid March).
Mar 12 2016, 7:29 PM
epriestley updated the task description for T10574: A pathway toward "All Reviewers Must Accept".
Mar 12 2016, 4:52 PM · FreeBSD, Restricted Project, Differential
epriestley added a parent task for T4887: Extend the blocking reviewers functionality universally: T10574: A pathway toward "All Reviewers Must Accept".
Mar 12 2016, 4:52 PM · Restricted Project, Herald, Differential
epriestley added a subtask for T10574: A pathway toward "All Reviewers Must Accept": T4887: Extend the blocking reviewers functionality universally.
Mar 12 2016, 4:52 PM · FreeBSD, Restricted Project, Differential
epriestley added a parent task for T731: Allow revisions to have alternate acceptance conditions: T10574: A pathway toward "All Reviewers Must Accept".
Mar 12 2016, 4:52 PM · Restricted Project, Restricted Project, Differential
epriestley added subtasks for T10574: A pathway toward "All Reviewers Must Accept": T731: Allow revisions to have alternate acceptance conditions, T9372: Plan the future of "Bucketing" Query UIs.
Mar 12 2016, 4:52 PM · FreeBSD, Restricted Project, Differential
epriestley added a parent task for T9372: Plan the future of "Bucketing" Query UIs: T10574: A pathway toward "All Reviewers Must Accept".
Mar 12 2016, 4:52 PM · Restricted Project, Audit, ApplicationSearch, Differential
epriestley created T10574: A pathway toward "All Reviewers Must Accept".
Mar 12 2016, 4:51 PM · FreeBSD, Restricted Project, Differential
epriestley closed T10570: Default quote action breaks tables as Resolved by committing Restricted Diffusion Commit.
Mar 12 2016, 3:57 PM · Wikimedia, Maniphest, Bug Report
epriestley closed T10539: Email not respecting TO and CC as Resolved by committing Restricted Diffusion Commit.
Mar 12 2016, 3:30 PM · Mail, Restricted Project, Bug Report
epriestley added a comment to T10571: Default quote action breaks text between lists.

This one's slightly trickier than T10570 because leading whitespace is semantic in lists.

Mar 12 2016, 3:09 PM · Remarkup, Wikimedia
epriestley added a revision to T10570: Default quote action breaks tables: Unknown Object (Differential Revision).
Mar 12 2016, 3:07 PM · Wikimedia, Maniphest, Bug Report
epriestley added a comment to T10565: Make Phriction articles accessible via version control or arc.

Thanks for the feature request! This feature request doesn't have the information we need to move forward, so I'd like to start by trying to understand why it doesn't. Specifically, it does not describe the root problem you are facing, and instead asks for a specific feature.

Mar 12 2016, 2:50 PM · Phriction, Feature Request
epriestley claimed T10539: Email not respecting TO and CC .
Mar 12 2016, 1:25 PM · Mail, Restricted Project, Bug Report
epriestley updated the task description for T1130: Add Mercurial tag/bookmark support to Diffusion.
Mar 12 2016, 1:03 PM · Mercurial, Diffusion
epriestley merged T10573: Show Mercurial bookmarks in Diffusion into T1130: Add Mercurial tag/bookmark support to Diffusion.
Mar 12 2016, 1:02 PM · Mercurial, Diffusion
epriestley merged task T10573: Show Mercurial bookmarks in Diffusion into T1130: Add Mercurial tag/bookmark support to Diffusion.
Mar 12 2016, 1:02 PM · Mercurial, Diffusion, Feature Request
epriestley renamed T1130: Add Mercurial tag/bookmark support to Diffusion from Add Mercurial tag support to Diffusion to Add Mercurial tag/bookmark support to Diffusion.
Mar 12 2016, 1:02 PM · Mercurial, Diffusion
epriestley added a comment to T1130: Add Mercurial tag/bookmark support to Diffusion.

Ah, you're right, thanks! I misread that page -- that does make Mercurial tags a lot easier to deal with.

Mar 12 2016, 1:02 PM · Mercurial, Diffusion
wschroo awarded T10333: Add groups to workboard columns a Like token.
Mar 12 2016, 8:28 AM · Restricted Project, Restricted Project, Workboards (v3)
zhiyuchen awarded T10333: Add groups to workboard columns a Like token.
Mar 12 2016, 12:42 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a comment to T10569: Subproject tasks in parent project backlog.

Make it possible to add "subproject columns" in the parent's workboard

Mar 12 2016, 12:23 AM · Workboards, Projects, Feature Request
epriestley added a revision to T10539: Email not respecting TO and CC : Unknown Object (Differential Revision).
Mar 12 2016, 12:04 AM · Mail, Restricted Project, Bug Report

Mar 11 2016

epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 11 2016, 11:47 PM · Nuance (v1)
epriestley closed T10572: Call to undefined function msortv() as Resolved.
Mar 11 2016, 11:37 PM · Bug Report
epriestley added a comment to T10572: Call to undefined function msortv().

What version is libphutil at? This function was introduced in 821cad81.

Mar 11 2016, 11:31 PM · Bug Report
sweenzor awarded T7789: Support Git Large File Storage a Love token.
Mar 11 2016, 8:34 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T10566: Selecting custom policy does not show policy editor.

Yeah, persistent details would be helpful. My best guess at repro steps from the screenshot is:

Mar 11 2016, 6:27 PM · Policy, Bug Report
magnetik awarded T10364: Conpherence v4 (UI/UX) a Mountain of Wealth token.
Mar 11 2016, 9:02 AM · Conpherence (v4)
epriestley added a comment to Q335: Is it possible to set a default # of points on Maniphest tasks....

It needs a pile o' JS since it needs to change as you drag stuff around, but we can start with that.

Mar 11 2016, 2:48 AM · Maniphest
epriestley closed T10546: Time Tracking info no longer shown in Maniphest tasks as Resolved by committing Restricted Diffusion Commit.
Mar 11 2016, 2:45 AM · Phrequent, Bug Report
epriestley closed T10556: edit policy message as Invalid.

I'm going to close this since there's no pathway forward that I can see. We might just not understand your request.

Mar 11 2016, 2:23 AM · Bug Report
epriestley closed T10549: Getting PhutilTypeCheckException on certaion Differential pages as Resolved by committing Restricted Diffusion Commit.
Mar 11 2016, 2:16 AM · Differential, Bug Report
epriestley added a revision to T10546: Time Tracking info no longer shown in Maniphest tasks: Unknown Object (Differential Revision).
Mar 11 2016, 2:14 AM · Phrequent, Bug Report
epriestley added a comment to Q335: Is it possible to set a default # of points on Maniphest tasks....

I slightly miss the card counts too, since we have points enabled on this install but don't really use them.

Mar 11 2016, 2:06 AM · Maniphest
epriestley claimed T10546: Time Tracking info no longer shown in Maniphest tasks.

I'm going to write a CurtainExtension for it (I just missed it in the original round) but you might have to fix my bad stylin'.

Mar 11 2016, 1:42 AM · Phrequent, Bug Report
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

I'll leave this open for now since the behavior still feels a bit spooky to me, let me know how things go once you get the key in place? If they're smooth, we can chalk this up to be being bad at MySQL.

Mar 11 2016, 1:41 AM · Infrastructure
epriestley added a revision to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates: Unknown Object (Differential Revision).
Mar 11 2016, 1:36 AM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

I suppose the originally proposed key may be better than I think. I was imagining that it couldn't use the third part of the key (on changeType) but I suppose it actually can. I'm still confused by the UNION ALL behavior, but if the key's working on your dataset I think it's fine to add it -- it takes <1 second to add to our dataset, so even for large datasets it shouldn't be wildly unreasonable, even if we do find a better key later.

Mar 11 2016, 1:32 AM · Infrastructure
epriestley added a comment to T10564: Mail "Delivery" tab is confusing..

I'm seeing a replay of the (current?) rules about this message?

Mar 11 2016, 1:26 AM · Restricted Project, Mail, Bug Report
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

That's fine -- it looks like it's picking up the keys, I'm just not sure why it's then examining 303 million rows when it has the keys available.

Mar 11 2016, 1:24 AM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Hrrm, let me see if I can reproduce anything like that, that's totally bizarre to me.

Mar 11 2016, 1:11 AM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Hmm, weird. Can you show me the EXPLAIN SELECT ... for that?

Mar 11 2016, 1:08 AM · Infrastructure
epriestley added a comment to T10564: Mail "Delivery" tab is confusing..

Maybe we could add a "you weren't a recipient in the first place" reason which has priority over the other reasons, and make the text on the page more clear. Or just remove "Outbox" completely, I'm not sure it's really useful.

Mar 11 2016, 1:02 AM · Restricted Project, Mail, Bug Report
epriestley added a comment to T10564: Mail "Delivery" tab is confusing..

That is, "Delivery" is "delivery to you, the viewer". Maybe that's what's unclear?

Mar 11 2016, 1:01 AM · Restricted Project, Mail, Bug Report
epriestley added a comment to T10564: Mail "Delivery" tab is confusing..

The "Delivery" tab is specific to the viewer, not the mail. There's no way to see see why mail was or wasn't delivered to other users.

Mar 11 2016, 12:58 AM · Restricted Project, Mail, Bug Report
epriestley added a comment to T10564: Mail "Delivery" tab is confusing..

223663 is you adding a comment to Conpherence.
184911 is you moving a task on a workboard.
219192 is you attaching a task to a revision.

Mar 11 2016, 12:56 AM · Restricted Project, Mail, Bug Report
epriestley added a comment to T10564: Mail "Delivery" tab is confusing..

I can't actually see them, let me go pull up the console.

Mar 11 2016, 12:50 AM · Restricted Project, Mail, Bug Report
epriestley added a comment to T10564: Mail "Delivery" tab is confusing..

In all of them, I'm the actor, but they specify "Self Mail" as the (a) reason for voiding.
I do have "self mail" disabled, so it might be taking that?

Mar 11 2016, 12:43 AM · Restricted Project, Mail, Bug Report
epriestley closed T10562: Inline comments can become separated if replies cross update boundaries as Resolved by committing Restricted Diffusion Commit.
Mar 11 2016, 12:41 AM · Differential, Restricted Project
epriestley added a comment to T10563: Inline comments displayed on the same line are shown in creation order without regard for threading.

D15459 is a partial fix here. Here's an "after":

Mar 11 2016, 12:40 AM · Inline Comments, Differential, Restricted Project
epriestley added a revision to T10563: Inline comments displayed on the same line are shown in creation order without regard for threading: Unknown Object (Differential Revision).
Mar 11 2016, 12:36 AM · Inline Comments, Differential, Restricted Project
epriestley added a comment to T10562: Inline comments can become separated if replies cross update boundaries.

D15458 is not a retroactive fix, but new comments made after that change should no longer be separable.

Mar 11 2016, 12:09 AM · Differential, Restricted Project
epriestley added a revision to T10562: Inline comments can become separated if replies cross update boundaries: Unknown Object (Differential Revision).
Mar 11 2016, 12:08 AM · Differential, Restricted Project
epriestley created T10563: Inline comments displayed on the same line are shown in creation order without regard for threading.
Mar 11 2016, 12:00 AM · Inline Comments, Differential, Restricted Project

Mar 10 2016

epriestley claimed T10562: Inline comments can become separated if replies cross update boundaries.
Mar 10 2016, 11:55 PM · Differential, Restricted Project
epriestley created T10562: Inline comments can become separated if replies cross update boundaries.
Mar 10 2016, 11:52 PM · Differential, Restricted Project
greggrossmeier awarded Blog Post: Write, Review, Merge, Publish: Phabricator Review Workflow a Mountain of Wealth token.
Mar 10 2016, 11:33 PM
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

That key seems like it's probably not great for the OR changeType part of the query. If you still have the table handy and playing with it doesn't take an unreasonably huge amount of time, is this better?

Mar 10 2016, 11:09 PM · Infrastructure
epriestley added a comment to T10561: Make code coverage optional by default.

getEnableCoverage() returns three values:

Mar 10 2016, 11:03 PM · Unit, Bug Report, Arcanist
epriestley claimed T7789: Support Git Large File Storage.
Mar 10 2016, 6:24 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T7789: Support Git Large File Storage.

I'm going to figure out what the state of large PUTs

Mar 10 2016, 6:08 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to Blog Post: Development Notes (2016 Week 10).

Sorry, I'm still not understanding what specific change you're concerned about. Isn't the information in the same place -- with the same behavior -- as it was before?

Mar 10 2016, 3:46 PM
epriestley added a comment to Blog Post: Development Notes (2016 Week 10).

I miss the create date being easily visible.

Mar 10 2016, 3:38 PM
epriestley updated subscribers of T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Mar 10 2016, 2:54 PM · Restricted Project, Auth, Conduit
epriestley merged task T10557: callConduitWithDiffusionRequest failed with non-latin characters parameters into T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Mar 10 2016, 2:54 PM · Bug Report
epriestley added a comment to T10555: Support for private build systems and public phabricators.

I added you to Community so you should have access now.

Mar 10 2016, 2:20 PM · Harbormaster, Feature Request
epriestley added a member for Community: featherless.
Mar 10 2016, 2:20 PM
epriestley added a comment to T10556: edit policy message.

To clarify, you're expecting the error message to disappear immediately, before you submit the form?

Mar 10 2016, 2:09 PM · Bug Report
epriestley added a comment to T10555: Support for private build systems and public phabricators.

You can sort of do this like this:

Mar 10 2016, 2:08 PM · Harbormaster, Feature Request
epriestley closed T10554: 把demo稿快画出来 as Spite.
Mar 10 2016, 1:37 PM · Feature Request
epriestley added a comment to T7789: Support Git Large File Storage.

This may make sense to at least lightly entangle with T4752, which overlaps in some ways.

Mar 10 2016, 1:37 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T7789: Support Git Large File Storage.

To do an integrity check, it looks like we have to compute the Git hash ourselves.

Mar 10 2016, 1:31 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T7789: Support Git Large File Storage.

As a general preface, this stuff makes me a little uneasy about LFS in its current state:

Mar 10 2016, 1:09 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

D15454 changes the wording to:

Mar 10 2016, 2:49 AM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley added a revision to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications): Unknown Object (Differential Revision).
Mar 10 2016, 2:48 AM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

We should probably change the text on "placed up for grabs" to "unassigned from X". I don't think we use that term anywhere else nowadays, either.

Mar 10 2016, 2:44 AM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley created P1957 AddANoteDifferentialField.php.
Mar 10 2016, 1:48 AM

Mar 9 2016

epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 9 2016, 3:35 PM · Nuance, GitHub
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 9 2016, 2:46 PM · Nuance, GitHub
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 9 2016, 1:39 PM · Nuance, GitHub
epriestley added a comment to T10538: Bridge GitHub to Phabricator.

The "Issue Events API" appears to provide the remaining events in a different format with different rules. It does not provide any duplicate events, so, e.g., one API retrieves issues being created and commented on while a different API retrieves labels, milestones, etc., except that both report opens and closes, I think. Anyway, seems mostly workable.

Mar 9 2016, 1:31 PM · Nuance, GitHub
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 9 2016, 12:59 PM · Nuance (v1)
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 9 2016, 12:59 PM · Nuance, GitHub
hach-que awarded T10538: Bridge GitHub to Phabricator a Love token.
Mar 9 2016, 12:58 PM · Nuance, GitHub
epriestley added a comment to T10538: Bridge GitHub to Phabricator.

Alright, so here's the first real issue. Here's what I did on GitHub:

Mar 9 2016, 12:51 PM · Nuance, GitHub
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 9 2016, 12:03 PM · Nuance (v1)
epriestley added a comment to T10419: Sample herald rule results.

is there a way to add subscribers via lint rules?

Mar 9 2016, 4:19 AM · Herald, Feature Request
epriestley added a comment to T9410: Policy behavior for Herald rules is murky and inconsistent.

Primarily, I'm just hesitant to make changes where you upgrade and previously-private stuff becomes public, since I think that's a terrifying behavior in the general case and maybe even worse than destroying data.

Mar 9 2016, 12:18 AM · Restricted Project, Herald, Restricted Project
epriestley added a comment to T9410: Policy behavior for Herald rules is murky and inconsistent.

To provide a little context, I suspect we'll just make personal rules publicly visible. Long ago, transaction records were not as explicit or complete as they are today and you could sort of hide your "keep an eye on the suspicious interns" rules a little better, so this policy behavior wasn't totally silly, but it's almost impossible to actually hide any information now.

Mar 9 2016, 12:12 AM · Restricted Project, Herald, Restricted Project
epriestley added a revision to T8941: Badges don't show in certain Timeline conditions: Unknown Object (Differential Revision).
Mar 9 2016, 12:01 AM · Badges (v0)

Mar 8 2016

epriestley renamed T9410: Policy behavior for Herald rules is murky and inconsistent from Herald Transcript does not contain links back to original rules to Policy behavior for Herald rules is murky and inconsistent.
Mar 8 2016, 11:56 PM · Restricted Project, Herald, Restricted Project
epriestley updated subscribers of T9410: Policy behavior for Herald rules is murky and inconsistent.
Mar 8 2016, 11:56 PM · Restricted Project, Herald, Restricted Project
epriestley merged task T10542: personal herald rules should be able to be visible to more than just their owner into T9410: Policy behavior for Herald rules is murky and inconsistent.
Mar 8 2016, 11:56 PM · Herald, Feature Request
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 8 2016, 9:40 PM · Nuance (v1)
johnny-bit awarded T10538: Bridge GitHub to Phabricator a The World Burns token.
Mar 8 2016, 8:16 PM · Nuance, GitHub
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 8 2016, 6:27 PM · Nuance (v1)
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Restricted Differential Revision.
Mar 8 2016, 6:27 PM · Nuance, GitHub
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 8 2016, 4:34 PM · Nuance (v1)
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 8 2016, 4:34 PM · Nuance, GitHub