Page MenuHomePhabricator
Feed Advanced Search

Feb 17 2016

eadler added a project to T10374: Permit creating macros out of existing files: Macros.
Feb 17 2016, 8:01 PM · Restricted Project, Macros, Feature Request

Nov 24 2015

epriestley renamed T9818: Memes with multiline texts have their text placed incorrectly from Memes with multiline texts have their text placed incorrect to Memes with multiline texts have their text placed incorrectly.
Nov 24 2015, 5:22 PM · Macros
epriestley moved T5258: Memes use older image transform code without modern error handling from Backlog to vNext on the Files board.
Nov 24 2015, 4:58 PM · Restricted Project, Macros, Files

Nov 21 2015

epriestley triaged T9818: Memes with multiline texts have their text placed incorrectly as Wishlist priority.

Deeply tragic.

Nov 21 2015, 5:29 PM · Macros

Nov 19 2015

claassen created T9818: Memes with multiline texts have their text placed incorrectly.
Nov 19 2015, 4:11 PM · Macros

Nov 9 2015

chad closed Q212: Macro: You must upload an image. as resolved.
Nov 9 2015, 7:01 PM · Macros
Luke081515.2 updated Q212: Macro: You must upload an image. from to Macro: You must upload an image..
Nov 9 2015, 6:41 PM · Macros

Oct 24 2015

epriestley merged task T9624: Creating macro doesn't show macro logo in user feed into T9625: Fill in missing applications and icons on PHID types.
Oct 24 2015, 1:19 PM · Macros
revi created T9624: Creating macro doesn't show macro logo in user feed.
Oct 24 2015, 12:41 PM · Macros

Sep 18 2015

epriestley added a comment to T9442: Image macros do not include "objectPHID" on page details, so notifications don't clear.

It worked!

Sep 18 2015, 9:06 PM · Macros, Notifications
chad closed T9442: Image macros do not include "objectPHID" on page details, so notifications don't clear as Resolved by committing rP36c8df3ef95b: Add pageObjects to Macro.
Sep 18 2015, 8:58 PM · Macros, Notifications
chad added a revision to T9442: Image macros do not include "objectPHID" on page details, so notifications don't clear: D14129: Add pageObjects to Macro.
Sep 18 2015, 8:57 PM · Macros, Notifications
epriestley created T9442: Image macros do not include "objectPHID" on page details, so notifications don't clear.
Sep 18 2015, 7:34 PM · Macros, Notifications

Jul 29 2015

epriestley updated subscribers of T5258: Memes use older image transform code without modern error handling.
Jul 29 2015, 1:23 AM · Restricted Project, Macros, Files
epriestley merged task T8997: Duplicate entry for key 'originalPHID' into T5258: Memes use older image transform code without modern error handling.
Jul 29 2015, 1:23 AM · Macros
joshuaspence created T8997: Duplicate entry for key 'originalPHID'.
Jul 29 2015, 1:20 AM · Macros

Jun 30 2015

chad lowered the priority of T3562: Design Meme/Macro Picker from Normal to Wishlist.
Jun 30 2015, 7:05 PM · User Delight, Design, Macros

Jun 29 2015

epriestley closed T8703: Unable to edit macro comments as Resolved by committing rPb39f5d651c42: Modernize transaction comment editor.
Jun 29 2015, 6:30 PM · Macros
epriestley added a comment to T8703: Unable to edit macro comments.

I think that should fix it, thanks for the report.

Jun 29 2015, 1:43 PM · Macros
epriestley claimed T8703: Unable to edit macro comments.
Jun 29 2015, 1:42 PM · Macros
epriestley added a revision to T8703: Unable to edit macro comments: D13469: Modernize transaction comment editor.
Jun 29 2015, 1:38 PM · Macros

Jun 28 2015

FvD created T8703: Unable to edit macro comments.
Jun 28 2015, 9:10 PM · Macros

Jun 5 2015

terro added a comment to T7886: meme can't show CJK language with 'above' option..

@chad roger that. thanks!

Jun 5 2015, 3:09 PM · Macros

Jun 2 2015

chad added a comment to T7886: meme can't show CJK language with 'above' option..

@terro, you should be able to follow the comments here and install a CJK font resource to your install.

Jun 2 2015, 1:40 PM · Macros
chad updated subscribers of T7886: meme can't show CJK language with 'above' option..
Jun 2 2015, 1:36 PM · Macros
chad merged task T8386: Unicode characters not shown in Memes into T7886: meme can't show CJK language with 'above' option..
Jun 2 2015, 1:36 PM · Macros
terro created T8386: Unicode characters not shown in Memes.
Jun 2 2015, 12:15 PM · Macros

May 27 2015

enko added a comment to T5258: Memes use older image transform code without modern error handling.

I do not know if this is related:

May 27 2015, 10:45 PM · Restricted Project, Macros, Files

May 22 2015

epriestley added a subtask for T3562: Design Meme/Macro Picker: T7805: Use ApplicationSearch in the ObjectSelector dialog.
May 22 2015, 3:39 PM · User Delight, Design, Macros

May 20 2015

epriestley added a comment to T5258: Memes use older image transform code without modern error handling.

Filed as T8277.

May 20 2015, 3:56 PM · Restricted Project, Macros, Files
epriestley added a comment to T5258: Memes use older image transform code without modern error handling.

I'll file that separately.

May 20 2015, 3:52 PM · Restricted Project, Macros, Files
cburroughs added a comment to T5258: Memes use older image transform code without modern error handling.

On a possibly related note, when messing with increasing the timeout to get a meme to work (memes are very important for delivering business value) I once got:

May 20 2015, 3:22 PM · Restricted Project, Macros, Files

May 13 2015

epriestley added a comment to T5258: Memes use older image transform code without modern error handling.

This is now resolved for non-meme cases.

May 13 2015, 6:45 PM · Restricted Project, Macros, Files
epriestley renamed T5258: Memes use older image transform code without modern error handling from `CommandException` when trying to create a thumbnail to Memes use older image transform code without modern error handling.
May 13 2015, 6:45 PM · Restricted Project, Macros, Files

May 12 2015

epriestley added a revision to T5258: Memes use older image transform code without modern error handling: D12809: Make modular transforms handle exceptions gracefully.
May 12 2015, 3:20 PM · Restricted Project, Macros, Files
epriestley added a parent task for T5258: Memes use older image transform code without modern error handling: T7707: Implement a read-through cache layer.
May 12 2015, 12:39 PM · Restricted Project, Macros, Files

Apr 22 2015

seungrye closed T7886: meme can't show CJK language with 'above' option. as Invalid.

I copied CJK font to reosurces/fonts/impact.ttf, then it worked.
Invalid Reporting. Close issue.

Apr 22 2015, 2:40 PM · Macros
seungrye added a comment to T7886: meme can't show CJK language with 'above' option..

Ah.. I missed the manual again ;;
I'll try it. Thanks : )

Apr 22 2015, 2:19 PM · Macros
chad added a comment to T7886: meme can't show CJK language with 'above' option..

Code location of the font selection is here:
https://secure.phabricator.com/diffusion/P/browse/master/src/applications/files/PhabricatorImageTransformer.php;4dea152215cc008239ddc5fcccd5742c9243fb1e$319

Apr 22 2015, 2:18 PM · Macros
chad added a comment to T7886: meme can't show CJK language with 'above' option..

Try replacing the stock font with one that supports extended character sets? By default we support Tuffy and Impact, but you can modify the code to support other extended sets.

Apr 22 2015, 2:15 PM · Macros
chad raised the priority of T7886: meme can't show CJK language with 'above' option. from Low to Needs Triage.
Apr 22 2015, 1:42 PM · Macros
seungrye created T7886: meme can't show CJK language with 'above' option..
Apr 22 2015, 11:31 AM · Macros

Mar 27 2015

Hectorete added a comment to T5258: Memes use older image transform code without modern error handling.

mola?

Mar 27 2015, 11:24 AM · Restricted Project, Macros, Files

Jan 25 2015

epriestley added a parent task for T6670: Macro images don't show up on html emails if your instance requires logins: T992: Send rich HTML mail bodies without impacting reply handling functionality.
Jan 25 2015, 12:10 AM · Macros, Mail

Jan 22 2015

epriestley added a comment to T7008: Provide some way of resizing macros.

Oh, I figured it out. I think you meant to post this:

Jan 22 2015, 9:14 PM · Macros
chad added a comment to T7008: Provide some way of resizing macros.

No?

Jan 22 2015, 9:00 PM · Macros
epriestley added a comment to T7008: Provide some way of resizing macros.

Did you just post an empty comment? I don't see anything at all.

Jan 22 2015, 8:57 PM · Macros
chad added a comment to T7008: Provide some way of resizing macros.

ohkay.png (875×680 px, 383 KB)

Jan 22 2015, 8:53 PM · Macros
epriestley added a comment to T7008: Provide some way of resizing macros.

What's that supposed to be? I can barely make it out.

Jan 22 2015, 8:52 PM · Macros
chad added a comment to T7008: Provide some way of resizing macros.

ohkay

Jan 22 2015, 8:45 PM · Macros
epriestley added a comment to T7008: Provide some way of resizing macros.

I'm supportive of this feature on the condition that it only allows you to make macros larger.

Jan 22 2015, 7:43 PM · Macros
chad triaged T7008: Provide some way of resizing macros as Wishlist priority.
Jan 22 2015, 4:24 PM · Macros
hach-que created T7008: Provide some way of resizing macros.
Jan 22 2015, 5:08 AM · Macros

Dec 2 2014

talshiri added a comment to T6670: Macro images don't show up on html emails if your instance requires logins.

It would be nice (and maybe pretty complex) for (3) to work if you happen to use S3 (which would work if you instance is behind VPN), although right now the Phabricator guide does not recommend using it.

Dec 2 2014, 7:17 PM · Macros, Mail
epriestley added a comment to T6670: Macro images don't show up on html emails if your instance requires logins.

A couple of sources I've seen say Gmail strips data URIs. I haven't actually tested them, but that's why I'm ruling them out. Maybe worth actually testing.

Dec 2 2014, 7:07 PM · Macros, Mail
talshiri added a comment to T6670: Macro images don't show up on html emails if your instance requires logins.

What about inlining the images with data:base64 ?
Sure it will make emails with images bigger, but it will always work and most emails don't have macros.

Dec 2 2014, 7:05 PM · Macros, Mail
chad triaged T6670: Macro images don't show up on html emails if your instance requires logins as Normal priority.
Dec 2 2014, 4:26 PM · Macros, Mail
epriestley edited projects for T6670: Macro images don't show up on html emails if your instance requires logins, added: Macros; removed Phabricator.
Dec 2 2014, 2:06 PM · Macros, Mail

Nov 11 2014

chad added a project to T3562: Design Meme/Macro Picker: User Delight.
Nov 11 2014, 10:10 PM · User Delight, Design, Macros

Nov 3 2014

chad edited projects for T3562: Design Meme/Macro Picker, added: Design; removed Phabricator.
Nov 3 2014, 3:50 AM · User Delight, Design, Macros

Sep 18 2014

epriestley created T6121: Support non-latin characters in macros.
Sep 18 2014, 1:13 AM · Macros

Aug 27 2014

hach-que closed T5974: If no words are set using the meme button, embed the image macro directly as a duplicate.

✘ Merged into T5741.

Aug 27 2014, 3:32 AM · Macros
hach-que updated subscribers of T5741: Transparent meme animated gifs show up with a black background.

◀ Merged tasks: T5974.

Aug 27 2014, 3:32 AM · Macros
hach-que added a comment to T5974: If no words are set using the meme button, embed the image macro directly.

I'll just merge this into the other one.

Aug 27 2014, 3:31 AM · Macros
chad added a comment to T5974: If no words are set using the meme button, embed the image macro directly.

This feels mostly like T5741, can we close one with all of the related info?

Aug 27 2014, 3:03 AM · Macros
hach-que created T5974: If no words are set using the meme button, embed the image macro directly.
Aug 27 2014, 2:21 AM · Macros

Aug 20 2014

epriestley closed T5918: Memes no longer work because of a refusal to redirect as Resolved.

Closed by commit rPa46d1f1cd883.

Aug 20 2014, 1:59 PM · Macros
epriestley added a revision to T5918: Memes no longer work because of a refusal to redirect: D10307: Flag meme redirect as external.
Aug 20 2014, 1:08 PM · Macros
hach-que renamed T5918: Memes no longer work because of a refusal to redirect from Meme's no longer work because of a refusal to redirect to Memes no longer work because of a refusal to redirect.
Aug 20 2014, 6:39 AM · Macros
hach-que added a project to T5918: Memes no longer work because of a refusal to redirect: Macros.
Aug 20 2014, 6:37 AM · Macros

Aug 13 2014

epriestley added a comment to T5865: Add to user display preferences the possibility not to expand macros.

permissions around creating macros

Aug 13 2014, 4:50 AM · Wikimedia, Macros
btrahan added a comment to T5865: Add to user display preferences the possibility not to expand macros.

I'm slightly annoyed by your block of this preference idea, when words like Clowncopterize (something apparently appreciated in early Phabricator reviews) disappeared.

Aug 13 2014, 4:39 AM · Wikimedia, Macros
dereckson added a comment to T5865: Add to user display preferences the possibility not to expand macros.
In T5865#10, @chad wrote:

It's actually surprising to me it took this many years for someone to ask for this feature.

The possibility to deinstall macro application (or more easily: simply by not uploading stuff) is probably why it has never been requested.

Aug 13 2014, 2:28 AM · Wikimedia, Macros
epriestley closed T5865: Add to user display preferences the possibility not to expand macros as Wontfix.

I'd recommend uninstalling the Macro application if you have an install where "some users" find some macros torturous at any size.

Aug 13 2014, 2:11 AM · Wikimedia, Macros
dereckson added a comment to T5865: Add to user display preferences the possibility not to expand macros.

people who suffer from them will still be tortured by the compact view.

So any image at all, even if small and non-animated, is torturous to you?

Aug 13 2014, 2:07 AM · Wikimedia, Macros
chad added a comment to T5865: Add to user display preferences the possibility not to expand macros.

It's actually surprising to me it took this many years for someone to ask for this feature.

Aug 13 2014, 2:06 AM · Wikimedia, Macros
epriestley added a comment to T5865: Add to user display preferences the possibility not to expand macros.

people who suffer from them will still be tortured by the compact view.

Aug 13 2014, 1:46 AM · Wikimedia, Macros
dereckson added a comment to T5865: Add to user display preferences the possibility not to expand macros.

Cost/benefit of the "compact" macro view seems pretty low for me:

  • people who like animated animated GIF and random picture are okay with the big size.
  • people who suffer from them will still be tortured by the compact view.
Aug 13 2014, 1:35 AM · Wikimedia, Macros
dereckson moved T5865: Add to user display preferences the possibility not to expand macros from Backlog to Details on the Wikimedia board.
Aug 13 2014, 1:26 AM · Wikimedia, Macros
epriestley updated subscribers of T5865: Add to user display preferences the possibility not to expand macros.

I think adding an option like this is probably the right product choice, despite the fun-hating involved.

Aug 13 2014, 1:26 AM · Wikimedia, Macros
dereckson added a comment to T5865: Add to user display preferences the possibility not to expand macros.

Added Wikimedia project per Bug 42467 - "Zarro Boogs found" is unhelpful (of course, this is a pretext, the truth is I don't want to see images on the Phabricator instances I use).

Aug 13 2014, 1:08 AM · Wikimedia, Macros
dereckson created T5865: Add to user display preferences the possibility not to expand macros.
Aug 13 2014, 12:59 AM · Wikimedia, Macros