Page MenuHomePhabricator
Feed Advanced Search

Dec 5 2015

epriestley closed T6270: Search inside Paste as Invalid.

This task doesn't describe a root problem. See Contributing Feature Requests for modern documentation on feature requests.

Dec 5 2015, 9:24 PM · Paste
epriestley closed T8556: Pastes index fails to load. as Invalid.

In any case, we can't reproduce this and aren't sure if it reproduces at HEAD. See Contributing Bug Reports.

Dec 5 2015, 9:22 PM · Paste
epriestley added a comment to T9077: Some applications don't support the "Quote" action on comments properly.

See also D14665 for EditEngine integration, which slightly changes one call.

Dec 5 2015, 9:21 PM · Restricted Project, Transactions

Dec 4 2015

epriestley closed T9904: The Paste app doesn't work as Resolved.

Cool, let us know if you run into anything else.

Dec 4 2015, 11:47 PM · Paste
nickz added a comment to T9904: The Paste app doesn't work.

Yeah, I upgraded my dev instance to Head which doesn't have this issue. Thanks!

Dec 4 2015, 11:46 PM · Paste
epriestley added a comment to T9904: The Paste app doesn't work.

(At the least, I can't reproduce these issues at HEAD.)

Dec 4 2015, 11:43 PM · Paste
epriestley added a comment to T9904: The Paste app doesn't work.

You're a few days out of date -- I believe both of these issues are fixed at HEAD. Can you upgrade and let me know if you're still seeing issues?

Dec 4 2015, 11:43 PM · Paste
nickz created T9904: The Paste app doesn't work.
Dec 4 2015, 11:38 PM · Paste

Nov 27 2015

epriestley closed T9856: array_diff(): Argument #1 is not an array as Invalid.

I don't know how to reproduce this, either. This may fix itself as T9132 evolves.

Nov 27 2015, 5:55 PM · Paste, Infrastructure

Nov 26 2015

epriestley closed T9857: Column 'content' cannot be null as Resolved.

Fixed in HEAD (D14571).

Nov 26 2015, 12:39 AM · Infrastructure, Paste
joshuaspence created T9857: Column 'content' cannot be null.
Nov 26 2015, 12:07 AM · Infrastructure, Paste
joshuaspence created T9856: array_diff(): Argument #1 is not an array.
Nov 26 2015, 12:06 AM · Paste, Infrastructure

Nov 25 2015

epriestley added a comment to T9850: Creating a new paste fails with unhandled exception.

Thanks! Should be fixed in HEAD.

Nov 25 2015, 4:29 PM · ApplicationEditor, Paste
epriestley closed T9850: Creating a new paste fails with unhandled exception as Resolved by committing rPb21928599960: Fix handling of implicit comment transaction in paste creation.
Nov 25 2015, 4:25 PM · ApplicationEditor, Paste
epriestley added a revision to T9850: Creating a new paste fails with unhandled exception: D14571: Fix handling of implicit comment transaction in paste creation.
Nov 25 2015, 4:24 PM · ApplicationEditor, Paste
epriestley claimed T9850: Creating a new paste fails with unhandled exception.
Nov 25 2015, 4:12 PM · ApplicationEditor, Paste
chad updated subscribers of T9850: Creating a new paste fails with unhandled exception.
Nov 25 2015, 3:32 PM · ApplicationEditor, Paste
erik.fercak created T9850: Creating a new paste fails with unhandled exception.
Nov 25 2015, 3:25 PM · ApplicationEditor, Paste

Nov 17 2015

epriestley closed T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor as Resolved by committing rP06de60599288: Extract PHIDs from transactions later, fixing Paste extraction/attachment.
Nov 17 2015, 4:37 PM · ApplicationEditor, Paste

Nov 16 2015

epriestley added a revision to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor: D14494: Extract PHIDs from transactions later, fixing Paste extraction/attachment.
Nov 16 2015, 6:22 PM · ApplicationEditor, Paste
epriestley renamed T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor from Unable to view raw paste to Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.
Nov 16 2015, 6:18 PM · ApplicationEditor, Paste
epriestley added a revision to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor: D14493: Fix file PHID extraction in Owners and Differential.
Nov 16 2015, 6:02 PM · ApplicationEditor, Paste

Nov 15 2015

dereckson renamed T8482: PhabricatorPasteTestDataGenerator: Call to a member function getPHID() on null from Lipsum generator is broken to PhabricatorPasteTestDataGenerator: Call to a member function getPHID() on null.
Nov 15 2015, 12:56 AM · Paste, Infrastructure

Nov 14 2015

epriestley added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

I'm partly just guessing here but I think It's almost certainly my fault.

Nov 14 2015, 11:46 PM · ApplicationEditor, Paste
joshuaspence added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

Thanks, I spent ~10 minutes on it but couldn't figure it out.

Nov 14 2015, 11:45 PM · ApplicationEditor, Paste
epriestley added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

File should be getting attached to the paste, but isn't. I think I accidentally caused a side effect here when changing how the transaction works.

Nov 14 2015, 11:44 PM · ApplicationEditor, Paste
epriestley claimed T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.
Nov 14 2015, 11:44 PM · ApplicationEditor, Paste
joshuaspence added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

Actually something weird is going on... I can't edit pastes either, even if the Edit Policy is set to "All Users".

Nov 14 2015, 11:35 PM · ApplicationEditor, Paste
joshuaspence added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

I'm not sure how to fix this without adding pastePHID to PhabricatorFile, which doesn't feel like the best approach.

Nov 14 2015, 11:33 PM · ApplicationEditor, Paste
joshuaspence added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

I started looking at this. It seems like the file attached to the Paste has a view policy of no-one, whereas it should probably inherit the view policy of the parent Paste.

Nov 14 2015, 11:28 PM · ApplicationEditor, Paste
joshuaspence created T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.
Nov 14 2015, 11:26 PM · ApplicationEditor, Paste

Nov 8 2015

epriestley added a comment to T9735: Fix `paste.create` conduit method in the wake of edit engine support.
  • I cherry-picked this to stable (rP111c48b2).
  • I deployed this fix to the Phacility cluster.
Nov 8 2015, 3:11 PM · ApplicationEditor, Paste
epriestley closed T9735: Fix `paste.create` conduit method in the wake of edit engine support as Resolved by committing rP2b41ed01c692: Fix no-op transaction error on `paste.create` Conduit API method.
Nov 8 2015, 3:09 PM · ApplicationEditor, Paste
epriestley added a revision to T9735: Fix `paste.create` conduit method in the wake of edit engine support: D14440: Fix no-op transaction error on `paste.create` Conduit API method.
Nov 8 2015, 1:24 PM · ApplicationEditor, Paste
epriestley added a comment to T9735: Fix `paste.create` conduit method in the wake of edit engine support.

Wasn't aware of this one, thanks.

Nov 8 2015, 1:19 PM · ApplicationEditor, Paste
epriestley claimed T9735: Fix `paste.create` conduit method in the wake of edit engine support.
Nov 8 2015, 1:19 PM · ApplicationEditor, Paste

Nov 5 2015

joshuaspence added a revision to T9077: Some applications don't support the "Quote" action on comments properly: D14416: Make all comments quotable.
Nov 5 2015, 8:09 PM · Restricted Project, Transactions

Nov 3 2015

joshuaspence closed T9075: Generate transaction when a paste is forked as Wontfix.

The ability to fork Pastes was removed in D14390.

Nov 3 2015, 7:33 PM · Paste
chad added a comment to T9696: /paste/ fails to load.

Upgrades are cool!

Nov 3 2015, 4:46 AM · Paste, Restricted Project
jhurwitz moved T9696: /paste/ fails to load from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 3 2015, 12:57 AM · Paste, Restricted Project
epriestley closed T9696: /paste/ fails to load as Resolved.

Upgrade to fe7d8c2.

Nov 3 2015, 12:55 AM · Paste, Restricted Project

Nov 2 2015

jhurwitz created T9696: /paste/ fails to load.
Nov 2 2015, 11:54 PM · Paste, Restricted Project

Oct 26 2015

epriestley closed T9632: Maximum execution time of 30 seconds exceeded as Resolved by committing rPHUfe7d8c21a808: Improve UTF8StringTruncator behavior for huge inputs.
Oct 26 2015, 4:49 PM · Paste
epriestley added a revision to T9632: Maximum execution time of 30 seconds exceeded: D14339: Improve UTF8StringTruncator behavior for huge inputs.
Oct 26 2015, 2:53 PM · Paste
epriestley claimed T9632: Maximum execution time of 30 seconds exceeded.
Oct 26 2015, 1:12 PM · Paste
joshuaspence created T9632: Maximum execution time of 30 seconds exceeded.
Oct 26 2015, 1:58 AM · Paste

Oct 20 2015

gd closed T9600: Paste should truncate very long lines in ApplicationSearch result list snippets as Resolved by committing rP421c2453e5e4: Truncate long source lines in Paste search result list snippets.
Oct 20 2015, 7:07 PM · Paste
gd added a revision to T9600: Paste should truncate very long lines in ApplicationSearch result list snippets: D14313: Truncate long source lines in Paste search result list snippets.
Oct 20 2015, 4:30 PM · Paste

Oct 19 2015

epriestley added a comment to T9600: Paste should truncate very long lines in ApplicationSearch result list snippets.

There's a vaguely related but much less severe issue where the list view can take a long time to load because it needs to pull a bunch of files off S3 in order to generate the content caches.

Oct 19 2015, 3:57 PM · Paste
epriestley renamed T9600: Paste should truncate very long lines in ApplicationSearch result list snippets from Paste list should truncate very long lines in previews to Paste should truncate very long lines in ApplicationSearch result list snippets.
Oct 19 2015, 3:30 PM · Paste
gd added a comment to T9600: Paste should truncate very long lines in ApplicationSearch result list snippets.

I tried implementing this myself but got a bit stuck. Since lines and line limit is passed to PhabricatorSourceCodeView from PhabricatorPasteSearchEngine::renderResultList() this looked like a good place to start, and pass line length limit. The problem I've encountered is that PhabricatorSourceCodeView receives lines already in HTML. Even though stripping tags and converting HTML entities back to original characters to get line length is easily doable but seems a bit awkward. And then truncating HTML markup is even more problematic...

Oct 19 2015, 3:29 PM · Paste
epriestley added a comment to T9600: Paste should truncate very long lines in ApplicationSearch result list snippets.

Ohhh! Sorry, we usually use "preview" to mean "remarkup preview" (the comment box thing at the bottom of the page) and I figured you were putting {P123} in a comment and getting slow comment previews.

Oct 19 2015, 3:26 PM · Paste
gd added a comment to T9600: Paste should truncate very long lines in ApplicationSearch result list snippets.

This is about Paste application index page. I guess more generally speaking it would paste search query result list.

Oct 19 2015, 3:24 PM · Paste
epriestley added a comment to T9600: Paste should truncate very long lines in ApplicationSearch result list snippets.

From T9566, these are probably 1MB JSON blobs from API calls.

Oct 19 2015, 3:20 PM · Paste
chad added a comment to T9600: Paste should truncate very long lines in ApplicationSearch result list snippets.

Out of curiosity, why use Paste for that much code?

Oct 19 2015, 3:03 PM · Paste
gd created T9600: Paste should truncate very long lines in ApplicationSearch result list snippets.
Oct 19 2015, 2:24 PM · Paste

Oct 17 2015

epriestley merged task T9566: Timeouts when highlighting source with very long lines using pygmentize into T9587: Detect old Pygments versions and encourage an upgrade.
Oct 17 2015, 10:24 AM · Paste
epriestley reopened T9566: Timeouts when highlighting source with very long lines using pygmentize as "Open".
Oct 17 2015, 10:24 AM · Paste
epriestley added a comment to T9566: Timeouts when highlighting source with very long lines using pygmentize.

That was just some random demo user clicking buttons. I'll merge 'em.

Oct 17 2015, 10:24 AM · Paste
gd added a comment to T9566: Timeouts when highlighting source with very long lines using pygmentize.

I'm not sure this is related to "T9415: PhabricatorApplicationTransactionPublishWorker requires unreasonable amount of memory for large numbers of mail recipients?".

Oct 17 2015, 9:21 AM · Paste
ricky.liddard merged task T9566: Timeouts when highlighting source with very long lines using pygmentize into T9415: PhabricatorApplicationTransactionPublishWorker requires unreasonable amount of memory for large numbers of mail recipients?.
Oct 17 2015, 7:10 AM · Paste

Oct 16 2015

epriestley added a revision to T9566: Timeouts when highlighting source with very long lines using pygmentize: D14292: Add an upstream JSON fragment lexer.
Oct 16 2015, 2:54 PM · Paste

Oct 15 2015

joshuaspence added a comment to T9077: Some applications don't support the "Quote" action on comments properly.

Quotes also don't work in Ponder.

Oct 15 2015, 2:45 AM · Restricted Project, Transactions

Oct 14 2015

gd added a revision to T9566: Timeouts when highlighting source with very long lines using pygmentize: D14273: Skip pygmentize for large source and too long lines.
Oct 14 2015, 12:16 PM · Paste
gd created T9566: Timeouts when highlighting source with very long lines using pygmentize.
Oct 14 2015, 11:57 AM · Paste

Oct 7 2015

chad added a comment to T9522: CSS rule "word-break: break-word" breaks line numbers on innline pastes and table headers on phriction documents.

I'm not able to reproduce this at HEAD. Are you sure your install is up to date? We expected D14063 to resolve this. If this still reproduces at HEAD, can you give us a better idea of OS/Browser for testing?

Oct 7 2015, 1:59 PM · PHUI
Pawka added projects to T9522: CSS rule "word-break: break-word" breaks line numbers on innline pastes and table headers on phriction documents: Phriction, Paste, Celerity.
Oct 7 2015, 7:37 AM · PHUI

Oct 1 2015

iradel added a comment to T7877: Default remarkup indented code blocks to lang=<type_of_current_file>.

Regarding mixed-language environments (like sql appearing in a python script), most editors would simply look at the file extension and highlight the entire file in that language (in our example, python.. and the inline sql might appear in the color of a string).

Oct 1 2015, 11:42 PM · Paste, Differential, Remarkup
epriestley updated subscribers of T7877: Default remarkup indented code blocks to lang=<type_of_current_file>.
Oct 1 2015, 11:10 PM · Paste, Differential, Remarkup

Sep 25 2015

epriestley closed T9312: URL Param to pass to Paste to download paste instead of viewing it as Resolved by committing rPb7ca5a2d2981: Provide a stable URI for getting raw paste content.
Sep 25 2015, 5:45 PM · Paste
epriestley added a revision to T9312: URL Param to pass to Paste to download paste instead of viewing it: D14167: Provide a stable URI for getting raw paste content.
Sep 25 2015, 5:18 PM · Paste
epriestley added a comment to T9312: URL Param to pass to Paste to download paste instead of viewing it.

You don't actually care about download/view (i.e., the Content-Disposition of the response), you just want a URL which shows the current contents, right?

Sep 25 2015, 5:10 PM · Paste

Sep 18 2015

witrin closed T9439: Unable to create paste objects as Resolved.

@epriestley Thank you very much! Restarting php-fpm (sudo service php-fpm restart) fixed the issue. :)

Sep 18 2015, 7:00 PM · Paste
epriestley added a comment to T9439: Unable to create paste objects.

Does restarting apache (or php-fpm, if using php-fpm) fix this?

Sep 18 2015, 11:26 AM · Paste
witrin added a comment to T9439: Unable to create paste objects.

Maybe I should check this without our patch. But the patch only regards some files in Phrequent.

Sep 18 2015, 6:50 AM · Paste
witrin created T9439: Unable to create paste objects.
Sep 18 2015, 6:46 AM · Paste

Sep 14 2015

joshuaspence added a comment to T9414: Method for archiving a things are inconsistent occasionally, sometimes.

To be honest, the paste I was archiving was a fork of another paste which I generated when I wanted to find out how forking a paste works.

Sep 14 2015, 8:27 PM · Modernization, Paste
epriestley added a comment to T9414: Method for archiving a things are inconsistent occasionally, sometimes.

I can conceivably land that, I think it just never quite felt right to me. Maybe I'll take another look at it in the new design.

Sep 14 2015, 2:34 PM · Modernization, Paste
chad added a comment to T9414: Method for archiving a things are inconsistent occasionally, sometimes.

D8685 is also maybe related, though we never experimented with that live.

Sep 14 2015, 2:32 PM · Modernization, Paste
epriestley added a comment to T9414: Method for archiving a things are inconsistent occasionally, sometimes.

One mild concern I have with merging these into "Edit" is that the effects of disabling things aren't always self-explanatory, and this dialog gives us an opportunity to explain effects.

Sep 14 2015, 2:28 PM · Modernization, Paste
chad added a comment to T9414: Method for archiving a things are inconsistent occasionally, sometimes.

My main question here is, how often are you archiving Pastes? Is this a one-time clean up or do you do this weekly and archive a dozen and it's very painful? Overall, T9132 would be the most optimal route for mass-archiving.

Sep 14 2015, 2:26 PM · Modernization, Paste
chad added a comment to T9414: Method for archiving a things are inconsistent occasionally, sometimes.

Paste, Pholio, Dashboards, Owners, Badges all work this way. The main reasoning is these items are not usually globally owned (actually Pholio is now) and therefore the vast majority of views will have an action that cannot be taken. I'm personally very hesitant to add additional actions to the action list, specifically it increases the cognitive load on the user and if they won't be able to take the action, it's just clutter.

Sep 14 2015, 2:22 PM · Modernization, Paste
epriestley added a comment to T9414: Method for archiving a things are inconsistent occasionally, sometimes.

Owners and Badges also have this inconsistent archiving flow.

Sep 14 2015, 11:41 AM · Modernization, Paste
johnny-bit added a comment to T9414: Method for archiving a things are inconsistent occasionally, sometimes.

Could this be part of T9132? Seems like one 😉

Sep 14 2015, 10:03 AM · Modernization, Paste
joshuaspence created T9414: Method for archiving a things are inconsistent occasionally, sometimes.
Sep 14 2015, 8:56 AM · Modernization, Paste

Sep 6 2015

joshuaspence triaged T9077: Some applications don't support the "Quote" action on comments properly as Normal priority.
Sep 6 2015, 7:59 AM · Restricted Project, Transactions
joshuaspence claimed T9077: Some applications don't support the "Quote" action on comments properly.
Sep 6 2015, 7:57 AM · Restricted Project, Transactions

Sep 1 2015

ox created T9312: URL Param to pass to Paste to download paste instead of viewing it.
Sep 1 2015, 7:07 PM · Paste

Aug 23 2015

joshuaspence claimed T9075: Generate transaction when a paste is forked.
Aug 23 2015, 11:31 AM · Paste

Aug 9 2015

epriestley added a comment to T8556: Pastes index fails to load..

(I did fix a couple of similar things a while ago, so it seems reasonable that this may be resolved at HEAD.)

Aug 9 2015, 4:29 AM · Paste
epriestley added a comment to T8556: Pastes index fails to load..

Oh! Sorry, ignore me.

Aug 9 2015, 4:28 AM · Paste
chad added a comment to T8556: Pastes index fails to load..

Well.... it was current when the task was filed.

Aug 9 2015, 4:27 AM · Paste
epriestley added a comment to T8556: Pastes index fails to load..

Yeah, you're about two months out of date. Does updating fix the issue? See:

Aug 9 2015, 4:26 AM · Paste
chad added a comment to T8556: Pastes index fails to load..

I can't reproduce anything here, does this still give you an error at HEAD?

Aug 9 2015, 4:25 AM · Paste
eadler added a comment to T9076: Archiving pastes.

Ah, that's how to do it. Create a saved query and then have the dashboard pick it up. Thanks for the info. I was unaware of how dashboards interacted with the rest of the searching infrastructure.

Aug 9 2015, 12:54 AM · Paste

Aug 8 2015

chad added a comment to T9076: Archiving pastes.

Authored just means Authored. It's not Authored, Active.

Aug 8 2015, 8:30 PM · Paste
eadler added a comment to T9076: Archiving pastes.

I meant, in the dashboard view: https://www.dropbox.com/s/ud2vy3nfvjd20n4/Screenshot%202015-08-08%2013.24.58.png?dl=0

Aug 8 2015, 8:25 PM · Paste
chad added a comment to T9076: Archiving pastes.

It works for me:

Aug 8 2015, 8:24 PM · Paste
eadler added a comment to T9076: Archiving pastes.

@chad it isn't possible to search for 'my active authored pastes' which is what we'd like to show in the dashboard. Is this intentional?

Aug 8 2015, 8:21 PM · Paste
chad closed T9076: Archiving pastes as Resolved by committing rP3d1783b2dad4: Add application search for Paste status.
Aug 8 2015, 4:46 PM · Paste