Page MenuHomePhabricator

Extract PHIDs from transactions later, fixing Paste extraction/attachment
ClosedPublic

Authored by epriestley on Nov 16 2015, 6:22 PM.
Tags
None
Referenced Files
F14062263: D14494.diff
Mon, Nov 18, 11:24 AM
F14057461: D14494.id35065.diff
Sun, Nov 17, 3:26 AM
F14057460: D14494.id35078.diff
Sun, Nov 17, 3:25 AM
F14057459: D14494.id.diff
Sun, Nov 17, 3:25 AM
F14048135: D14494.diff
Thu, Nov 14, 6:51 AM
F14041096: D14494.diff
Mon, Nov 11, 3:57 PM
F14039733: D14494.id.diff
Mon, Nov 11, 6:14 AM
F14036912: D14494.diff
Sun, Nov 10, 12:51 PM
Subscribers
None

Details

Summary

Fixes T9787. Currently, file PHID extraction logic happens very early, before we normalize/merge/etc the transactions.

In D14390, I changed how the CONTENT transaction works: before, callers would pass in a file PHID. Afterward, they just pass in the content.

Passing in the content is generaly easier and feels more correct, but inadvertenly broke PHID extraction because converting the content into a file PHID now happened after we extracted the PHID. So we'd extract the entire text of the paste as a "file PHID", which wouldn't work.

Instead, extract file PHIDs later. This impacts a couple of other applications (Conpherence, Pholio) which receive an object or have an unusual file-oriented transaction.

Test Plan
  • Made a new paste, verified the raw file attached to it properly.
  • Made and updated a mock, verified all the files attached properly.
  • Updated a Conpherence room image, verified the files attached properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Extract PHIDs from transactions later, fixing Paste extraction/attachment.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2015, 5:17 AM
This revision was automatically updated to reflect the committed changes.