Page MenuHomePhabricator

Fix handling of implicit comment transaction in paste creation
ClosedPublic

Authored by epriestley on Nov 25 2015, 4:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 4:44 AM
Unknown Object (File)
Thu, Mar 7, 4:43 AM
Unknown Object (File)
Thu, Mar 7, 4:43 AM
Unknown Object (File)
Wed, Mar 6, 5:26 AM
Unknown Object (File)
Feb 15 2024, 7:36 PM
Unknown Object (File)
Feb 12 2024, 9:04 PM
Unknown Object (File)
Feb 12 2024, 9:03 PM
Unknown Object (File)
Feb 12 2024, 8:53 PM
Subscribers
None

Details

Summary

Fixes T9850. The getComment() test should be a hasComment() test, in order to discard empty comments.

Also backport a couple of future fixes which can get you into trouble if you reconfigure forms in awkward ways.

Test Plan

Created a new paste without a comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix handling of implicit comment transaction in paste creation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 25 2015, 4:24 PM
This revision was automatically updated to reflect the committed changes.