Paths

Table of Contentst

Differential D14571

Fix handling of implicit comment transaction in paste creation
ClosedPublic
Actions

Authored by epriestley on Nov 25 2015, 4:24 PM.

Details

Reviewers

chad

Maniphest Tasks

T9850: Creating a new paste fails with unhandled exception

Commits

Restricted Diffusion Commit
rPb21928599960: Fix handling of implicit comment transaction in paste creation

Summary

Fixes T9850. The getComment() test should be a hasComment() test, in order to discard empty comments.

Also backport a couple of future fixes which can get you into trouble if you reconfigure forms in awkward ways.

Test Plan

Created a new paste without a comment.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35252.Nov 25 2015, 4:24 PM

epriestley retitled this revision from to Fix handling of implicit comment transaction in paste creation.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9850: Creating a new paste fails with unhandled exception.

chad accepted this revision.Nov 25 2015, 4:24 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 25 2015, 4:24 PM

Closed by commit rPb21928599960: Fix handling of implicit comment transaction in paste creation (authored by epriestley, committed by epriestley). · Explain WhyNov 25 2015, 4:25 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T9857: Column 'content' cannot be null.Nov 26 2015, 12:39 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editfield/

PhabricatorEditField.php

16 lines

editor/

PhabricatorApplicationTransactionEditor.php

2 lines

Diff 35253

View Options

src/applications/transactions/editfield/PhabricatorEditField.php