Page MenuHomePhabricator
Feed Advanced Search

Aug 3 2015

eadler added a project to T9041: Control access to administrator capabilities with custom policies: FreeBSD.
Aug 3 2015, 6:41 PM · FreeBSD, Policy, People
epriestley renamed T9041: Control access to administrator capabilities with custom policies from Administrator capabilities are not customizable to Control access to administrator capabilities with custom policies.
Aug 3 2015, 1:21 PM · FreeBSD, Policy, People
epriestley updated subscribers of T9041: Control access to administrator capabilities with custom policies.
Aug 3 2015, 1:20 PM · FreeBSD, Policy, People
epriestley merged task T9015: Allow user account enable/disable to be a delegatable to non admins into T9041: Control access to administrator capabilities with custom policies.
Aug 3 2015, 1:20 PM · People
epriestley renamed T9041: Control access to administrator capabilities with custom policies from "Create New Users" policy does not work to Administrator capabilities are not customizable.
Aug 3 2015, 1:20 PM · FreeBSD, Policy, People
epriestley added a comment to T9041: Control access to administrator capabilities with custom policies.

See some discussion in D13777.

Aug 3 2015, 1:17 PM · FreeBSD, Policy, People
chad added a revision to T9041: Control access to administrator capabilities with custom policies: D13777: Fix people being able to see /people/create/.
Aug 3 2015, 3:21 AM · FreeBSD, Policy, People
joshuaspence created T9041: Control access to administrator capabilities with custom policies.
Aug 3 2015, 2:52 AM · FreeBSD, Policy, People

Jul 30 2015

epriestley added a comment to T9015: Allow user account enable/disable to be a delegatable to non admins.

No, there's no overlap.

Jul 30 2015, 2:29 PM · People
chad added a comment to T9015: Allow user account enable/disable to be a delegatable to non admins.

Would "Role Profiles" solve this, ie, psuedo-admins?

Jul 30 2015, 2:25 PM · People
epriestley added a comment to T9015: Allow user account enable/disable to be a delegatable to non admins.

It sounds like we could possibly resolve this by letting you change application edit policies instead, which I intend to do eventually. That said, I don't think adding an enable/disable policy is necessarily unreasonable, and it's generally in the vein of other similar policies.

Jul 30 2015, 2:19 PM · People
joshuaspence added a comment to T9015: Allow user account enable/disable to be a delegatable to non admins.

A couple of things offhand:

Jul 30 2015, 1:10 PM · People
epriestley added a comment to T9015: Allow user account enable/disable to be a delegatable to non admins.

What specific administrator abilities are you concerned about them having?

Jul 30 2015, 12:19 PM · People
joshuaspence added a comment to T9015: Allow user account enable/disable to be a delegatable to non admins.

I'd rather not. We have a lot of staff who manage access and most of them I don't want poking around as an admin.

Jul 30 2015, 8:04 AM · People
epriestley added a comment to T9015: Allow user account enable/disable to be a delegatable to non admins.

Can you just give more users admin permissions?

Jul 30 2015, 5:50 AM · People
chad renamed T9015: Allow user account enable/disable to be a delegatable to non admins from "Can create users" policy doesn't allow re-enabling accounts to Allow user account enable/disable to be a delegatable to non admins.
Jul 30 2015, 5:24 AM · People
joshuaspence created T9015: Allow user account enable/disable to be a delegatable to non admins.
Jul 30 2015, 5:14 AM · People

Jul 29 2015

epriestley added a comment to T8999: Argument 1 passed to PHUIObjectBoxView::setInfoView() must be an instance of PHUIInfoView, null given.

(See D13739.)

Jul 29 2015, 1:24 AM · People
epriestley closed T8999: Argument 1 passed to PHUIObjectBoxView::setInfoView() must be an instance of PHUIInfoView, null given as Resolved.

Fixed in HEAD.

Jul 29 2015, 1:23 AM · People
joshuaspence created T8999: Argument 1 passed to PHUIObjectBoxView::setInfoView() must be an instance of PHUIInfoView, null given.
Jul 29 2015, 1:23 AM · People

Jul 27 2015

chad added a comment to T8976: InvalidArgumentException when attempting to edit profile when policy.allow-public is set to false.

You have been anointed "Bug Meister"

Jul 27 2015, 10:25 PM · People
cjoslin added a comment to T8976: InvalidArgumentException when attempting to edit profile when policy.allow-public is set to false.

Do we have a "helpful bug report" badge?

Jul 27 2015, 10:24 PM · People
epriestley added a comment to T8976: InvalidArgumentException when attempting to edit profile when policy.allow-public is set to false.

I cherry-picked this to stable and upgraded the cluster.

Jul 27 2015, 10:18 PM · People
epriestley added a comment to T8976: InvalidArgumentException when attempting to edit profile when policy.allow-public is set to false.

Do we have a "helpful bug report" badge?

Jul 27 2015, 10:15 PM · People
chad added a comment to T8976: InvalidArgumentException when attempting to edit profile when policy.allow-public is set to false.

33dcfda6c3439a1ab9fbcbaa4280edaf.jpg (360×600 px, 26 KB)

Jul 27 2015, 10:12 PM · People
chad closed T8976: InvalidArgumentException when attempting to edit profile when policy.allow-public is set to false as Resolved by committing rP84049e6d075b: Fix public/private profile edit note.
Jul 27 2015, 10:12 PM · People
chad added a revision to T8976: InvalidArgumentException when attempting to edit profile when policy.allow-public is set to false: D13739: Fix public/private profile edit note.
Jul 27 2015, 10:04 PM · People
cjoslin created T8976: InvalidArgumentException when attempting to edit profile when policy.allow-public is set to false.
Jul 27 2015, 9:49 PM · People
devurandom added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.
  • Another use case: in certain cases badges directly map to projects ("member of admin team" ~= "phacility high command" or "trusted contribute" ~= "trusted contributor" project)
Jul 27 2015, 1:24 PM · Restricted Project, Badges (v0), People

Jul 26 2015

chad updated subscribers of T6526: Implement "Badges" or "Medals", for annotating special users.
Jul 26 2015, 1:36 AM · Restricted Project, Badges (v0), People
chad moved T6526: Implement "Badges" or "Medals", for annotating special users from v0 to Backlog on the Badges board.
Jul 26 2015, 12:17 AM · Restricted Project, Badges (v0), People

Jul 25 2015

eadler added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

A few pieces of feedback:

  • It would be really nice to be able to split "being able to award this badge" and "being able to edit this badge". You've already said that this isn't something that you're likely to consider but I wanted to mention it here
  • Another use case: in certain cases badges directly map to projects ("member of admin team" ~= "phacility high command" or "trusted contribute" ~= "trusted contributor" project)
  • It would be nice to be able to "bind badges to external things": for example: we've already had requests for "submitted the most diffs" or "closed the most tasks"
  • There is no way to go from a user's pokemon center to the list of other users with the badge. Clicking on it just flips it over.
  • The mini-badges don't show up when posting inline comments only or when updating a diff: see this for example: https://www.dropbox.com/s/zu97klycfzb7jtf/Screenshot%202015-07-25%2013.13.36.png?dl=0
Jul 25 2015, 8:13 PM · Restricted Project, Badges (v0), People
chad merged T8961: use case: Split out award able and editable policies for badges into T6526: Implement "Badges" or "Medals", for annotating special users.
Jul 25 2015, 7:42 PM · Restricted Project, Badges (v0), People
epriestley closed T8960: Unhandled exception prevents viewing instance member list on Phacility as Resolved.

This was fixed in master, I just missed promoting it to stable since the release schedule has been out of whack recently. Should be fixed now.

Jul 25 2015, 6:13 PM · People, Phacility
eadler added projects to T8960: Unhandled exception prevents viewing instance member list on Phacility: Phacility, People.
Jul 25 2015, 5:06 PM · People, Phacility

Jul 22 2015

chad closed T4830: Applications with Public permissions requiring users to login as Resolved.
Jul 22 2015, 8:26 PM · Facts, Policy, People
chad updated the task description for T4830: Applications with Public permissions requiring users to login.
Jul 22 2015, 4:34 PM · Facts, Policy, People
chad added a revision to T4830: Applications with Public permissions requiring users to login: D13676: Allow public viewing of profiles and people calendars.
Jul 22 2015, 3:51 PM · Facts, Policy, People
epriestley added a comment to T4830: Applications with Public permissions requiring users to login.

Yeah, I'm mostly concerned about future changes (offhand: phone numbers, emails, messenger handles, oncall schedules, events/availability).

Jul 22 2015, 2:52 PM · Facts, Policy, People
chad added a comment to T4830: Applications with Public permissions requiring users to login.

If there is a reasonable path forward that @epriestley will approve, I can do the grunt work and close this out.

Jul 22 2015, 2:48 PM · Facts, Policy, People
chad added a comment to T4830: Applications with Public permissions requiring users to login.

Philosophically I'm fine making People "public". The main reason for me is that all the information on a Profile is already (in the most common cases) exposed in other "public" areas of the product (like hovercards). I do think though that when an install is public, we should have an additional reminder/note when someone goes to edit their profile as a reminder. With public profiles, I think we also need to be mindful of upcoming apps like oncall schedules, where some information might be actually private (and thus displayed in that individual app, like Calendar can) and not randomly exposed.

Jul 22 2015, 2:46 PM · Facts, Policy, People
chad added a revision to T4830: Applications with Public permissions requiring users to login: D13674: Allow XHPAST to be viewed public.
Jul 22 2015, 5:01 AM · Facts, Policy, People
chad added a revision to T4830: Applications with Public permissions requiring users to login: D13673: Allow XHProf to be publicly viewable.
Jul 22 2015, 4:51 AM · Facts, Policy, People

Jul 21 2015

epriestley triaged T8902: Add policy to mailing list users for settings as Wishlist priority.
Jul 21 2015, 11:26 AM · FreeBSD, Policy, People, Mailing Lists
eadler moved T8902: Add policy to mailing list users for settings from Backlog to Important on the FreeBSD board.
Jul 21 2015, 4:27 AM · FreeBSD, Policy, People, Mailing Lists
eadler added a project to T8902: Add policy to mailing list users for settings: FreeBSD.
Jul 21 2015, 4:27 AM · FreeBSD, Policy, People, Mailing Lists
eadler created T8902: Add policy to mailing list users for settings.
Jul 21 2015, 2:56 AM · FreeBSD, Policy, People, Mailing Lists

Jul 17 2015

chad closed T7992: Design "Badges" or "Medals" as Resolved.
Jul 17 2015, 1:10 AM · Badges, Design, People
chad closed T7992: Design "Badges" or "Medals", a subtask of T6526: Implement "Badges" or "Medals", for annotating special users, as Resolved.
Jul 17 2015, 1:10 AM · Restricted Project, Badges (v0), People

Jul 15 2015

maligree added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

Turns out I had a broken support/preamble.php script (or misconfigured nginx, depending how you look at it), which set $_SERVER['REMOTE_ADDR'] to an empty string.

Jul 15 2015, 2:47 PM · Contributor Onboarding, Setup
chad added a project to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR']: People.
Jul 15 2015, 2:27 PM · Contributor Onboarding, Setup

Jul 14 2015

chad moved T6526: Implement "Badges" or "Medals", for annotating special users from Backlog to v0 on the Badges board.
Jul 14 2015, 1:42 AM · Restricted Project, Badges (v0), People
chad moved T7992: Design "Badges" or "Medals" from Backlog to v0 on the Badges board.
Jul 14 2015, 1:42 AM · Badges, Design, People
chad added a project to T7992: Design "Badges" or "Medals": Badges.
Jul 14 2015, 1:41 AM · Badges, Design, People

Jul 13 2015

chad added a project to T6526: Implement "Badges" or "Medals", for annotating special users: Badges.
Jul 13 2015, 10:40 PM · Restricted Project, Badges (v0), People
chad added a revision to T6526: Implement "Badges" or "Medals", for annotating special users: D13626: Badges v0.1.
Jul 13 2015, 5:35 AM · Restricted Project, Badges (v0), People

Jul 11 2015

chad added revisions to T7992: Design "Badges" or "Medals": D13624: Add Badges to PHUIHeaderView, D13623: Add Badge support to Hovercards, D13620: PHUIBadgeMiniView.
Jul 11 2015, 8:56 PM · Badges, Design, People
chad added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

They don't let me program much, so it'll likely delete all your data.

Jul 11 2015, 8:55 PM · Restricted Project, Badges (v0), People
chad claimed T6526: Implement "Badges" or "Medals", for annotating special users.

I'll see if I can skeleton out an application here. I don't think it will do much.

Jul 11 2015, 8:54 PM · Restricted Project, Badges (v0), People

Jul 10 2015

cburroughs added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

I just realized the examples use the WoW rarity scheme ❤️

Jul 10 2015, 4:09 PM · Restricted Project, Badges (v0), People
johnny-bit added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

Hey @chad - badges look HUUUUUGE on what You propose... As for colour - sure pink is not perfect, but it would be even better to colour-code badges. For example:

Jul 10 2015, 2:59 PM · Restricted Project, Badges (v0), People
ftdysa added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

I don't need this but I want it!

Jul 10 2015, 2:14 PM · Restricted Project, Badges (v0), People
gabe added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.
In T6526#125777, @chad wrote:
Jul 10 2015, 2:52 AM · Restricted Project, Badges (v0), People
chad added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

You mean this: https://secure.phabricator.com/uiexample/view/PHUIBadgeExample/

Jul 10 2015, 2:51 AM · Restricted Project, Badges (v0), People
gabe added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

I always thought it would be cool to reward stuff like:

Jul 10 2015, 2:17 AM · Restricted Project, Badges (v0), People

Jul 9 2015

chad added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

pink maybe isn't a good choice. i'll tinker

Jul 9 2015, 10:48 PM · Restricted Project, Badges (v0), People
chad added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

http://www.wowhead.com/guides/vanity-collections/the-entitled-a-guide-to-titles was a lot of my inspiration, haha.

Jul 9 2015, 10:41 PM · Restricted Project, Badges (v0), People
chad added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

I'm fine trying both and seeing what shakes out in the long run (which may be both).

Jul 9 2015, 10:27 PM · Restricted Project, Badges (v0), People
epriestley added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

We could let specific "Important" badges generate a text tag like that but I'd like to be able to, e.g., award everyone who reports a bug a badge for it without turning every timeline into "Reported a Bug" on each comment.

Jul 9 2015, 10:26 PM · Restricted Project, Badges (v0), People
chad added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

I'd totally brag about my 1,000 commits. :)

Jul 9 2015, 10:26 PM · Restricted Project, Badges (v0), People
epriestley added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

Oh, yeah. That huge treatment might be good for "Administrator", "Employee" or object relationships ("Task Owner", "Task Author"), but feels pretty big for the more achivement-like "Made 100 Commits", "Registered for 5 years", "Contributed", things.

Jul 9 2015, 10:24 PM · Restricted Project, Badges (v0), People
epriestley added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

I was imagining something like this:

Jul 9 2015, 10:22 PM · Restricted Project, Badges (v0), People
chad added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

pasted_file (123×356 px, 20 KB)

Jul 9 2015, 10:22 PM · Restricted Project, Badges (v0), People
chad added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

I'm fine slathering hovercards with tons of them, but am worried that more than 1 or 2 would make timeline cluttered. Though maybe you have a magical design for this I'm not able to envision.

Jul 9 2015, 10:19 PM · Restricted Project, Badges (v0), People
epriestley added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

I don't want to do project/badge stuff yet, just an explicit "award this badge to this user" thing for now, but imagine maybe doing that in a future version.

Jul 9 2015, 10:16 PM · Restricted Project, Badges (v0), People
chad added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

My v0 or v-1 pass at this would be pretty basic (and I think like 98.5% aligned with @epriestley)

Jul 9 2015, 10:13 PM · Restricted Project, Badges (v0), People
chad added a revision to T7992: Design "Badges" or "Medals": D13615: PHUIBadgeView.
Jul 9 2015, 8:06 PM · Badges, Design, People

Jun 22 2015

chad added a comment to T8642: Error on User Administration > Activity Logs.

Thanks for the report!

Jun 22 2015, 9:13 PM · People
jhgg added a comment to T8642: Error on User Administration > Activity Logs.

Looks good ;) Thanks.

Jun 22 2015, 9:11 PM · People
chad closed T8642: Error on User Administration > Activity Logs as Resolved by committing rPdbdeca58fc6e: [Redesign] Fix People Log Query.
Jun 22 2015, 9:10 PM · People
chad added a revision to T8642: Error on User Administration > Activity Logs: D13395: [Redesign] Fix People Log Query.
Jun 22 2015, 9:08 PM · People
jhgg added a comment to T8642: Error on User Administration > Activity Logs.

Yeah we are on redesign-2015.

Jun 22 2015, 8:58 PM · People
chad added a comment to T8642: Error on User Administration > Activity Logs.

isn't that only in the redesign branch?

Jun 22 2015, 8:58 PM · People
jhgg added a project to T8642: Error on User Administration > Activity Logs: People.
Jun 22 2015, 8:44 PM · People

Jun 21 2015

epriestley added a parent task for T8629: Create some kind of queue of profile/settings action items for users: T8630: Prompt users when they login with an account that has changed email addresses.
Jun 21 2015, 11:15 AM · Restricted Project, People
epriestley added a parent task for T8629: Create some kind of queue of profile/settings action items for users: T4104: Implement "suggest profile edit" for recommending profile pictures, phone numbers, etc., to users.
Jun 21 2015, 11:13 AM · Restricted Project, People
epriestley created T8629: Create some kind of queue of profile/settings action items for users.
Jun 21 2015, 11:13 AM · Restricted Project, People

Jun 16 2015

epriestley added a comment to T6091: Support for Git's `.mailmap` author mapping.

@ostraaten, see T1731 for general mapping of VCS usernames. This is a much more attractive feature than supporting .mailmap, specifically, given the very limited use of .mailmap.

Jun 16 2015, 1:49 PM · Haskell.org, People
ostraaten added a comment to T6091: Support for Git's `.mailmap` author mapping.

Related to this issue, take a look at author mapping in Crucible https://confluence.atlassian.com/display/FISHEYE/Changing+your+user+profile#Changingyouruserprofile-AuthorMapping

Jun 16 2015, 5:33 AM · Haskell.org, People

Jun 12 2015

epriestley added a comment to T8398: Upgrading: Changes to Mailing Lists.

Awesome! Let us know if you run into anything.

Jun 12 2015, 6:31 PM · Installing & Upgrading, People, Mail, Guides
carlsverre added a comment to T8398: Upgrading: Changes to Mailing Lists.

Just upgraded the MemSQL installation and found no issues. Thanks @epriestley!

Jun 12 2015, 6:31 PM · Installing & Upgrading, People, Mail, Guides

Jun 10 2015

joshuaspence added a comment to T8454: User approval not working.

No, I'm not using auth.email-domains.

Jun 10 2015, 11:02 AM · People

Jun 8 2015

gabe added a comment to T8454: User approval not working.

Just out of curiosity are you using the "auth.email-domains" feature?

Jun 8 2015, 7:43 PM · People

Jun 7 2015

joshuaspence added a comment to T8454: User approval not working.

The approval queue is fixed, but it still doesn't log in the new user correctly:

Jun 7 2015, 11:02 AM · People

Jun 6 2015

epriestley added a comment to T8454: User approval not working.

On the second part, the condition for that query was wrong coming out of D13122: noDisabled changed to isDisabled, but the default value didn't get flipped.

Jun 6 2015, 1:41 PM · People
epriestley updated the task description for T8398: Upgrading: Changes to Mailing Lists.
Jun 6 2015, 1:35 PM · Installing & Upgrading, People, Mail, Guides
epriestley added a comment to T8398: Upgrading: Changes to Mailing Lists.

See T8455 for a discussion of some issues. There are fixes there awaiting review, but if you're a larger install and/or use a lot of mailing lists, you might want to wait for the dust to settle there.

Jun 6 2015, 1:34 PM · Installing & Upgrading, People, Mail, Guides

Jun 5 2015

joshuaspence created T8454: User approval not working.
Jun 5 2015, 11:28 PM · People

Jun 4 2015

eadler removed a project from T8398: Upgrading: Changes to Mailing Lists: FreeBSD.
Jun 4 2015, 10:01 PM · Installing & Upgrading, People, Mail, Guides
epriestley added a comment to T8398: Upgrading: Changes to Mailing Lists.

This migrated cleanly on this install, although we only had one real mailing list plus a handful of old invalid test lists (although these errored out correctly). If you run into problems with the migration or otherwise, let me know.

Jun 4 2015, 2:41 AM · Installing & Upgrading, People, Mail, Guides