Page MenuHomePhabricator
Differential D13674

Allow XHPAST to be viewed public
ClosedPublic
Actions

Authored by chad on Jul 22 2015, 5:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 6:05 AM
Unknown Object (File)
Mon, Dec 16, 2:12 AM
Unknown Object (File)
Thu, Dec 12, 6:11 PM
Unknown Object (File)
Thu, Dec 12, 3:27 AM
Unknown Object (File)
Wed, Dec 11, 2:32 PM
Unknown Object (File)
Sat, Dec 7, 11:14 AM
Unknown Object (File)
Fri, Dec 6, 5:51 PM
Unknown Object (File)
Fri, Dec 6, 10:10 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T4830: Applications with Public permissions requiring users to login
Commits
Restricted Diffusion Commit
rPb72b6eb18ff6: Allow XHPAST to be viewed public
Summary

Ref T4830. Not sure this should be public (consume resources?)

Test Plan

View logged out.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 33048.Jul 22 2015, 5:01 AM
chad retitled this revision from to Allow XHPAST to be viewed public.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T4830: Applications with Public permissions requiring users to login.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 22 2015, 5:01 AM
epriestley accepted this revision.Jul 22 2015, 2:04 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 22 2015, 2:04 PM
epriestley requested changes to this revision.Jul 22 2015, 2:05 PM
epriestley edited edge metadata.

Actually, I wouldn't let them use PhabricatorXHPASTViewRunController.php.

This revision now requires changes to proceed.Jul 22 2015, 2:05 PM
epriestley added a comment.Jul 22 2015, 2:07 PM

Basically, this app is super oldschool. Ideally we should:

  • Add Query + SearchEngine.
  • Have a standard list, make the list public, etc.
  • Proper "Create AST" button.

We'd keep "create AST" non-public, like other creation operations in other apps.

Just doing this change (without all that extra work, and without making RunController public) is fine, but it just means that sharing links to trees will work. The landing page for the app will still be nonfunctional for public users.

chad updated this revision to Diff 33057.Jul 22 2015, 3:29 PM
chad edited edge metadata.
  • remove from run controller
epriestley accepted this revision.Jul 22 2015, 8:22 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 22 2015, 8:22 PM
Closed by commit rPb72b6eb18ff6: Allow XHPAST to be viewed public (authored by chad, committed by chad). · Explain WhyJul 22 2015, 8:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33071

View Options

src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php

Loading...
View Options

src/applications/phpast/controller/PhabricatorXHPASTViewFramesetController.php

Loading...
View Options

src/applications/phpast/controller/PhabricatorXHPASTViewPanelController.php

Loading...
View Options

src/applications/phpast/controller/PhabricatorXHPASTViewTreeController.php

Loading...
Phabricator · Built by Phacility