Page MenuHomePhabricator
Differential D13676

Allow public viewing of profiles and people calendars
ClosedPublic
Actions

Authored by chad on Jul 22 2015, 3:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 12:39 AM
Unknown Object (File)
Mon, Apr 22, 8:25 AM
Unknown Object (File)
Mon, Apr 22, 8:25 AM
Unknown Object (File)
Mon, Apr 22, 8:25 AM
Unknown Object (File)
Mon, Apr 22, 8:25 AM
Unknown Object (File)
Mon, Apr 22, 8:25 AM
Unknown Object (File)
Wed, Apr 17, 12:48 AM
Unknown Object (File)
Tue, Apr 16, 4:42 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T4830: Applications with Public permissions requiring users to login
Commits
Restricted Diffusion Commit
rPcf83db15d6ba: Allow public viewing of profiles and people calendars
Summary

Ref T4830, this allows profile view and calendar profile view to be publicly visible. Also adds a note reminding the user of visibility.

Test Plan

Log out, visit a profile and various links.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 33058.Jul 22 2015, 3:51 PM
chad retitled this revision from to Allow public viewing of profiles and people calendars.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T4830: Applications with Public permissions requiring users to login.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 22 2015, 3:51 PM
epriestley accepted this revision.Jul 22 2015, 4:30 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/people/controller/PhabricatorPeopleProfileEditController.php
81–82

"Information ... is" reads better to me than "Information ... are", maybe.

This revision is now accepted and ready to land.Jul 22 2015, 4:30 PM
chad updated this revision to Diff 33059.Jul 22 2015, 4:32 PM
chad edited edge metadata.
  • is
Closed by commit rPcf83db15d6ba: Allow public viewing of profiles and people calendars (authored by chad, committed by chad). · Explain WhyJul 22 2015, 4:32 PM
This revision was automatically updated to reflect the committed changes.
chad marked an inline comment as done.Jul 22 2015, 4:33 PM

Revision Contents
Changeset List

Diff 33060

View Options

src/applications/people/controller/PhabricatorPeopleCalendarController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

Loading...
Phabricator · Built by Phacility