Page MenuHomePhabricator
Feed Advanced Search

Apr 2 2015

sshannin added a comment to T7734: consider hiding email commands from help menu if inbound email is disabled.

Yeah, but why send users to a page that's just going to tell them stuff is disabled?

Apr 2 2015, 1:34 PM · Setup, Mail
sshannin created T7734: consider hiding email commands from help menu if inbound email is disabled.
Apr 2 2015, 1:10 PM · Setup, Mail
sshannin added a comment to T7521: `arc land` should work even when the repo has untracked files.

I think a lot of the pain caused by D11995 (in SVN world at least) is just caused by bad wording. Consider:

Apr 2 2015, 2:50 AM · Restricted Project, Arcanist

Mar 30 2015

sshannin added a comment to T7703: Policy checks may execute incompletely for non-viewers.

To your question @chad (although it seems like the clarity is not needed anymore), it just flags any newly created diff.

Mar 30 2015, 11:27 PM · Policy, Herald, Flags
sshannin added a comment to T7703: Policy checks may execute incompletely for non-viewers.

26.0 build for linux mint (aka mint build 1.0)

Mar 30 2015, 9:53 PM · Policy, Herald, Flags
sshannin added a comment to T7703: Policy checks may execute incompletely for non-viewers.

Also, note that floating text in the search box, hehe

Mar 30 2015, 9:53 PM · Policy, Herald, Flags
sshannin created T7703: Policy checks may execute incompletely for non-viewers.
Mar 30 2015, 9:52 PM · Policy, Herald, Flags
sshannin added a comment to T7200: More than 10 options in polls.

FWIW for new subscriber, the field count is currently set at /diffusion/P/browse/master/src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php;a0bf9a290a6b3f91d65d95f4101722662a17dede$178 and I have bumped it locally in my install as needed.

Mar 30 2015, 3:00 PM · Restricted Project, Slowvote

Mar 27 2015

sshannin added a comment to T7648: Better support for migrating to new host.

Sounds reasonable, thanks.

Mar 27 2015, 2:37 PM · Documentation
sshannin added a comment to T7648: Better support for migrating to new host.

What if the command-line tools just wrote them to the db instead of the local config file? They could still be uneditable in web UI to address admin compromise concerns. Might not be worth the effort though.

Mar 27 2015, 2:25 PM · Documentation
sshannin added a comment to T7648: Better support for migrating to new host.

I'd not seen that, no. I knew there had to a config file, but I just kinda assumed it was really only for database credentials (and that everything else was in the db).

Mar 27 2015, 2:19 PM · Documentation

Mar 26 2015

sshannin added a comment to T7598: Expected a numeric scalar or null for %Ld conversion.

FWIW, it looks like arc export hits this when invoked with --diff-id DXXX instead of --diff-id XXX

Mar 26 2015, 1:38 PM · Conduit

Mar 24 2015

sshannin added a comment to T7648: Better support for migrating to new host.

Could be. I guess the main thing is that it wasn't obvious. I was thinking to myself that all I had to do was clone libphutil, arcanist, and phabricator, repoint and bounce apache and then I'd be done.

Mar 24 2015, 1:09 PM · Documentation
sshannin added a comment to T7605: How to make projects secure?.

You can just put the names in the URL, just field_name=value pairs. For example, here's a simplified template we use for tasks to apply changes to the production DB:

Mar 24 2015, 1:03 PM · Projects, Maniphest

Mar 23 2015

sshannin created T7648: Better support for migrating to new host.
Mar 23 2015, 3:10 PM · Documentation

Mar 17 2015

sshannin retitled D12101: Make pink flags pink from to Make pink flags pink.
Mar 17 2015, 9:01 PM
sshannin created T7608: arcanist - allow untracked files.
Mar 17 2015, 6:30 PM · Subversion, Arcanist
sshannin added a comment to T7605: How to make projects secure?.

The way my install handles this is by composing task creation URL's which set a lot of the fields. Then we throw this onto a panel in the default dashboard.

Mar 17 2015, 2:06 PM · Projects, Maniphest

Mar 16 2015

sshannin created T7581: arc diff errors out when a directory is removed between diffs.
Mar 16 2015, 8:45 PM · Subversion, Arcanist
sshannin created T7576: Persistent column creates CSRF errors.
Mar 16 2015, 7:28 PM · Conpherence

Mar 13 2015

sshannin edited P1738 repository reparse trace.
Mar 13 2015, 1:52 PM

Mar 11 2015

sshannin added a comment to T7530: Creating a task from Quick Create menu leads to 'undefined' page.

Seems similar to T7514

Mar 11 2015, 7:22 PM · Quicksand, Maniphest

Mar 10 2015

sshannin added a comment to T7158: arc commit for subversion fails with untracked files where a directory has a property change.

Especially with the new requirement for a minimum svn version of 1.5, would there be any opposition to removing this check? I'm happy to make a diff for it.

Mar 10 2015, 3:20 AM · Subversion, Arcanist
sshannin added a comment to T7158: arc commit for subversion fails with untracked files where a directory has a property change.
Mar 10 2015, 3:19 AM · Subversion, Arcanist

Mar 8 2015

sshannin added a comment to T7514: undefined error when selecting a chat from conpherence dropdown while persistent column open.

Need a bugasaurus-rex token...

Mar 8 2015, 11:39 PM · Conpherence
sshannin awarded T7514: undefined error when selecting a chat from conpherence dropdown while persistent column open a Pterodactyl token.
Mar 8 2015, 11:36 PM · Conpherence
sshannin added a comment to T7514: undefined error when selecting a chat from conpherence dropdown while persistent column open.

FWIW, it happened in the task creation workflow as well when I hit submit on this task.

Mar 8 2015, 11:27 PM · Conpherence
sshannin created T7514: undefined error when selecting a chat from conpherence dropdown while persistent column open.
Mar 8 2015, 11:26 PM · Conpherence

Mar 6 2015

MarcLindenberg awarded T7469: Handle folder copies/moves more gracefully a Like token.
Mar 6 2015, 3:19 PM · Diffusion, Subversion

Mar 5 2015

sshannin updated the task description for T7469: Handle folder copies/moves more gracefully.
Mar 5 2015, 11:08 PM · Diffusion, Subversion
sshannin created T7469: Handle folder copies/moves more gracefully.
Mar 5 2015, 11:08 PM · Diffusion, Subversion

Mar 4 2015

sshannin added a comment to T1084: Preview what's new in a diff when attaching it to an existing revision .

FWIW, been using the following script to do these previews for an svn repo

1#!/bin/bash
2
3set -e
4
5usage ()
6{
7 echo "Usage: arc_preview [ -d Diff ID ]"
8 echo ""
9 echo "Will detect your local arc Diff ID and your local svn repo"
10 echo "to provide a diff of what has changed. This semantically"
11 echo "should tell you what has changed since your last 'arc diff'."
12 echo "If -d is provided, it will be used as the Diff ID rather than"
13 echo "detecting and using your most recent diff."
14 exit 1
15}
16
17diff=""
18while getopts ":d:" opt; do
19 case "$opt" in
20 d) diff=$OPTARG
21 ;;
22 *)
23 usage
24 ;;
25 esac
26done
27
28if [ -z "$diff" ];
29then
30 diff=`arc which | grep -o "D[1-9][0-9]*"`
31fi
32base_checkout=`svn info | grep ^URL | cut -d" " -f2`
33
34if [ -z "$diff" ];
35then
36 echo "Unable to find diff for working directory"
37 exit
38fi
39
40if [ -z "$base_checkout" ];
41then
42 echo "Unable to find svninfo for working directory"
43 exit
44fi
45
46echo "Diff is $diff"
47echo "Base Revision is $base_checkout"
48
49curr_dir=`pwd`
50
51## start with a fresh tmp dir
52tmp_dir=`mktemp -d`
53
54function cleanup {
55 rm -rf $tmp_dir
56}
57
58trap 'cleanup' EXIT
59
60## checkout the base revision and apply the patch
61svn co $base_checkout $tmp_dir --quiet
62cd $tmp_dir
63
64## patch it up and hide some noise
65arc patch --force ${diff} | grep -v "^patching file" |
66 grep -v "^[A|U|D] "
67
68cd $curr_dir
69
70## perform our diff
71diff -ru $tmp_dir $curr_dir --exclude=".svn"

Mar 4 2015, 6:35 PM · Restricted Project, Differential, Arcanist
sshannin edited P1732 arc_preview.
Mar 4 2015, 6:33 PM · Arcanist

Mar 2 2015

sshannin added a comment to T7186: Improve behavior when users drag-and-drop upload something that isn't a file.

Oh dang, that's gross.

Mar 2 2015, 3:39 PM · PHUI

Feb 27 2015

sshannin created T7394: ui.custom_header requires phid, but no way to get it from file.
Feb 27 2015, 12:40 AM · Files
sshannin created T7393: ui.custom_header setting isn't in User Interface Config group.
Feb 27 2015, 12:27 AM

Feb 26 2015

sshannin added a comment to T4806: Give installs more control over session expiry / prompt for reauth before taking security actions.

Of course; any properly rotated token should form a loop.

Feb 26 2015, 9:48 PM · Restricted Project, Auth
sshannin added a comment to T7384: Remove "if sent two graceful shutdowns, terminate" logic from PhutilDaemonOverseer.

You could use ^\ / SIGQUIT to force the non-graceful exit when the daemon's in the foreground and keep ^C as graceful only.

Feb 26 2015, 3:17 PM · Daemons

Feb 25 2015

sshannin created T7377: Project reviewer not getting diff notification .
Feb 25 2015, 5:51 PM · Notifications, Differential

Feb 20 2015

sshannin awarded D11838: Tweak alert states in header a bit more a Haypence token.
Feb 20 2015, 8:56 PM
sshannin added a comment to T7336: Daemon skipping commit.

Understood. I have the daemon logs and db dumps if you think they would be helpful.

Feb 20 2015, 1:40 AM · Daemons
sshannin added a comment to T7336: Daemon skipping commit.

Yeah, that's the main aspect of it.

Feb 20 2015, 1:26 AM · Daemons
sshannin added a comment to T7336: Daemon skipping commit.

Sorry, there was a lot of background/setup story there.

Feb 20 2015, 1:15 AM · Daemons
sshannin added a comment to T7336: Daemon skipping commit.

Looking at the daemon logs, it looks like there were various mysql failures throughout the day (too many cnxns), but it seems like it was able to recover from those.

Feb 20 2015, 12:52 AM · Daemons
sshannin created T7336: Daemon skipping commit.
Feb 20 2015, 12:49 AM · Daemons
sshannin added a comment to T7335: help from search doesn't work.

N.B. I couldn't decide what project to throw this into, sorry

Feb 20 2015, 12:01 AM

Feb 19 2015

sshannin created T7335: help from search doesn't work.
Feb 19 2015, 11:59 PM
sshannin added a comment to T7298: Don't clog feed with old commits when importing a repo.

Agreed on lack of value.

Feb 19 2015, 5:30 PM · Phacility, Diffusion
sshannin created T7327: Adding projects via arc diff.
Feb 19 2015, 3:27 PM · Arcanist, Differential

Feb 18 2015

sshannin added a comment to T7298: Don't clog feed with old commits when importing a repo.

I still think that timestamping the feed events in the phab DB based on the timestamp of the commits in the repo is ideal here (although I don't know if it's feasible).

Feb 18 2015, 7:45 PM · Phacility, Diffusion

Feb 17 2015

sshannin updated the task description for T7298: Don't clog feed with old commits when importing a repo.
Feb 17 2015, 8:07 PM · Phacility, Diffusion
sshannin created T7298: Don't clog feed with old commits when importing a repo.
Feb 17 2015, 8:06 PM · Phacility, Diffusion
sshannin added a comment to T7284: Creating a project gives it the empty hashtag.

A note here that didn't get carried over from T7297, it looks like this might happen because the project gets created with an empty name and then undergoes a rename.

project_hash.png (600×1 px, 43 KB)

Feb 17 2015, 4:58 PM · Projects
sshannin added a comment to T7297: Creating project from maniphest gives it empty hashtag.

I even saw that task too, but the space was a distraction I guess. sorry ><

Feb 17 2015, 4:54 PM · Projects, Maniphest
sshannin created T7297: Creating project from maniphest gives it empty hashtag.
Feb 17 2015, 4:37 PM · Projects, Maniphest

Feb 6 2015

sshannin created T7200: More than 10 options in polls.
Feb 6 2015, 10:08 PM · Restricted Project, Slowvote

Feb 5 2015

sshannin added a comment to T7186: Improve behavior when users drag-and-drop upload something that isn't a file.

Oh, that too huh ><

Feb 5 2015, 11:02 PM · PHUI
sshannin created T7186: Improve behavior when users drag-and-drop upload something that isn't a file.
Feb 5 2015, 10:57 PM · PHUI

Feb 4 2015

sshannin added a comment to T7158: arc commit for subversion fails with untracked files where a directory has a property change.

Maybe this used to be a problem with older versions of svn?

Feb 4 2015, 9:16 PM · Subversion, Arcanist
sshannin added a comment to T7158: arc commit for subversion fails with untracked files where a directory has a property change.
seth@luca:~/update/p2$ svn ci
Sending        .
Sending        app.cpp
Sending        jit.cpp
Adding         test/reject_bad_insn.py
Sending        test/signal_bnds_flow.py
Transmitting file data ..........
Committed revision 27959.
seth@luca:~/update/p2$ svn st
?       test/prof_burn.py
seth@luca:~/update/p2$
Feb 4 2015, 6:33 PM · Subversion, Arcanist
sshannin added a comment to T7158: arc commit for subversion fails with untracked files where a directory has a property change.

Also, note that arc commit is perfectly fine with the untracked files when there are no changes on the directory itself (i.e. if I hadn't edited the svn props on .)

Feb 4 2015, 6:18 PM · Subversion, Arcanist
sshannin added a comment to T7158: arc commit for subversion fails with untracked files where a directory has a property change.

I am not familiar with any such restriction being imposed by subversion.

Feb 4 2015, 6:17 PM · Subversion, Arcanist
sshannin created T7158: arc commit for subversion fails with untracked files where a directory has a property change.
Feb 4 2015, 3:37 PM · Subversion, Arcanist

Jan 27 2015

sshannin created T7056: arc which svn error.
Jan 27 2015, 3:56 PM · Arcanist, Subversion

Jan 23 2015

sshannin created T7022: diffusion - doesn't understand svn Replace operation.
Jan 23 2015, 6:29 PM · Bug Report, Diffusion, Subversion

Jan 21 2015

sshannin added a comment to T7002: Can't diff between multiple commits in Diffusion.

I don't want to create an audit. Just browse.

Jan 21 2015, 6:51 PM · Diffusion
sshannin created T7002: Can't diff between multiple commits in Diffusion.
Jan 21 2015, 5:22 PM · Diffusion
sshannin added a comment to T6997: Show prefix or project for commits in feeds.

Yeah, understood, certainly wasn't suggesting that this be a priority.

Jan 21 2015, 3:58 PM · Diffusion, Audit, Differential, Subversion
sshannin added a comment to T6997: Show prefix or project for commits in feeds.

Problem: items don't always show enough context to make sense of them from feeds. Example in screenshot.

Jan 21 2015, 3:27 PM · Diffusion, Audit, Differential, Subversion
sshannin added a comment to T6997: Show prefix or project for commits in feeds.

The issue I'm having is exemplified in the attached screenshot.

Jan 21 2015, 3:11 PM · Diffusion, Audit, Differential, Subversion
sshannin added a comment to T6997: Show prefix or project for commits in feeds.

Hmmm, based on what you merged this with, I don't think you quite understood what I was saying.

Jan 21 2015, 2:18 PM · Diffusion, Audit, Differential, Subversion

Jan 20 2015

sshannin added a comment to T6733: Audit multiple commits.

FWIW, I've been using this for what I wanted. Good for creating diffs for whole branches or between tags. Dunno if anybody else would find value in this.

Jan 20 2015, 10:42 PM · Audit
sshannin created T6997: Show prefix or project for commits in feeds.
Jan 20 2015, 10:29 PM · Diffusion, Audit, Differential, Subversion

Dec 16 2014

sshannin created T6763: Allow herald rules to filter on branch/tag creation in Subversion.
Dec 16 2014, 5:26 PM · Subversion, Herald

Dec 12 2014

sshannin created T6743: Loosen arcanist requirements for matching SVN diffs.
Dec 12 2014, 9:27 PM · Arcanist, Subversion
sshannin edited P1686 arc diff problems with svn.
Dec 12 2014, 9:09 PM · Arcanist

Dec 11 2014

sshannin added a comment to T6733: Audit multiple commits.

Gotcha. That seems like a reasonable way to do it.

Dec 11 2014, 4:44 PM · Audit
sshannin created T6733: Audit multiple commits.
Dec 11 2014, 2:29 PM · Audit

Dec 10 2014

sshannin added a comment to T6725: Reassign audit.

Thanks!

Dec 10 2014, 8:48 PM · Audit
sshannin added a comment to T6725: Reassign audit.

Don't know whether to default to triage and let somebody else assign or mark as wishlist (which I think it is).

Dec 10 2014, 5:52 PM · Audit
sshannin raised the priority of T6725: Reassign audit from Wishlist to Needs Triage.
Dec 10 2014, 5:51 PM · Audit
sshannin created T6725: Reassign audit.
Dec 10 2014, 5:28 PM · Audit