Page MenuHomePhabricator

Audit multiple commits
Closed, DuplicatePublic

Description

For audits, it's nice to be able to group multiple commits together and audit them as a whole. The main example to motivate this is reviewing an entire branch before merging it.

Maybe this already exists and I'm having trouble finding it? If not, this is definitely just a wishlist/feature request.

Event Timeline

sshannin raised the priority of this task from to Needs Triage.
sshannin updated the task description. (Show Details)
sshannin added a project: Audit.
sshannin added a subscriber: sshannin.

Can you send the branch merge to Differential for pre-commit review?

Also, check out https://secure.phabricator.com/book/phabcontrib/article/feature_requests/. In general we prefer feature requests to spell out problems, not solutions.

Gotcha. That seems like a reasonable way to do it.

I read that page. I guess my problem was "I don't know how to review multiple commits at once".

Sorry for the duplicate.

T5722 I think covers bunching random audits together, but if you just need a single merge, I think that's reviewable in and of itself. You can also just review each commit to the branch in Differential before the merge as well (we recommend this of course).

FWIW, I've been using this for what I wanted. Good for creating diffs for whole branches or between tags. Dunno if anybody else would find value in this.

#!/bin/sh

# diff two svn paths and submit them to differential

# example:
#   arfdiff svn://fr-svn/frcrepo1/pup/trunk@27253 svn://fr-svn/frcrepo1/pup/trunk@HEAD --create
# all subsequent arguments are passed through to arc. (e.g. --create or --update)

if [ "$#" -lt 2 ]
then
    echo "Need two args: both svn paths"
    return 1
fi

before=$1
after=$2
shift 2

# -x passes the next thing though to diff. -u specifies how much context we want - all of it
arc diff $* --raw-command "svn diff \"$before\" \"$after\" --diff-cmd=diff -x -u1000000"