Page MenuHomePhabricator

Add untracked files to commit using prompt
ClosedPublic

Authored by nevogd on Mar 6 2015, 8:17 AM.

Details

Summary

Refs D11990. When using arc diff with untracked files in the working
copy, add the untracked file(s) to the commit (as they weren't stashed or
ignored). Add the untracked paths to the list of changes in the editor
template, indicating that the files were added to the commit.

This doesn't add a separate prompt to add untracked files as per the
behaviour prior to D11843.

Test Plan

Ran arc diff with only untracked files, answered yes to the 'create
new commit' prompt. Saw the commit-message with the updated changes
including untracked files. Completed the arc template, and got commit
containing uncommitted, unstaged and untracked files.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nevogd retitled this revision from to Add untracked files to commit using prompt.
nevogd updated this object.
nevogd edited the test plan for this revision. (Show Details)
nevogd added a reviewer: epriestley.

This looks good, but you need to sign the CLA before I can merge it (see link in header).

epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 12:40 PM
This revision was automatically updated to reflect the committed changes.

In the past, diff workflows allowed us to skip adding untracked files to the revision and continue with the workflow.

Is the expected behavior here that if you say No to adding the untracked files to the commit, that the workflow should abort? If so, don't we lose that previous functionality?