Page MenuHomePhabricator

Loosen arcanist requirements for matching SVN diffs
Closed, InvalidPublic

Description

Arcanist requires project names to match when matching revisions. If no project name is present, it will fail to match revisions.

It could be more lenient (or at least be willing to match revisions which both lack a project name). It also might be nice to indicate this in the documentation or to have arc complain if it is not set.

Related Objects

Event Timeline

sshannin created this task.Dec 12 2014, 9:27 PM
sshannin raised the priority of this task from to Needs Triage.
sshannin updated the task description. (Show Details)
sshannin added a subscriber: sshannin.
chad triaged this task as Wishlist priority.Dec 12 2014, 9:59 PM
chad added projects: Subversion, Arcanist.

1seth@luca:~/update/build$ arc which --trace
2libphutil loaded from '/home/seth/local/src/arcanist/libphutil/src'.
3arcanist loaded from '/home/seth/local/src/arcanist/arcanist/src'.
4Config: Reading user configuration file "/home/seth/.arcrc"...
5Config: Did not find system configuration at "/etc/arcconfig".
6Working Copy: Reading .arcconfig from "/home/seth/update/build/.arcconfig".
7Working Copy: Path "/home/seth/update/build" is part of `svn` working copy "/home/seth/update/build".
8Working Copy: Project root is at "/home/seth/update/build".
9Config: Did not find local configuration at "/home/seth/update/build/.svn/arc/config".
10>>> [0] <conduit> conduit.connect() <bytes = 467>
11>>> [1] <http> http://phab.spira:8001/api/conduit.connect
12<<< [1] <http> 63,213 us
13<<< [0] <conduit> 63,617 us
14REPOSITORY
15>>> [2] <conduit> repository.query() <bytes = 190>
16>>> [3] <http> http://phab.spira:8001/api/repository.query
17<<< [3] <http> 36,183 us
18<<< [2] <conduit> 36,339 us
19To identify the repository associated with this working copy, arc followed this process:
20
21 Configuration value "repository.callsign" is set to "M".
22
23 Found a unique matching repository.
24
25This working copy is associated with the M repository.
26
27MATCHING REVISIONS
28These Differential revisions match the changes in this working copy:
29
30 (No revisions match.)
31
32Since there are no revisions in Differential which match this working copy, a
33new revision will be created if you run 'arc diff'.
34
35seth@luca:~/update/build$ echo 'hello' >> makefile.common
36seth@luca:~/update/build$ arc diff
37Linting...
38No lint engine configured for this project.
39Running unit tests...
40No unit test engine is configured for this project.
41Created a new Differential revision:
42 Revision URI: http://phab.spira:8001/D7
43
44Included changes:
45 M makefile.common
46seth@luca:~/update/build$ arc which --trace
47libphutil loaded from '/home/seth/local/src/arcanist/libphutil/src'.
48arcanist loaded from '/home/seth/local/src/arcanist/arcanist/src'.
49Config: Reading user configuration file "/home/seth/.arcrc"...
50Config: Did not find system configuration at "/etc/arcconfig".
51Working Copy: Reading .arcconfig from "/home/seth/update/build/.arcconfig".
52Working Copy: Path "/home/seth/update/build" is part of `svn` working copy "/home/seth/update/build".
53Working Copy: Project root is at "/home/seth/update/build".
54Config: Did not find local configuration at "/home/seth/update/build/.svn/arc/config".
55>>> [0] <conduit> conduit.connect() <bytes = 467>
56>>> [1] <http> http://phab.spira:8001/api/conduit.connect
57<<< [1] <http> 88,854 us
58<<< [0] <conduit> 89,045 us
59REPOSITORY
60>>> [2] <conduit> repository.query() <bytes = 190>
61>>> [3] <http> http://phab.spira:8001/api/repository.query
62<<< [3] <http> 64,252 us
63<<< [2] <conduit> 64,404 us
64To identify the repository associated with this working copy, arc followed this process:
65
66 Configuration value "repository.callsign" is set to "M".
67
68 Found a unique matching repository.
69
70This working copy is associated with the M repository.
71
72MATCHING REVISIONS
73These Differential revisions match the changes in this working copy:
74
75 (No revisions match.)
76
77Since there are no revisions in Differential which match this working copy, a
78new revision will be created if you run 'arc diff'.
79seth@luca:~/update/build$ svn info .
80Path: .
81URL: svn://svn.spira/mainrepo/build/trunk
82Repository Root: svn://svn.spira/mainrepo
83Repository UUID: 5b050b1a-ec2b-4496-a8ad-8719d879b7e6
84Revision: 27456
85Node Kind: directory
86Schedule: normal
87Last Changed Author: seth
88Last Changed Rev: 152
89Last Changed Date: 2014-12-12 15:39:17 -0500 (Fri, 12 Dec 2014)

sshannin closed this task as Invalid.Aug 18 2015, 7:23 PM
sshannin claimed this task.

I'm gonna say this is moot now that arcanist project aren't a thing anymore.