Page MenuHomePhabricator
Feed Advanced Search

Dec 11 2014

chad added a comment to T6717: Improving the usability of Maniphest's advanced search.

Is T4475 the correct fix then? I do agree these forms are awful, which is why I'd prefer people not end up there.

Dec 11 2014, 1:11 AM · Search

Dec 10 2014

qgil added a comment to T6717: Improving the usability of Maniphest's advanced search.

Regular search doesn't provide good enough results / ranking. Maniphests' neither, but at least you can define more accurate parameters to restrict the amount of results. This is why users really needing to find a specific task end up using Maniphest's advanced search pretty quickly.

Dec 10 2014, 11:02 PM · Search
qgil renamed T6717: Improving the usability of Maniphest's advanced search from Improving the usability of of Maniphest's advanced search to Improving the usability of Maniphest's advanced search.
Dec 10 2014, 10:59 PM · Search
chad added a comment to T6717: Improving the usability of Maniphest's advanced search.

Can you provide an example here? The application level search is primarily intended to build search queries that get saved for later re-use. For searching in general, I'd expect the regular advanced search to be used.

Dec 10 2014, 10:53 PM · Search
chad added a comment to T6700: Opening new tabs from search dropdown results.

We should make middle clicks work as expected though, regardless.

Dec 10 2014, 9:41 PM · PHUI, Search
chad added a comment to T6700: Opening new tabs from search dropdown results.

We already have planned several UI improvements to Typeaheads, see T1906 and T6579.

Dec 10 2014, 9:40 PM · PHUI, Search
tgr added a comment to T6700: Opening new tabs from search dropdown results.

A more specific use case: when I am adding a new task and am unsure whether it fits into a certain project, typing that project name in the search box and middle-clicking would be a convenient way of checking that project's description.

Dec 10 2014, 9:29 PM · PHUI, Search
qgil added a project to T6721: Would like ability to search tasks by title: Search.
Dec 10 2014, 12:56 PM · Search, Maniphest

Dec 9 2014

chad triaged T6700: Opening new tabs from search dropdown results as Low priority.
Dec 9 2014, 3:20 PM · PHUI, Search
qgil updated the task description for T6717: Improving the usability of Maniphest's advanced search.
Dec 9 2014, 2:46 PM · Search
qgil created T6717: Improving the usability of Maniphest's advanced search.
Dec 9 2014, 2:45 PM · Search
tgr added a comment to T6700: Opening new tabs from search dropdown results.

Project names, user names. Admittedly it's not something I would use often, but it did annoy me a few times.

Dec 9 2014, 11:15 AM · PHUI, Search
chad added a comment to T6700: Opening new tabs from search dropdown results.

I understand the point, but I personally can't think of what data in the main search typeahead someone would want to do that with. Projects names?

Dec 9 2014, 12:07 AM · PHUI, Search

Dec 8 2014

epriestley closed T6664: Clicking the search icon in empty search field should link to advanced search as Resolved.

Closed by commit rP4506018339a0.

Dec 8 2014, 7:27 PM · Search
lpriestley added a revision to T6664: Clicking the search icon in empty search field should link to advanced search: Restricted Differential Revision.
Dec 8 2014, 7:25 PM · Search

Dec 5 2014

qgil updated subscribers of T6700: Opening new tabs from search dropdown results.
Dec 5 2014, 1:20 PM · PHUI, Search
qgil updated the task description for T6700: Opening new tabs from search dropdown results.
Dec 5 2014, 1:06 PM · PHUI, Search
qgil created T6700: Opening new tabs from search dropdown results.
Dec 5 2014, 1:06 PM · PHUI, Search

Dec 4 2014

qgil removed a project from T5991: `bin/search index` returns 0 on failure: Wikimedia.
Dec 4 2014, 12:38 PM · Search
qgil removed a project from T5990: Elasticsearch search backend requires auto_create_index turned on: Wikimedia.
Dec 4 2014, 12:37 PM · Elasticsearch, Search
qgil moved T6552: Implement partial / wildcard searching (Elasticsearch) from Backlog to Important on the Wikimedia board.
Dec 4 2014, 12:28 PM · Elasticsearch, Search
qgil added a project to T6552: Implement partial / wildcard searching (Elasticsearch): Wikimedia.
Dec 4 2014, 12:27 PM · Elasticsearch, Search
fabe added a comment to T6552: Implement partial / wildcard searching (Elasticsearch).

One way of doing this is by adjusting the mapping for the elasticsearch index (actually way more powerful than a wildcard search).
I currently switched to the mapping below (added as a template expecting the index to be named 'phabricator' and with an english language setting).
Feel free to change the min/max ngrams setting (e.g. 4 instead of 3 letter ngrams) if you get too many / few results.
If you like to switch to another language the docs to do so are here: http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/analysis-lang-analyzer.html
For it to take effect you have to delete the index and then reindex all objects (bin/index --all).

Dec 4 2014, 12:17 PM · Elasticsearch, Search

Dec 1 2014

epriestley triaged T6664: Clicking the search icon in empty search field should link to advanced search as Low priority.
Dec 1 2014, 9:20 PM · Search
epriestley assigned T6664: Clicking the search icon in empty search field should link to advanced search to lpriestley.

I think the simplest fix is:

Dec 1 2014, 9:20 PM · Search
chad renamed T6664: Clicking the search icon in empty search field should link to advanced search from Clicking fa-search icon in empty search field at the header should link to the general advanced search to Clicking the search icon in empty search field should link to advanced search.
Dec 1 2014, 2:36 AM · Search

Nov 30 2014

qgil updated the task description for T6664: Clicking the search icon in empty search field should link to advanced search.
Nov 30 2014, 9:51 PM · Search
qgil created T6664: Clicking the search icon in empty search field should link to advanced search.
Nov 30 2014, 9:50 PM · Search

Nov 26 2014

jdforrester added a comment to T6639: Be able to search for tasks as assigned to members of a project/team.

Thank you!

Nov 26 2014, 2:50 AM · Search, Maniphest

Nov 25 2014

chad triaged T6638: Be able to find tasks by "is a blocker to task Y" or "is blocked by task Y" in the search interface as Wishlist priority.
Nov 25 2014, 7:41 PM · Restricted Project, Maniphest, Search
chad added a comment to T6639: Be able to search for tasks as assigned to members of a project/team.

T4100 and T5733 cover different ways to approach this feature.

Nov 25 2014, 7:38 PM · Search, Maniphest
chad merged task T6639: Be able to search for tasks as assigned to members of a project/team into T5733: Add option for "show only assigned" tasks in search.
Nov 25 2014, 7:35 PM · Search, Maniphest
jdforrester created T6639: Be able to search for tasks as assigned to members of a project/team.
Nov 25 2014, 6:42 PM · Search, Maniphest
jdforrester created T6638: Be able to find tasks by "is a blocker to task Y" or "is blocked by task Y" in the search interface.
Nov 25 2014, 6:39 PM · Restricted Project, Maniphest, Search

Nov 20 2014

chad added a comment to T6604: Error while trying search existing target.phid.

I understood your report.

Nov 20 2014, 7:21 PM · Search
sicnervo added a comment to T6604: Error while trying search existing target.phid.

This is not support request.
Same problem appears at yours: https://secure.phabricator.com/
Take target.phid

Nov 20 2014, 7:17 PM · Search
chad closed T6604: Error while trying search existing target.phid as Invalid.

Ah, we don't take bug reports or provide support for Prototype applications. See https://secure.phabricator.com/book/phabricator/article/prototypes/ for more information

Nov 20 2014, 5:09 PM · Search
sicnervo added a comment to T6604: Error while trying search existing target.phid.

You have to use target.phid string from Harbormaster

Nov 20 2014, 3:36 PM · Search
chad added a comment to T6604: Error while trying search existing target.phid.

I can't reproduce this on my local install, just this install.

Nov 20 2014, 3:17 PM · Search
chad updated the task description for T6604: Error while trying search existing target.phid.
Nov 20 2014, 2:57 PM · Search
chad updated the task description for T6604: Error while trying search existing target.phid.
Nov 20 2014, 2:57 PM · Search

Nov 15 2014

chad added a comment to T6552: Implement partial / wildcard searching (Elasticsearch).

(I would like this tooooo)

Nov 15 2014, 5:51 AM · Elasticsearch, Search
chad triaged T6552: Implement partial / wildcard searching (Elasticsearch) as Normal priority.
Nov 15 2014, 5:50 AM · Elasticsearch, Search

Nov 14 2014

chad added a project to T6552: Implement partial / wildcard searching (Elasticsearch): Elasticsearch.
Nov 14 2014, 4:36 PM · Elasticsearch, Search
qgil updated subscribers of T6552: Implement partial / wildcard searching (Elasticsearch).

Same problem in our instance, and we also have Elasticsearch. See https://phabricator.wikimedia.org/T679

Nov 14 2014, 10:06 AM · Elasticsearch, Search
GMTA created T6552: Implement partial / wildcard searching (Elasticsearch).
Nov 14 2014, 9:03 AM · Elasticsearch, Search

Nov 13 2014

chad added a subtask for T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: T5282: Provide documentation on setting up ElasticSearch.
Nov 13 2014, 5:56 PM · Search
chad added a project to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: Elasticsearch.
Nov 13 2014, 5:50 PM · Search
btrahan added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

The task description has a little spec that I like over a setup warning. Support Impact part is true given the recent merge action.

Nov 13 2014, 5:47 PM · Search
chad added a project to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: Support Impact.

This has recently had some Support Impact. A setup warning seems reasonable?

Nov 13 2014, 5:44 PM · Search

Nov 12 2014

chad updated subscribers of T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.
Nov 12 2014, 5:11 AM · Search
chad edited projects for T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it, added: Search; removed Maniphest.
Nov 12 2014, 5:07 AM · Search

Nov 2 2014

chad renamed T4475: Provide easier way to search within any Application when in it from allow making search scope default to the currently-selected component to Provide shortcuts in Search Typeahead to searching just within the current Application.
Nov 2 2014, 11:15 PM · Restricted Project, Search

Oct 30 2014

GMTA added a comment to T6406: Manual search reindex fails on "unable to load object by phid".

Maybe this pattern could help: this particular wiki document was moved ("This document was moved from elsewhere"). The second error I get on reindexing also refers to a wiki document that was moved.

Oct 30 2014, 8:42 AM · Search
GMTA added a comment to T6406: Manual search reindex fails on "unable to load object by phid".
  • Running bin/remove destroy <phid> is usually a reasonable way to resolve the error. Ignoring it is also reasonable.

I've tried that just now:

tools@dev1:~/phabricator/phabricator/bin$ ./remove destroy PHID-WIKI-amenci5bzyxy5k4ndwwu
Usage Exception: No such object "PHID-WIKI-amenci5bzyxy5k4ndwwu" exists!

So I did a text search through all databases and found relations to this PHID in the following tables:

  • feed_storydata
  • feed_storyreference
  • phriction_document
  • search_document
  • search_documentfield
  • search_documentrelationship
  • worker_taskdata

Maybe this could help in finding the source of the bug. Thanks for the explanation, I'll just ignore it for now!

Oct 30 2014, 8:39 AM · Search
GMTA added a comment to T6406: Manual search reindex fails on "unable to load object by phid".

Huh, I didn't know that was possible. How does one check the definitive shell history of all users on a given host?

We have single user access for our central phabricator install, whose sessions are explicitly logged in case of stuff like this :)

Oct 30 2014, 8:31 AM · Search

Oct 29 2014

epriestley triaged T6406: Manual search reindex fails on "unable to load object by phid" as Wishlist priority.
  • This warning seems scary, but is super minor. We should probably tailor the output to make this more clear, or silence the warning entirely when running in batch (--all or --type) modes (showing it when indexing a single object probably still makes sense).
  • Usually, this is because some sub-object doesn't exist. In this case, when we load a wiki page we also load the content. Probably the content has gone missing somehow. We decline to load partial objects and fail with this error. Other cases are, e.g., a commit with a missing repository.
  • Running bin/remove destroy <phid> is usually a reasonable way to resolve the error. Ignoring it is also reasonable.
  • The root cause is probably an actual bug, but we don't have nearly enough information to figure out what happened by just seeing that something went missing (there's no way to reproduce the issue, and in most or all cases examining the database doesn't give us any more information). There are a handful of outstanding issues with Phriction, particularly around moves/renames and project integration, so whatever the root cause was will probably be fixed when we clean that stuff up.
Oct 29 2014, 4:39 PM · Search
btrahan added a project to T6406: Manual search reindex fails on "unable to load object by phid": Search.
Oct 29 2014, 4:07 PM · Search

Oct 27 2014

AndrewMemSQL added a comment to T6399: Include project descriptions as part of search index.

Thanks for the quick turnaround! Much appreciated guys.

Oct 27 2014, 8:42 PM · Projects, Search
epriestley closed T6399: Include project descriptions as part of search index as Resolved.

Closed by commit rPde40bc0c1d86.

Oct 27 2014, 8:37 PM · Projects, Search
epriestley added a comment to T6399: Include project descriptions as part of search index.

After D10748:

Oct 27 2014, 7:53 PM · Projects, Search
epriestley added a revision to T6399: Include project descriptions as part of search index: Restricted Differential Revision.
Oct 27 2014, 7:49 PM · Projects, Search
epriestley added a comment to T6399: Include project descriptions as part of search index.

Oh, right, there's no fulltext search support for custom fields right now. Fixing description indexing is simple, let me just do that first and we'll go from there. We could build custom field fulltext stuff too, potentially, but that's far more involved.

Oct 27 2014, 7:16 PM · Projects, Search
AndrewMemSQL added a comment to T6399: Include project descriptions as part of search index.

I added a custom text field to my projects and made it searchable.

Oct 27 2014, 6:53 PM · Projects, Search
qgil added a comment to T6399: Include project descriptions as part of search index.

You can also have Herald rules adding i.e. "offline" tag-project to any task associated with "Offline Email Reader" project.

Oct 27 2014, 5:20 PM · Projects, Search
epriestley added a comment to T6399: Include project descriptions as part of search index.

Ah, sure, we can make that text searchable.

Oct 27 2014, 4:58 PM · Projects, Search
epriestley renamed T6399: Include project descriptions as part of search index from Allow non-unique, searchable hashtags on projects to Include project descriptions as part of search index.
Oct 27 2014, 4:57 PM · Projects, Search

Oct 17 2014

btrahan closed T6337: mentions don't show hovercards for logged-out users as Resolved.

Closed by commit rP934eea2ef2a0.

Oct 17 2014, 12:34 AM · Search, Remarkup
btrahan added a project to T6337: mentions don't show hovercards for logged-out users: Search.
Oct 17 2014, 12:33 AM · Search, Remarkup

Oct 10 2014

epriestley merged task T6283: Make what is searched context dependent (e.g. restrict search within phriction when initiated from phriction) into T4475: Provide easier way to search within any Application when in it.
Oct 10 2014, 11:41 AM · Search, Wikimedia
qgil added a project to T6283: Make what is searched context dependent (e.g. restrict search within phriction when initiated from phriction): Search.
Oct 10 2014, 9:28 AM · Search, Wikimedia

Oct 9 2014

Unknown Object (User) moved T5991: `bin/search index` returns 0 on failure from In Progress to Details on the Wikimedia board.
Oct 9 2014, 8:48 AM · Search
Unknown Object (User) moved T5991: `bin/search index` returns 0 on failure from Details to In Progress on the Wikimedia board.
Oct 9 2014, 8:48 AM · Search

Sep 30 2014

qgil moved T5990: Elasticsearch search backend requires auto_create_index turned on from Backlog to Details on the Wikimedia board.
Sep 30 2014, 7:22 PM · Elasticsearch, Search
qgil moved T5991: `bin/search index` returns 0 on failure from Backlog to Details on the Wikimedia board.
Sep 30 2014, 7:22 PM · Search

Sep 15 2014

pablocarrillo added a comment to T5941: Show Phriction Pages in Search Typeahead.

We are starting with phabricator and would really like this feature.

Sep 15 2014, 11:08 AM · Phriction

Sep 2 2014

chad added a project to T5990: Elasticsearch search backend requires auto_create_index turned on: Elasticsearch.
Sep 2 2014, 3:50 PM · Elasticsearch, Search

Aug 31 2014

aklapper added a project to T5990: Elasticsearch search backend requires auto_create_index turned on: Wikimedia.
Aug 31 2014, 7:28 PM · Elasticsearch, Search
aklapper added a project to T5991: `bin/search index` returns 0 on failure: Wikimedia.
Aug 31 2014, 7:28 PM · Search

Aug 29 2014

WikiChad added a comment to T5990: Elasticsearch search backend requires auto_create_index turned on.

Actually, we can work around this quite nicely after talking with folks. If auto_create_index is set to false, we just need to create an empty index and it'll figure out the mapping when the first document is inserted. In ES speak, it's just issuing a simple PUT to the bare index that doesn't exist yet: curl -s -XPUT <es-host>:9200/<index-name>

Aug 29 2014, 3:53 PM · Elasticsearch, Search
epriestley added a comment to T5990: Elasticsearch search backend requires auto_create_index turned on.

Cool, thanks!

Aug 29 2014, 1:52 PM · Elasticsearch, Search
WikiChad added a comment to T5990: Elasticsearch search backend requires auto_create_index turned on.

No, nothing incorrect about your usage, just need to detect the scenario and error out properly. There's two workarounds:

  • Disable the setting completely, create your index, turn the setting back to how you had it
  • Configure the setting to whitelist the phabricator* index and blacklist the others.
Aug 29 2014, 1:51 PM · Elasticsearch, Search
epriestley added a comment to T5991: `bin/search index` returns 0 on failure.

This is a bit complicated. We return nonzero on a "hard" error, like a bad type:

Aug 29 2014, 1:12 PM · Search
epriestley added a comment to T5990: Elasticsearch search backend requires auto_create_index turned on.

auto_create_index is on by default, right? Users would have had to turn it off explicitly when configuring ElasticSearch, and we'd compensate for this by checking for the value of the setting and then printing a warning reminding them about the configuration change they made? Or is the way we're inserting documents fundamentally incorrect?

Aug 29 2014, 12:38 PM · Elasticsearch, Search

Aug 28 2014

• chasemp added a comment to T5991: `bin/search index` returns 0 on failure.
root@iphab>/srv/phab/phabricator/bin/search index --all
Run this workflow with "--background" to queue tasks for the daemon workers.
Indexing 1 object of type USER.
[                                                                  ]   0.0%[2014-08-28 21:39:40] PHLOG: 'Unable to index document PHID-USER-wbxngm5jjacogkt4vdro with engine PhabricatorSearchEngineElastic.' at [/srv/phab/phabricator/src/applications/search/index/PhabricatorSearchDocumentIndexer.php:57]
[2014-08-28 21:39:40] EXCEPTION: (HTTPFutureHTTPResponseStatus) [HTTP/404] Not Found
{"error":"IndexMissingException[[phabricatormain] missing]","status":404} at 
...truncated output...
Done.
Aug 28 2014, 9:57 PM · Search
WikiChad created T5991: `bin/search index` returns 0 on failure.
Aug 28 2014, 9:55 PM · Search
WikiChad added a comment to T5990: Elasticsearch search backend requires auto_create_index turned on.

(for a bit of background: we've got this set to false at WMF because ES has a bad habit of not creating indexes exactly as we'd like them so we don't trust it to and have an index-creation script ourselves)

Aug 28 2014, 9:51 PM · Elasticsearch, Search
WikiChad updated subscribers of T5990: Elasticsearch search backend requires auto_create_index turned on.
Aug 28 2014, 9:49 PM · Elasticsearch, Search
WikiChad created T5990: Elasticsearch search backend requires auto_create_index turned on.
Aug 28 2014, 9:48 PM · Elasticsearch, Search

Aug 22 2014

epriestley added a comment to T5941: Show Phriction Pages in Search Typeahead.

We don't have a typeahead-friendly index for articles right now, but can do this in the future. It probably won't happen before other infrastructure work like T4029.

Aug 22 2014, 7:15 PM · Phriction

Aug 21 2014

chad renamed T5941: Show Phriction Pages in Search Typeahead from Remarkup rule for Phriction articles to Show Phriction Pages in Search Typeahead.
Aug 21 2014, 11:15 PM · Phriction