Page MenuHomePhabricator
Create Task
Maniphest T6664

Clicking the search icon in empty search field should link to advanced search
Closed, ResolvedPublic
Actions

Description

We have two little usability problems that could be neutralized in one go:

  1. There is no direct link to https://secure.phabricator.com/search/query/advanced/ , and users must perform a search to know it exists.
  2. Users clicking the fa-search icon with an empty search field at the header end up at the beginning of the list of results of the first saved search, which is confusing until the day you understand why this happens (you were not asking for that specific query).

What about applying this simple behavior: clicking the fa-search icon with an empty search field takes you to https://phabricator.wikimedia.org/search/query/advanced/

Original reported at https://phabricator.wikimedia.org/T370

Revisions and Commits

rP Phabricator
D10947rP4506018339a0 Clicking the search icon in empty search field should link to advanced search

Event Timeline

qgil created this task.Nov 30 2014, 9:50 PM
qgil raised the priority of this task from to Needs Triage.
qgil updated the task description. (Show Details)
qgil added a project: Search.
qgil updated the task description. (Show Details)
qgil added a subscriber: qgil.
chad renamed this task from Clicking fa-search icon in empty search field at the header should link to the general advanced search to Clicking the search icon in empty search field should link to advanced search.Dec 1 2014, 2:36 AM
epriestley assigned this task to lpriestley.Dec 1 2014, 9:20 PM
epriestley added a subscriber: epriestley.

I think the simplest fix is:

  • In PhabricatorSearchController, there's a special case if search:primary is present in the request, indicating that the form submission came from the main menu.
  • If that's set, and if (!strlen($request->getStr('query'))) { ... } (i.e., the user didn't type anything), return an AphrontRedirectResponse taking the user to /search/query/advanced/.
  • Clicking just the search icon should then take you to an empty search form, instead of performing a useless search for the empty string.
epriestley triaged this task as Low priority.Dec 1 2014, 9:20 PM
lpriestley added a revision: D10947: Clicking the search icon in empty search field should link to advanced search.Dec 8 2014, 7:25 PM
epriestley closed this task as Resolved.Dec 8 2014, 7:27 PM
epriestley added a commit: rP4506018339a0: Clicking the search icon in empty search field should link to advanced search.

Closed by commit rP4506018339a0.

qgil awarded a token.Dec 8 2014, 7:58 PM
Phabricator · Built by Phacility