I don't think implementing this task would make anything more complex. It doesn't change anything UX wise: things would work exactly as before in all the cases you described since the default behavior is unchanged. It only allows exposes explicitly said default behavior like for other settings on the page and let orgs in which the majority of users would rather not receive self-notifications change from opt-out to opt-in.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 17 2014
Jun 16 2014
@chad, the line you mentioned, wouldn't this changed the default for the option as it is displayed but not as it is implemented? I mean shouldn't I instead change the initial value for PhabricatorUserPreferences::PREFERENCE_NO_SELF_MAIL?
Jun 15 2014
Thanks much for addressing this issue Evan.
Jun 14 2014
That's great, thanks for implementing this!
Jun 13 2014
FYI deleting the edges directly in the DB fixed the issue in both cases.
I found another board with the same issue. This time the invisible task is in the backlog column of 2 other projects.
T5356 got merged into this one but the idea is not mentioned above: it's about displaying the secondary projects a task is in the bubble as well.
Poking around the database, this is the column that can't be deleted:
INSERT INTO `project_column` (`id`, `phid`, `name`, `status`, `sequence`, `projectPHID`, `dateCreated`, `dateModified`) VALUES (23, X'504849442D50434F4C2D7964657172736E3565706E356471717965786C62', 'Fri 6/13', 0, 6, X'504849442D50524F4A2D6E7571356B353564793335716A32626F32366F32', 1401399132, 1402355539);
Well since you asked for it: T5359: Improve handling of non-supported image types in Pholio. That's the first issue we hit after introducing to our designers (not a blocker but annoying and probably not hard to fix).
Actually that would be great if someone could let me know where to patch the default value in the source, thanks.
We're going to be quite happy with Pholio, you can close this task. Thanks!
Knowing at a glance that a task is blocked is pretty important IMO, as much as priority or who is assigned.
Humm... I don't know then: now I can't delete another column in this same workboard, which only had 1 open task and in 1 project, this one. I dragged it back to backlog, but I can't delete the now empty column: says it's not empty.
I was able to repro by chance (or at least 1 way to get to it):
- Have a single tasks, closed, in a column which is in 2 projects
- Click edit button and remove the project of the current workboard
- Save
I was able to add and delete a column. I'd rather not try to delete an existing column which would require messing up with this workboard.
If you can think of things I can do to poke around the MySQL database to fix this, let me know.
Jun 12 2014
For context, here's a comment from our designer:
the main use case for me would be attaching mockups and assets for a developer to implement. When I hand off a task to Sam or whomever, they have to comb down the change log to find attachments inline, but it seems like it’d make more sense to have them arrayed at the top of the task as well.
Jun 11 2014
That might solve our need indeed, so we'll try it. Feel free to close this task.
Pholio is in beta though, so should we really be using it?
To clear, having inline attachments is very nice and should not change. This task is about the fact that because their are inline, they end up being hidden as well as the comments, while arguably, attachments are distinct from comments and for some tasks more important and should remain easily accessible.
FWIW we just had a meeting with the early adopters of Phabricator at our org, and the inability to delete (or get rid of) an empty column (visually empty since full of closed tasks), was reported by several people at their #1 annoyance.
Jun 10 2014
Jun 3 2014
Ah right that makes more sense. Can't I just fix the query to cut at say 4 instead of 2?
May 29 2014
If there is any way to disable the change of priority in the meantime (patching the source is OK), please let me know.
May 27 2014
To be clear, it's for more than just if someone filed a task without setting a project: it could be used to check the validity of various task fields like Projects or Assignee or check for a status change and kick back the task to the originator (after adding a comment as well I guess?).
Note that we have been using this feature for the past 10 days and it works great.
May 22 2014
The Herald rule would help because if the task wasn't filed properly you can then automagically re-assign it to the person who filed it. They can create at will but the task just gets re-assigned to them if they did it wrong so they can "try again".
Is it practical or good UI to leave around columns made of closed tasks? I would vote no since:
- It's wasting space on screen and create "holes" in your board
- It makes it harder to see everything at a glance
- Dragging tasks from backlog becomes a total pain as you have to go across the entire screen or more each time
Thanks, I got to work and add support for <img> in remarkup: P1158.
I got the extension in place, but I think there's an override problem:
<img>http://images.apple.com/home/images/promo_macbookair.jpg</img>
Results in:
It's not so much about the functionality, it's just that it's super convenient to do in-page filtering in workboards and the implementation is great: because the query is an overlay vs being anchored at the top of the page it's not wasting a ton of space nor distracting.
I think something lacking here which would be nice is if Herald could assign tasks to the task creator. This would then let you create a Herald "global task validation rule" that could re-assign to the creator.
May 21 2014
Thanks for your detailed feedback! I can only agree with your approach and this is indeed the core problem (observed a number of times at a personal level or during meetings review the workloads through Maniphest tasks):
I don't think D9224 is addressing what this very task was originally about or am I missing something?
- Just show the "Hide" button even for custom queries (that's a big help UI wise IMO): so you can hide this gigantic form when you're done tweaking it.
- When coming to a pre-built query from another place (e.g. from "View All" in a project page), have the query form hidden by default instead of shown (same as when clicking on a saved query), as it's less likely you'll want to further customize these results. To me the real problem BTW is that the project view does not show all the tasks in place (T5148).
Makes total sense and thanks for the pointer!
Why is image proxying needed (which I assume means transferring the image data from the other server through the Phabricator server) vs just allowing to embedding an image URL that points to another server?
May 20 2014
Yes events are a workaround for part of the problem (set a default assignee per project), but then they become a problem when now you have to enforce conventions when people create projects so they remember to create Herald rules or tasks are lost. In any case, the primary problem is the possibility for tasks to be created / edited without a project. Now you need someone who's (yes part-time, but still) job is just to watch and route these. What if this person is very busy or on vacation, etc...
@chad I certainly don't remember it being a problem at Apple but maybe it was the case in some groups. Actually, I would say that's a great example where you certainly need to enforce a top-level component at the bug creator level: you can't imagine bug going to "Apple" and have some bug router person at this scale ;) If one is reporting a bug on TextEdit, you set the component to TextEdit. Same for technologies like WebKit. Anyone can figure this out. Then regarding the subcomponents (WebKit / Rendering), you wouldn't expect the bug reporter to know about it or even do it.
In our case I would like the defaults to be administrators / administrators.
One more thing: if you get to a task query from a special place vs building the query by hand (e.g. when clicking on View All on a project page), the query form should be hidden by default.
I'm sure there might be others, but Phabricator is the first task tracking system I use that doesn't enforce a top-level classification of tasks into "components" (e.g. iOS, Web, Backend...), which would be the equivalent of requesting tasks to be at least in one project. I would also expects most orgs to only use task tracking software internally (excluding customer support software like Zendesk), which means people are familiar with the names of the common projects.
Also the copy for the prompt dialog when watching a project is not very clear:
Watching a project will let you monitor it closely. You will receive email and notifications about changes to every object associated with projects you watch.
I understood this as including wiki docs since it says "every object associated". If it's only tasks, it might be better to just say "tasks".
For instance production access is per endpoint (http://docs.aws.amazon.com/ses/latest/DeveloperGuide/request-production-access.html). Same for SMTP settings e.g. "email-smtp.us-west-2.amazonaws.com".
Got it, feel free to close this ticket as a dup then.
No, D9185 only applies to tasks, and Phriction never sends email right now.
Just to be clear: with the landing of D9185 does this mean if you watch a project, you also get email notifications for edits (or creation) on the project's wiki page as well as any subpage?
Like custom fields already have an option to be searchable or not, they should have an option to be "displayable" (off by default) to indicate they appear in the UI where the object is displayed e.g. search results boxes, link popup boxes, workboard boxes, etc...
Note that this is not about assigning a default project which can be done with Herald. It's about making sure every new task is at least in one sensible project.
Also the doc is not clear on what happens if editing a comment (vs adding a comment) and mentioning a user? Would that add to the CC list as well? Editing a description should adopt the same behavior.
FYI Amazon SES does have different endpoints per region:
http://docs.aws.amazon.com/general/latest/gr/rande.html#ses_region
May 19 2014
May 18 2014
I like the idea of "slots" in the board UI (it would be a config setting: "show slots" I assume). Is there a task tracking this specific enhancement?
Indeed it works, thanks!
FWIW I think task management systems should have no overlapping dimensions as this invites complexity, confusion, extra conventions and maintenance. In practice, this means you shouldn't have a dimension for which some values require another dimensions to only be in some other specific values: that's redundancy of information. A bit of information should only be stored and defined in a single place. It can of course be displayed in multiple places.
Fair enough. In the mean time, I'll patch this piece of code:
public function getDisplayName() {
if ($this->isDefaultColumn()) {
return pht('Backlog');
}
return $this->getName();
}I guess column name should also be reflected in the popup that appears when mouse hovering on a task link if that's not already the case.
May 17 2014
Most impressive! This is the second time I've seen a hourly turnaround on a task in a few days, which I have never seen before on a large open source project. This reflects greatly on the dedication of the team to this fine product. Thanks so much!
@chad The Internet is a surprisingly small world :) Thanks much for having supported our product! I'm been spending more and more time with Phabricator recently and I'm really liking it more and more. It's certainly excellent to support engineering work. I just wished it had a few small extra features which would significantly improve its use for project management, road-mapping, etc...
Thanks for offering to accept a patch and the pointers. I have a programming background and have contributing to various open source projects. The only reason I haven't proposed a patch upfront is that I'm not comfortable with this code base yet (and I haven't done any PHP coding in 10+ years which doesn't help). I will have a look and circle back.
That's an unfortunate limitation of an otherwise really neat feature which kind of prevents using most effectively especially for lists of tasks (you need to mouse hover over the task reference to know its status) .
Ah that's too bad! I was looking forward to tell the team about this super neat feature especially for lists of tasks, but not knowing the task has been fixed does limit its usefulness. In your own comment for instance, I could only notice you didn't use the feature:
See also T3945 (implementing checkbox lists) and T405 (syntax to embed query results in a comment or description).
Sorry about this, I can't believe I missed that, for some reason I thought it was for media, not tasks and revisions!
Of course, where you really end up saving time, it's when listing tasks e.g.
Action items resulting from meeting on May 15th: - T25+ - T26+ - T27+ - T28+ - T29+