Page MenuHomePhabricator

Add "Can Edit Mock Policies" setting to /applications/edit/PhabricatorApplicationPholio/
Closed, WontfixPublic

Description

Same as for https://phabricator.automatic.co/applications/edit/PhabricatorApplicationManiphest/ so we can set it to No One and have the access control fields disappear from the form for creating / editing mocks (it helps keeping the interface as simple as possible).

Event Timeline

swisspol raised the priority of this task from to Needs Triage.
swisspol updated the task description. (Show Details)
swisspol added a subscriber: swisspol.

How old is your install? Pholio was modernized over the weekend, with full Policy support.

undefined (319×582 px, 45 KB)

We're likely to Unbeta Pholio in the next week, there are just a few loose ends at this point.

Oh, maybe I am misreading your question. Seems Maniphest has more options.

Is this something you'd set Globally if that option were available? If I'm understanding your core issue, it's that your install is private and open and "Policies" in general are UI clutter.

If that option was available in the app setting, I would change it to no-one like we have done for Maniphest for the reasons you mentioned.

epriestley triaged this task as Wishlist priority.Jun 21 2014, 3:02 PM
epriestley added a subscriber: epriestley.

I don't currently plan to add field-level policies everywhere just to reduce UI clutter. You can comment these elements out if you're confident you never want to use policies in Pholio.

When Pholio eventually moves to CustomFields we might let you remove these fields.

Would this patch do it in PholioMockEditController.php?

// ->appendChild(
//   id(new AphrontFormPolicyControl())
//   ->setUser($user)
//   ->setCapability(PhabricatorPolicyCapability::CAN_VIEW)
//   ->setPolicyObject($mock)
//   ->setPolicies($policies)
//   ->setName('can_view'))
->addHiddenInput('can_view', 'users')
// ->appendChild(
//   id(new AphrontFormPolicyControl())
//   ->setUser($user)
//   ->setCapability(PhabricatorPolicyCapability::CAN_EDIT)
//   ->setPolicyObject($mock)
//   ->setPolicies($policies)
//   ->setName('can_edit'))
->addHiddenInput('can_edit', 'users')

I think that's sufficient, yes.

epriestley claimed this task.

We don't plan to change this specifically. After Pholio eventually moves to CustomField we could talk about making them disableable if this is still a concern at that time. Elsewhere (e.g., Differential) we don't currently allow you to disable these fields, although I think there's no technical reason why we couldn't.