Page MenuHomePhabricator
Differential D14256

Update metamta for handleRequest
ClosedPublic
Actions

Authored by chad on Oct 12 2015, 6:44 PM.
Tags
None
Referenced Files
F15564323: D14256.id34422.diff
Wed, Apr 30, 11:35 AM
F15563836: D14256.id34422.diff
Wed, Apr 30, 10:09 AM
F15563835: D14256.id.diff
Wed, Apr 30, 10:09 AM
F15563834: D14256.diff
Wed, Apr 30, 10:09 AM
F15559533: D14256.id.diff
Tue, Apr 29, 9:14 AM
F15554412: D14256.diff
Mon, Apr 28, 6:55 AM
F15543893: D14256.id34422.diff
Sat, Apr 26, 1:44 AM
F15525402: D14256.diff
Mon, Apr 21, 2:09 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8628: Modernize AphrontControllers to implement handleRequest
Commits
Restricted Diffusion Commit
rPdac16264e401: Update metamta for handleRequest
Summary

Updates metamta for handleRequest

Test Plan

Unable to test this, but looks safe?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34419.Oct 12 2015, 6:44 PM
chad retitled this revision from to Update metamta for handleRequest.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 12 2015, 6:44 PM
epriestley accepted this revision.Oct 12 2015, 6:49 PM
epriestley edited edge metadata.

Yeah, this is super hard to test locally. Changes look fine and you can test the Mailgun half by sending mail to this install after I push it.

src/applications/metamta/controller/PhabricatorMetaMTAMailgunReceiveController.php
30–31

You could nuke this, I think.

src/applications/metamta/controller/PhabricatorMetaMTASendGridReceiveController.php
13–14

And this.

This revision is now accepted and ready to land.Oct 12 2015, 6:49 PM
Closed by commit rPdac16264e401: Update metamta for handleRequest (authored by chad, committed by chad). · Explain WhyOct 12 2015, 7:02 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a task: T8628: Modernize AphrontControllers to implement handleRequest.Oct 18 2015, 6:58 AM

Revision Contents
Changeset List

Diff 34422

View Options

src/applications/metamta/controller/PhabricatorMetaMTAMailgunReceiveController.php

Loading...
View Options

src/applications/metamta/controller/PhabricatorMetaMTASendGridReceiveController.php

Loading...
Phabricator · Built by Phacility