Paths

Table of Contentst

Differential D14268

Update Search for handleRequest
ClosedPublic
Actions

Authored by chad on Oct 13 2015, 8:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 15, 8:42 PM

	Unknown Object (File)
	Fri, Dec 6, 11:41 AM

	Unknown Object (File)
	Wed, Dec 4, 8:27 AM

	Unknown Object (File)
	Tue, Dec 3, 5:32 PM

	Unknown Object (File)
	Tue, Dec 3, 5:32 PM

	Unknown Object (File)
	Tue, Dec 3, 5:32 PM

	Unknown Object (File)
	Tue, Dec 3, 5:27 PM

	Unknown Object (File)
	Tue, Dec 3, 5:07 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T8628: Modernize AphrontControllers to implement handleRequest

Commits

Restricted Diffusion Commit
rP09ab82faefaa: Update Search for handleRequest

Summary

Ref T8628. Updates Search.

Test Plan

Did various searches, saved new queries, reordered, ran new queries.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34446.Oct 13 2015, 8:48 PM

chad retitled this revision from to Update Search for handleRequest.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 13 2015, 8:48 PM

joshuaspence updated this object.Oct 18 2015, 6:51 AM

joshuaspence added a task: T8628: Modernize AphrontControllers to implement handleRequest.

I think I got one issue.

src/applications/search/controller/PhabricatorSearchDeleteController.php
9	Did this change? Previously `$data['engine']`, now `getURIData('engineClass')`? I don't see a corresponding route change.
src/applications/search/controller/PhabricatorSearchEditController.php
8	`$id` is unused / not present in the URI?

This revision now requires changes to proceed.Oct 18 2015, 11:19 AM

Fix per comments

epriestley accepted this revision.Oct 20 2015, 3:56 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 20 2015, 3:56 PM

Closed by commit rP09ab82faefaa: Update Search for handleRequest (authored by chad, committed by chad). · Explain WhyOct 20 2015, 4:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

controller/

PhabricatorSearchController.php

15 lines

PhabricatorSearchDeleteController.php

31 lines

PhabricatorSearchEditController.php

25 lines

PhabricatorSearchHovercardController.php

1 line

PhabricatorSearchOrderController.php

18 lines

Diff 34547

src/applications/search/controller/PhabricatorSearchController.php

Loading...

src/applications/search/controller/PhabricatorSearchDeleteController.php

Loading...

src/applications/search/controller/PhabricatorSearchEditController.php

Loading...

src/applications/search/controller/PhabricatorSearchHovercardController.php

Loading...

src/applications/search/controller/PhabricatorSearchOrderController.php

Loading...