HomePhabricator
Diffusion Phabricator 36a50ccbae1e

Provide a more modern way to load packages owning a set of files
Audited36a50ccbae1e
Actions

Description

Provide a more modern way to load packages owning a set of files

Summary:
Ref T8320. Ref T8004. This just tries to generally modernize

It also replaces the nonfunctional "Find Owners" link with a new property that just shows owning packages.

Test Plan:

  • Created and edited packages.

Screen Shot 2015-08-15 at 12.43.54 PM.png (278×510 px, 22 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8004, T8320

Differential Revision: https://secure.phabricator.com/D13911

Details

Auditors
CodeMouse92
Provenance
epriestleyAuthored on
epriestleyPushed on Aug 15 2015, 8:06 PM
Reviewer
chad
Differential Revision
D13911: Provide a more modern way to load packages owning a set of files
Parents
rP8149399312b0: Convert commits to use unified table of contents
Branches
Unknown
Tags
Unknown
Tasks
T8320: Bring Owners out of the dark ages
T8004: Highlight files owned by self/project when viewing revision

Event Timeline

epriestley committed rP36a50ccbae1e: Provide a more modern way to load packages owning a set of files (authored by epriestley).Aug 15 2015, 8:06 PM
epriestley added a task: T8320: Bring Owners out of the dark ages.
epriestley added a task: T8004: Highlight files owned by self/project when viewing revision.
CodeMouse92 raised a concern with this commit.EditedAug 16 2015, 11:19 PM
CodeMouse92 added a subscriber: CodeMouse92.

When I attempt to view any branch in Diffusion since this landed, I get the error message.

Unhandled Exception ("PhutilInvalidStateException")
Call withControl() before calling getControllingPackagesForPath()!

See T9201: Unhandled Exception ("InvalidArgumentException") on random Differential

epriestley requested verification of this commit.Jan 27 2017, 5:21 PM

I believe work on T9201 resolved this.

This commit now requires verification by auditors.Jan 27 2017, 5:21 PM
CodeMouse92 accepted this commit.Mar 4 2017, 1:40 AM
All concerns with this commit have now been addressed.Mar 4 2017, 1:40 AM

Changes (7)

PathSize
src/
applications/
diffusion/
controller/
owners/
controller/
editor/
query/
storage/

rP36a50ccbae1e

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersPathsController.php

Loading...
View Options

src/applications/owners/editor/PhabricatorOwnersPackageTransactionEditor.php

Loading...
View Options

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

Loading...
View Options

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...
View Options

src/applications/owners/storage/PhabricatorOwnersPath.php

Loading...
Phabricator · Built by Phacility