Page MenuHomePhabricator
Differential D13922

Further modernize OwnersPackageQuery
ClosedPublic
Actions

Authored by epriestley on Aug 17 2015, 4:14 PM.
Tags
None
Referenced Files
F18829915: D13922.id33598.diff
Sat, Oct 25, 2:09 AM
F18818679: D13922.id.diff
Wed, Oct 22, 1:44 AM
F18817447: D13922.id33602.diff
Tue, Oct 21, 3:41 PM
F18815940: D13922.diff
Tue, Oct 21, 4:20 AM
F18807778: D13922.id33598.diff
Sun, Oct 19, 3:27 AM
F18807777: D13922.id.diff
Sun, Oct 19, 3:27 AM
F18763208: D13922.diff
Mon, Oct 6, 11:14 PM
F18712706: D13922.id.diff
Mon, Sep 29, 5:31 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8320: Bring Owners out of the dark ages
Commits
Restricted Diffusion Commit
rP6cfeb9e54014: Further modernize OwnersPackageQuery
Summary

Ref T8320.

  • Add needOwners().
  • Split withOwnerPHIDs() [exact owners] and withAuthorityPHIDs() [indirect authority] apart.
  • Restore searching by path.
Test Plan

Browsed pacakges, edited packages, edited paths.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 33598.Aug 17 2015, 4:14 PM
epriestley retitled this revision from to Further modernize OwnersPackageQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8320: Bring Owners out of the dark ages.
chad accepted this revision.Aug 17 2015, 5:05 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 17 2015, 5:05 PM
Closed by commit rP6cfeb9e54014: Further modernize OwnersPackageQuery (authored by epriestley, committed by epriestley). · Explain WhyAug 17 2015, 5:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33602

View Options

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

Loading...
View Options

src/applications/owners/conduit/OwnersQueryConduitAPIMethod.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersEditController.php

Loading...
View Options

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

Loading...
View Options

src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php

Loading...
View Options

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...
Phabricator · Built by Phacility