Page MenuHomePhabricator

Improve handle semantics with HandlePool / HandleList

Authored by epriestley on Mar 30 2015, 1:27 AM.



Ref T7689, which discusses some of the motivation here. Briefly, these methods are awkward:

  • Controller->loadHandles()
  • Controller->loadViewerHandles()
  • Controller->renderHandlesForPHIDs()

This moves us toward better semantics, less awkwardness, and a more reasonable attack on T7688 which won't double-fetch a bunch of data.

Test Plan
  • Added unit tests.
  • Converted one controller to the new stuff.
    • Viewed countdown lists, saw handles render.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 29325.Mar 30 2015, 1:27 AM
epriestley retitled this revision from to Improve handle semantics with HandlePool / HandleList.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad awarded a token.Mar 30 2015, 4:15 AM
btrahan accepted this revision.Mar 30 2015, 7:54 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 7:54 PM
This revision was automatically updated to reflect the committed changes.