Page MenuHomePhabricator

Improve handle semantics with HandlePool / HandleList
ClosedPublic

Authored by epriestley on Mar 30 2015, 1:27 AM.
Tags
None
Referenced Files
F12852469: D12202.diff
Fri, Mar 29, 7:23 AM
Unknown Object (File)
Feb 24 2024, 1:01 AM
Unknown Object (File)
Feb 3 2024, 2:45 AM
Unknown Object (File)
Jan 31 2024, 8:39 PM
Unknown Object (File)
Jan 31 2024, 6:42 PM
Unknown Object (File)
Dec 26 2023, 3:20 AM
Unknown Object (File)
Dec 15 2023, 6:11 PM
Unknown Object (File)
Dec 15 2023, 3:50 PM
Subscribers
Tokens
"Grey Medal" token, awarded by chad.

Details

Summary

Ref T7689, which discusses some of the motivation here. Briefly, these methods are awkward:

  • Controller->loadHandles()
  • Controller->loadViewerHandles()
  • Controller->renderHandlesForPHIDs()

This moves us toward better semantics, less awkwardness, and a more reasonable attack on T7688 which won't double-fetch a bunch of data.

Test Plan
  • Added unit tests.
  • Converted one controller to the new stuff.
    • Viewed countdown lists, saw handles render.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve handle semantics with HandlePool / HandleList.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 7:54 PM
This revision was automatically updated to reflect the committed changes.