Page MenuHomePhabricator

Improve handle loading semantics for tokenizers
ClosedPublic

Authored by epriestley on Apr 2 2015, 2:00 PM.

Details

Summary

Ref T7689. Fixes T7688. When there are a bunch of tokenizers with different values of the same object type (e.g. 5 tokenizers with users a, b, c, d, e) we currently issue 5 separate queries to load their handles.

Improve this behavior in the common case so we can usually batch these loads.

Test Plan
  • In Maniphest, set the various search fields to different values.
  • Used DarkConsole to examine query plan.
  • Saw fewer queries after patch than before.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Improve handle loading semantics for tokenizers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 2 2015, 8:05 PM
This revision was automatically updated to reflect the committed changes.