Use DiffQuery instead of direct hunk loads in MessageParser daemon
ClosedPublic
Actions

Authored by epriestley on May 25 2014, 3:24 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4045: Store diffs as binary, not UTF-8
T5179: Unearth Differential rendering technical debt

Commits

Restricted Diffusion Commit
rPcb58acbe5bcd: Use DiffQuery instead of direct hunk loads in MessageParser daemon

Summary

Ref T5179. Ref T4045. Continue reducing the number of direct hunk loads we perform.

Test Plan

Pushed a closing commit, used scripts/repository/reparse.php --message ... to trigger this logic, got a sensible/accurate result.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22053.May 25 2014, 3:24 PM

epriestley retitled this revision from to Use DiffQuery instead of direct hunk loads in MessageParser daemon.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T5179: Unearth Differential rendering technical debt, T4045: Store diffs as binary, not UTF-8.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 25 2014, 3:24 PM

Harbormaster completed remote builds in B696: Diff 22053.May 25 2014, 3:25 PM

btrahan accepted this revision.Jun 3 2014, 10:11 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 3 2014, 10:11 PM

Closed by commit rPcb58acbe5bcd (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

worker/

commitmessageparser/

PhabricatorRepositoryCommitMessageParserWorker.php

28 lines

Diff 22327

View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Use DiffQuery instead of direct hunk loads in MessageParser daemonClosedPublicActions