Page MenuHomePhabricator
Differential D9293

Write new hunks to the modern hunk store
ClosedPublic
Actions

Authored by epriestley on May 25 2014, 7:05 PM.
Tags
None
Referenced Files
F18783276: D9293.id.diff
Mon, Oct 13, 5:41 AM
F18767621: D9293.id22332.diff
Tue, Oct 7, 11:28 PM
F18741100: D9293.id22060.diff
Thu, Oct 2, 8:32 AM
F18704204: D9293.diff
Sep 28 2025, 6:34 AM
F18624333: D9293.id.diff
Sep 15 2025, 7:33 PM
F18616860: D9293.id22332.diff
Sep 14 2025, 7:16 PM
F18616213: D9293.id.diff
Sep 14 2025, 4:37 PM
F18602194: D9293.diff
Sep 13 2025, 2:29 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4045: Store diffs as binary, not UTF-8
T5179: Unearth Differential rendering technical debt
Commits
Restricted Diffusion Commit
rP40e2a1c800ff: Write new hunks to the modern hunk store
Summary

Ref T4045. Ref T5179. Send all new writes into the modern store.

Test Plan
  • Created a diff.
  • Verified it went to the modern store.
  • Destroyed a revision, verified hunks were destroyed.
  • Also unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22060.May 25 2014, 7:05 PM
epriestley retitled this revision from to Write new hunks to the modern hunk store.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T5179: Unearth Differential rendering technical debt, T4045: Store diffs as binary, not UTF-8.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 25 2014, 7:05 PM
Harbormaster completed remote builds in B703: Diff 22060.May 25 2014, 7:06 PM
btrahan accepted this revision.Jun 3 2014, 10:12 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2014, 10:12 PM
epriestley closed this revision.Jun 4 2014, 1:03 AM
epriestley updated this revision to Diff 22332.

Closed by commit rP40e2a1c800ff (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
parser/
__tests__/
4 lines
2 lines
storage/
13 lines
2 lines
__tests__/
4 lines
repository/
worker/
commitmessageparser/
4 lines

Diff 22332

View Options

src/applications/differential/parser/__tests__/DifferentialChangesetParserTestCase.php

Loading...
View Options

src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php

Loading...
View Options

src/applications/differential/storage/DifferentialChangeset.php

Loading...
View Options

src/applications/differential/storage/DifferentialDiff.php

Loading...
View Options

src/applications/differential/storage/__tests__/DifferentialHunkTestCase.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility