Details
- Reviewers
btrahan - Maniphest Tasks
- Restricted Maniphest Task
T4045: Store diffs as binary, not UTF-8
T5179: Unearth Differential rendering technical debt - Commits
- Restricted Diffusion Commit
rPb20884a842a6: Substantially support character encodings and "Highlight As" in changesets
(See screenshots...)
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Here's a Shift-JIS diff being rendered correctly (we guess the encoding properly):
Here's the menu for changing encoding/highlight options:
Here's the same diff rendered explicitly as Shift-JIS (via the menu):
Here's the diff rendering with the wrong encoding (also via the menu):
Here's rainbow highlighting:
Whoops, sorry, I had looked at this at length weeks ago and didn't quite finish for some reason.
| src/applications/differential/view/DifferentialChangesetListView.php | ||
|---|---|---|
| 132 | Is "unified" the colloquial term here? (Does a colloquial term exist?) I'd probably go with "Inline" myself here. | |
| src/applications/differential/view/DifferentialChangesetListView.php | ||
|---|---|---|
| 132 | Unified comes from diff --unified, which I think is really talking about the diff format rather than its single-columnness, but I've seen at least one or two users use this term in the same way as here. If there's any confusion, we could call this something else. (I worry "inline" might cause some confusion with inline comments, though.) | |