Page MenuHomePhabricator

Substantially support character encodings and "Highlight As" in changesets
ClosedPublic

Authored by epriestley on May 25 2014, 9:10 PM.

Details

Summary

Ref T5179. Ref T4045. Ref T832. We can now write non-utf8 hunks into the database, so try to do more reasonable things with them in the UI.

Test Plan

(See screenshots...)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22062.May 25 2014, 9:10 PM
epriestley retitled this revision from to Substantially support character encodings and "Highlight As" in changesets.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

Here's a Shift-JIS diff being rendered correctly (we guess the encoding properly):

Here's the menu for changing encoding/highlight options:

Here's the same diff rendered explicitly as Shift-JIS (via the menu):

Here's the diff rendering with the wrong encoding (also via the menu):

Here's rainbow highlighting:

btrahan accepted this revision.Jun 20 2014, 5:21 PM
btrahan edited edge metadata.

Whoops, sorry, I had looked at this at length weeks ago and didn't quite finish for some reason.

src/applications/differential/view/DifferentialChangesetListView.php
132

Is "unified" the colloquial term here? (Does a colloquial term exist?) I'd probably go with "Inline" myself here.

This revision is now accepted and ready to land.Jun 20 2014, 5:21 PM
epriestley added inline comments.Jun 20 2014, 6:40 PM
src/applications/differential/view/DifferentialChangesetListView.php
132

Unified comes from diff --unified, which I think is really talking about the diff format rather than its single-columnness, but I've seen at least one or two users use this term in the same way as here.

If there's any confusion, we could call this something else. (I worry "inline" might cause some confusion with inline comments, though.)

epriestley closed this revision.Jun 20 2014, 6:49 PM
epriestley updated this revision to Diff 23143.

Closed by commit rPb20884a842a6 (authored by @epriestley).