Page MenuHomePhabricator

Allow modern hunks to be stored deflated
ClosedPublic

Authored by epriestley on May 25 2014, 6:50 PM.
Tags
None
Referenced Files
F13248699: D9292.diff
Fri, May 24, 3:56 AM
F13227721: D9292.diff
Mon, May 20, 5:02 AM
F13208224: D9292.diff
Thu, May 16, 11:56 AM
F13192168: D9292.diff
Sun, May 12, 6:03 AM
F13184829: D9292.diff
Sat, May 11, 12:39 AM
F13173963: D9292.diff
Tue, May 7, 9:30 PM
Unknown Object (File)
Sat, May 4, 7:01 AM
Unknown Object (File)
Wed, May 1, 3:01 AM
Subscribers

Details

Summary

Ref T4045. Ref T5179. When saving a modern hunk, deflate it if we have the function and deflating it will save a nontrivial number of bytes.

Test Plan
  • Used bin/hunks migrate to move some hunks over, saw ~70-80% compression on most standard hunks.
  • Viewed changesets using compressed hunks.
  • Profiled gzinflate() and verified the cost is trivial (<< 1ms) at least for normal diffs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Allow modern hunks to be stored deflated.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2014, 10:12 PM
epriestley updated this revision to Diff 22331.

Closed by commit rP4b39fbe1155e (authored by @epriestley).