When the Differential filetree is toggled, resize the keyboard reticle properly
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 2:01 PM.

Tags

None

Referenced Files

	F15446821: D17902.diff
	Thu, Mar 27, 8:26 PM

	F15436473: D17902.id43061.diff
	Tue, Mar 25, 2:29 PM

	F15436272: D17902.id43061.diff
	Tue, Mar 25, 1:04 PM

	F15428974: D17902.id43072.diff
	Sun, Mar 23, 11:49 PM

	F15427282: D17902.id.diff
	Sun, Mar 23, 1:31 PM

	F15421087: D17902.diff
	Fri, Mar 21, 8:54 PM

	F15393551: D17902.id43072.diff
	Sat, Mar 15, 9:44 PM

	Unknown Object (File)
	Mar 3 2025, 7:53 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset
T12634: Keyboard focus reticle is generally oblivious to the world around it

Commits

rP3c0da8161967: When the Differential filetree is toggled, resize the keyboard reticle properly

Summary

Ref T9270. Ref T12634. Emit a resize event after toggling the filetree so that things can recalculate layout.

This just does the keyboard reticle, not the mouse/edit reticle.

Test Plan

Used "n" to select a block.
Used "f" to toggle the filetree.
Saw reticle resize properly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 16 2017, 2:01 PM

Harbormaster completed remote builds in B16989: Diff 43061.May 16 2017, 2:02 PM

chad accepted this revision.May 16 2017, 2:23 PM

This revision is now accepted and ready to land.May 16 2017, 2:23 PM

Closed by commit rP3c0da8161967: When the Differential filetree is toggled, resize the keyboard reticle properly (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 3:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

20 lines

webroot/

rsrc/

js/

core/

behavior-phabricator-nav.js

4 lines

Diff 43072

View Options

resources/celerity/map.php