Page MenuHomePhabricator

Move keyboard focus reticle code to Differential
ClosedPublic

Authored by epriestley on May 16 2017, 1:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 8:57 PM
Unknown Object (File)
Fri, Jan 24, 8:57 PM
Unknown Object (File)
Fri, Jan 24, 8:57 PM
Unknown Object (File)
Fri, Jan 24, 8:57 PM
Unknown Object (File)
Fri, Jan 24, 8:17 PM
Unknown Object (File)
Dec 26 2024, 8:21 PM
Unknown Object (File)
Dec 14 2024, 1:44 AM
Unknown Object (File)
Dec 11 2024, 7:53 AM
Subscribers
None

Details

Summary

Ref T12634. Using keyboard shortcuts in Differential currently relies on focus behavior in KeyboardShortcutManager.

This possibly made sense long ago, but no longer does, and leads to a whole slew of bugs where the reticle doesn't interact properly with anything else.

Move it to Differential so it can be made reasonably aware of edit operations, Quicksand navigation, etc.

This just moves the code; future diffs will actually fix bugs.

Test Plan

Used "n", "j", etc., saw the same behavior as before.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 16 2017, 1:44 PM
This revision was automatically updated to reflect the committed changes.