Emit resize events after making document changes during inline editing
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 2:13 PM.

Tags

None

Referenced Files

	F15486544: D17904.id43074.diff
	Thu, Apr 10, 8:06 AM

	F15481070: D17904.id43063.diff
	Tue, Apr 8, 5:56 PM

	F15430254: D17904.id43063.diff
	Mon, Mar 24, 6:45 AM

	F15419130: D17904.id43074.diff
	Fri, Mar 21, 3:47 AM

	F15418332: D17904.id.diff
	Thu, Mar 20, 10:38 PM

	F15413036: D17904.diff
	Wed, Mar 19, 4:35 PM

	F15387235: D17904.diff
	Mar 15 2025, 2:04 AM

	F15338513: D17904.diff
	Mar 9 2025, 11:11 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle
T12634: Keyboard focus reticle is generally oblivious to the world around it

Commits

rP1493f08272dc: Emit resize events after making document changes during inline editing

Summary

Ref T12634. Fixes T12633. These events allow the keyboard reticle to resize properly.

(I expect to possibly hide/disable the reticle in the future during edits, but at least make the behavior sensible for now.)

Test Plan

Used "n" to select a block.
Clicked a line number in that block to start a new inline comment.
Saw reticle resize properly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 16 2017, 2:13 PM

Harbormaster completed remote builds in B16991: Diff 43063.May 16 2017, 2:15 PM

chad accepted this revision.May 16 2017, 2:32 PM

This revision is now accepted and ready to land.May 16 2017, 2:32 PM

Closed by commit rP1493f08272dc: Emit resize events after making document changes during inline editing (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 3:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

6 lines

Diff 43074

View Options

resources/celerity/map.php