Page MenuHomePhabricator

Emit resize events after making document changes during inline editing
ClosedPublic

Authored by epriestley on May 16 2017, 2:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 4, 4:48 AM
Unknown Object (File)
Fri, Jan 24, 8:59 PM
Unknown Object (File)
Fri, Jan 24, 8:59 PM
Unknown Object (File)
Fri, Jan 24, 8:59 PM
Unknown Object (File)
Fri, Jan 24, 8:59 PM
Unknown Object (File)
Fri, Jan 24, 10:48 AM
Unknown Object (File)
Fri, Jan 24, 10:46 AM
Unknown Object (File)
Tue, Jan 21, 10:37 AM
Subscribers
None

Details

Summary

Ref T12634. Fixes T12633. These events allow the keyboard reticle to resize properly.

(I expect to possibly hide/disable the reticle in the future during edits, but at least make the behavior sensible for now.)

Test Plan
  • Used "n" to select a block.
  • Clicked a line number in that block to start a new inline comment.
  • Saw reticle resize properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable