Page MenuHomePhabricator

Retain keyboard cursor state across more inline edit operations in Differential
ClosedPublic

Authored by epriestley on May 16 2017, 2:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 3:03 AM
Unknown Object (File)
Thu, Dec 19, 5:29 PM
Unknown Object (File)
Sat, Dec 14, 1:44 AM
Unknown Object (File)
Fri, Dec 13, 10:56 PM
Unknown Object (File)
Sun, Dec 8, 7:19 PM
Unknown Object (File)
Thu, Dec 5, 9:02 AM
Unknown Object (File)
Sun, Dec 1, 7:27 AM
Unknown Object (File)
Wed, Nov 27, 6:44 AM
Subscribers
None

Details

Summary

Ref T12634. Fixes T8131. Currently, most edit operations (edit, reply, collapse, mark done) lose the keyboard cursor state.

Instead, bind the state more tighlty to the inline object itself (instead of the rows which happen to be in the document), and then do a bit of recalculation to try to keep it selected across edits.

Test Plan
  • Used "n" to select an inline.
  • Clicked "Done" checkbox.
  • Pressed "n".
  • Went to the next inline (previously: lost position in document).
  • Behavior is also better for: edit, reply, collapse/expand.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable