Diffusion Phabricator 665ff4fdf6e7

Redraw the Differential keyboard reticle after collapsing/un-collapsing an…
665ff4fdf6e7
Actions

Description

Redraw the Differential keyboard reticle after collapsing/un-collapsing an inline

Summary: Ref T12634. Fixes T10049. Toggling an inline currently leaves the reticle oddly-positioned.

Test Plan:

Selected a comment with the keyboard.
Collapsed it.
Saw reticle behave reasonably.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12634, T10049

Differential Revision: https://secure.phabricator.com/D17903

Details

Provenance

epriestley	Authored on May 16 2017, 2:03 PM
epriestley	Pushed on May 16 2017, 3:22 PM

Reviewer

chad

Differential Revision

D17903: Redraw the Differential keyboard reticle after collapsing/un-collapsing an inline

Parents

rP3c0da8161967: When the Differential filetree is toggled, resize the keyboard reticle properly

Branches

Unknown

Tags

Unknown

Tasks

T12634: Keyboard focus reticle is generally oblivious to the world around it
T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it

Build Status

Buildable 17001
Build 22728: Run Core Tests

Event Timeline

epriestley committed rP665ff4fdf6e7: Redraw the Differential keyboard reticle after collapsing/un-collapsing an… (authored by epriestley).May 16 2017, 3:22 PM

epriestley added a task: T12634: Keyboard focus reticle is generally oblivious to the world around it.

epriestley added a task: T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it.

Harbormaster completed building B17001: rP665ff4fdf6e7: Redraw the Differential keyboard reticle after collapsing/un-collapsing an….May 16 2017, 3:25 PM

Changes (2)

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

rP665ff4fdf6e7

View Options

resources/celerity/map.php