Diffusion Phabricator 3c0da8161967

When the Differential filetree is toggled, resize the keyboard reticle properly
3c0da8161967
Actions

Description

When the Differential filetree is toggled, resize the keyboard reticle properly

Summary:
Ref T9270. Ref T12634. Emit a resize event after toggling the filetree so that things can recalculate layout.

This just does the keyboard reticle, not the mouse/edit reticle.

Test Plan:

Used "n" to select a block.
Used "f" to toggle the filetree.
Saw reticle resize properly.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12634, T9270

Differential Revision: https://secure.phabricator.com/D17902

Details

Provenance

epriestley	Authored on May 16 2017, 1:59 PM
epriestley	Pushed on May 16 2017, 3:22 PM

Reviewer

chad

Differential Revision

D17902: When the Differential filetree is toggled, resize the keyboard reticle properly

Parents

rP7d6133929a66: Resize the Differential keyboard focus reticle when the window is resized

Branches

Unknown

Tags

Unknown

Tasks

T12634: Keyboard focus reticle is generally oblivious to the world around it
T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset

Build Status

Buildable 17000
Build 22727: Run Core Tests

Event Timeline

epriestley committed rP3c0da8161967: When the Differential filetree is toggled, resize the keyboard reticle properly (authored by epriestley).May 16 2017, 3:22 PM

epriestley added a task: T12634: Keyboard focus reticle is generally oblivious to the world around it.

epriestley added a task: T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset.

Harbormaster completed building B17000: rP3c0da8161967: When the Differential filetree is toggled, resize the keyboard reticle properly.May 16 2017, 3:25 PM

Changes (2)

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

core/

behavior-phabricator-nav.js

rP3c0da8161967

View Options

resources/celerity/map.php