Redraw the Differential keyboard reticle after collapsing/un-collapsing an inline
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 2:05 PM.

Tags

None

Referenced Files

	F15573383: D17903.diff
	Mon, May 5, 8:40 PM

	F15547706: D17903.id43062.diff
	Sat, Apr 26, 8:04 PM

	F15531082: D17903.id43073.diff
	Wed, Apr 23, 9:31 AM

	F15529249: D17903.id.diff
	Tue, Apr 22, 6:13 PM

	F15524652: D17903.diff
	Mon, Apr 21, 9:31 AM

	F15517075: D17903.diff
	Fri, Apr 18, 11:47 PM

	F15474776: D17903.id43062.diff
	Sun, Apr 6, 12:29 PM

	F15422933: D17903.id43073.diff
	Mar 22 2025, 11:30 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it
T12634: Keyboard focus reticle is generally oblivious to the world around it

Commits

rP665ff4fdf6e7: Redraw the Differential keyboard reticle after collapsing/un-collapsing an…

Summary

Ref T12634. Fixes T10049. Toggling an inline currently leaves the reticle oddly-positioned.

Test Plan

Selected a comment with the keyboard.
Collapsed it.
Saw reticle behave reasonably.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 16 2017, 2:05 PM

Harbormaster completed remote builds in B16990: Diff 43062.May 16 2017, 2:06 PM

epriestley mentioned this in T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it.May 16 2017, 2:07 PM

chad accepted this revision.May 16 2017, 2:27 PM

This revision is now accepted and ready to land.May 16 2017, 2:27 PM

Closed by commit rP665ff4fdf6e7: Redraw the Differential keyboard reticle after collapsing/un-collapsing an… (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 3:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

2 lines

Diff 43073

View Options

resources/celerity/map.php