Page MenuHomePhabricator
Differential D17903

Redraw the Differential keyboard reticle after collapsing/un-collapsing an inline
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 2:05 PM.
Tags
None
Referenced Files
F19893981: D17903.id43062.diff
Sat, Mar 28, 11:22 AM
F19891400: D17903.diff
Fri, Mar 27, 5:57 AM
F19887983: D17903.id43062.diff
Mon, Mar 23, 9:18 PM
F19865946: D17903.id43073.diff
Sat, Mar 14, 3:59 PM
F19705803: D17903.id43062.diff
Feb 11 2026, 8:18 AM
F19631801: D17903.id.diff
Feb 5 2026, 4:18 AM
F19568973: D17903.diff
Jan 31 2026, 10:22 PM
F19568968: D17903.diff
Jan 31 2026, 10:22 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it
T12634: Keyboard focus reticle is generally oblivious to the world around it
Commits
rP665ff4fdf6e7: Redraw the Differential keyboard reticle after collapsing/un-collapsing an…
Summary

Ref T12634. Fixes T10049. Toggling an inline currently leaves the reticle oddly-positioned.

Test Plan
  • Selected a comment with the keyboard.
  • Collapsed it.
  • Saw reticle behave reasonably.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
webroot/
rsrc/
js/
application/
diff/
2 lines

Diff 43073

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility