Differential D20637

Remove remnants of clumsy old URI state handling from workboards
ClosedPublic
Actions

Authored by epriestley on Jul 2 2019, 4:30 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T4900: Workboards updating in real time

Commits

rP2de8a23adb09: Remove remnants of clumsy old URI state handling from workboards

Summary

Depends on D20636. Ref T4900. Previously, some workflows didn't know how to identify the default state for the board, so they needed explicit ("force") parameters.

Everything uses the same state management code now so we can rip out the old stuff.

Test Plan

Changed board filters, selected a custom filter, edited a custom filter.

Diff Detail

Repository

rP Phabricator

Branch

refresh10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23091
Build 31704: Run Core Tests
Build 31703: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 2 2019, 4:30 PM

Harbormaster completed remote builds in B23091: Diff 49222.Jul 2 2019, 4:31 PM

epriestley requested review of this revision.Jul 2 2019, 4:31 PM

epriestley mentioned this in T4900: Workboards updating in real time.Jul 2 2019, 4:31 PM

epriestley added inline comments.

src/applications/project/controller/PhabricatorProjectBoardViewController.php
721–740	No actual changes here, just making the code look more similar throughout the controller.

epriestley added a child revision: D20638: Remove obsolete "options" from workboard "updateCard()" call.Jul 2 2019, 5:19 PM

amckinley accepted this revision.Jul 2 2019, 10:56 PM

This revision is now accepted and ready to land.Jul 2 2019, 10:56 PM

Closed by commit rP2de8a23adb09: Remove remnants of clumsy old URI state handling from workboards (authored by epriestley). · Explain WhyJul 3 2019, 5:05 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP2de8a23adb09: Remove remnants of clumsy old URI state handling from workboards.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectBoardViewController.php

62 lines

state/

PhabricatorWorkboardViewState.php

6 lines

Diff 49222

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php