Page MenuHomePhabricator

Remove remnants of clumsy old URI state handling from workboards
ClosedPublic

Authored by epriestley on Jul 2 2019, 4:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 27, 5:13 PM
Unknown Object (File)
Fri, Jun 27, 9:47 AM
Unknown Object (File)
Thu, Jun 19, 3:22 AM
Unknown Object (File)
Tue, Jun 17, 9:33 PM
Unknown Object (File)
May 31 2025, 11:16 PM
Unknown Object (File)
May 31 2025, 11:16 PM
Unknown Object (File)
May 29 2025, 2:06 PM
Unknown Object (File)
May 29 2025, 2:06 PM
Subscribers
None

Details

Summary

Depends on D20636. Ref T4900. Previously, some workflows didn't know how to identify the default state for the board, so they needed explicit ("force") parameters.

Everything uses the same state management code now so we can rip out the old stuff.

Test Plan

Changed board filters, selected a custom filter, edited a custom filter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley added inline comments.
src/applications/project/controller/PhabricatorProjectBoardViewController.php
721–741

No actual changes here, just making the code look more similar throughout the controller.

This revision is now accepted and ready to land.Jul 2 2019, 10:56 PM