Page MenuHomePhabricator

HarbormasterProject
ActivePublic

Recent Activity

Apr 25 2022

epriestley added a revision to T9530: Release Server / Workflow app / Future of Releeph : D21792: Remove the "Releeph" application.
Apr 25 2022, 11:40 PM · Restricted Project, Harbormaster

Jul 20 2021

epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21699: Rename "HarbormasterRestartException" to "HarbormasterMessageException".
Jul 20 2021, 9:43 PM · Harbormaster
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21698: Allow "harbormaster.sendmessage" to send control command (pause, restart, abort, resume) to Builds/Buildables.
Jul 20 2021, 9:41 PM · Harbormaster

Jul 16 2021

epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21696: Add a side nav to Conduit API method console pages.
Jul 16 2021, 10:15 PM · Harbormaster
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21695: Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods.
Jul 16 2021, 4:43 PM · Harbormaster
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21694: Modularize "HarbormasterBuildableTransaction".
Jul 16 2021, 4:00 PM · Harbormaster
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21693: Remove "HarbormasterBuildableTransaction::TYPE_CREATE".
Jul 16 2021, 3:34 PM · Harbormaster
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21692: Remove "HarbormasterBuildCommand".
Jul 16 2021, 3:10 PM · Harbormaster
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21691: Modularize almost all Harbormaster build message workflows and UI/UX.
Jul 16 2021, 1:30 AM · Harbormaster

Jul 15 2021

epriestley added a comment to T13072: Merge Harbormaster BuildCommand into BuildMessage.

This ("Queued at") looks suspicious:

Jul 15 2021, 11:03 PM · Harbormaster
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21690: Modularize individual Harbormaster build messages.
Jul 15 2021, 10:24 PM · Harbormaster
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21689: Modularize HarbormasterBuildTransaction.
Jul 15 2021, 9:05 PM · Harbormaster
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21688: Remove "HarbormasterBuildTransaction::TYPE_CREATE".
Jul 15 2021, 6:09 PM · Harbormaster
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21687: Correct the flow of edit authority when sending messages to HarbormasterBuild objects.
Jul 15 2021, 6:02 PM · Harbormaster

Jul 13 2021

epriestley added a comment to T13072: Merge Harbormaster BuildCommand into BuildMessage.

In D21685, I've imposed stricter rules for which state transitions are allowed: for example, you can't issue a "pause" command to a build that is already pausing.

Jul 13 2021, 11:41 PM · Harbormaster
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21685: Improve formality of "HarbormasterBuild" states.
Jul 13 2021, 11:37 PM · Harbormaster
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21684: Merge the "HarbormasterBuildCommand" table into "HarbormasterBuildMessage".
Jul 13 2021, 10:48 PM · Harbormaster
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: D21683: Rename "HarbormasterBuild" methods to prepare for use of the "BuildMessages" table.
Jul 13 2021, 10:23 PM · Harbormaster
epriestley updated the task description for T13072: Merge Harbormaster BuildCommand into BuildMessage.
Jul 13 2021, 10:04 PM · Harbormaster

Mar 4 2021

epriestley added a comment to T13612: Support Herald rules for Harbormaster Builds.

I dug up another one of these in PHI1439, but there is a lot of text in that issue that I haven't re-read yet.

Mar 4 2021, 5:54 PM · Herald, Harbormaster

Feb 19 2021

epriestley added a comment to T13612: Support Herald rules for Harbormaster Builds.

A minimal implementation here is probably:

Feb 19 2021, 4:57 AM · Herald, Harbormaster
epriestley updated the task description for T13612: Support Herald rules for Harbormaster Builds.
Feb 19 2021, 4:47 AM · Herald, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Feb 19 2021, 4:37 AM · Plans, Harbormaster
epriestley updated the task description for T13612: Support Herald rules for Harbormaster Builds.
Feb 19 2021, 4:34 AM · Herald, Harbormaster
epriestley updated the task description for T13612: Support Herald rules for Harbormaster Builds.
Feb 19 2021, 4:31 AM · Herald, Harbormaster
epriestley closed T10260: Harbormaster Herald Rules as Resolved.
Feb 19 2021, 4:31 AM · Haskell.org, Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T10260: Harbormaster Herald Rules.

See T13612 for followup.

Feb 19 2021, 4:31 AM · Haskell.org, Restricted Project, Harbormaster, Feature Request
epriestley closed T5491: Harbormaster Build Notification Status as Resolved.

Continued in T13612.

Feb 19 2021, 4:24 AM · Restricted Project, Harbormaster
epriestley updated the task description for T13612: Support Herald rules for Harbormaster Builds.
Feb 19 2021, 4:23 AM · Herald, Harbormaster
epriestley triaged T13612: Support Herald rules for Harbormaster Builds as Normal priority.
Feb 19 2021, 4:22 AM · Herald, Harbormaster

Feb 18 2021

epriestley closed T13609: Expose buildable object and container PHIDs as build variables as Resolved.
Feb 18 2021, 9:38 PM · Differential, Harbormaster
epriestley added a revision to T13609: Expose buildable object and container PHIDs as build variables: D21569: Add more useful PHIDs to Harbormaster build variables.
Feb 18 2021, 9:35 PM · Differential, Harbormaster
epriestley triaged T13609: Expose buildable object and container PHIDs as build variables as Normal priority.
Feb 18 2021, 9:32 PM · Differential, Harbormaster

Feb 16 2021

epriestley closed T13607: Provide additional query constraints in "harbormaster.target.search" as Resolved.

Yep, that's more constraints.

Feb 16 2021, 8:34 PM · Harbormaster, Conduit
epriestley added a revision to T13607: Provide additional query constraints in "harbormaster.target.search": D21559: Add more constraints to "harbormaster.target.search".
Feb 16 2021, 8:06 PM · Harbormaster, Conduit
epriestley triaged T13607: Provide additional query constraints in "harbormaster.target.search" as Normal priority.
Feb 16 2021, 7:47 PM · Harbormaster, Conduit

Feb 15 2021

epriestley closed T13605: Implement a "differential.changeset.search" API method as Resolved.

See T13125 and PHI1997 for followup.

Feb 15 2021, 7:47 PM · Harbormaster, Differential
epriestley added a revision to T13605: Implement a "differential.changeset.search" API method: D21558: Provide a "differential.changeset.search" Conduit API method.
Feb 15 2021, 7:07 PM · Harbormaster, Differential
epriestley added a revision to T13605: Implement a "differential.changeset.search" API method: D21557: Add a PHID to Changesets.
Feb 15 2021, 6:13 PM · Harbormaster, Differential
epriestley triaged T13605: Implement a "differential.changeset.search" API method as Normal priority.
Feb 15 2021, 6:01 PM · Harbormaster, Differential

Jan 13 2021

epriestley updated the task description for T13072: Merge Harbormaster BuildCommand into BuildMessage.
Jan 13 2021, 8:39 PM · Harbormaster

Nov 3 2020

epriestley added a revision to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit: D21488: Add a basic "harbormaster.step.search" API method.
Nov 3 2020, 8:50 PM · Conduit, Harbormaster
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
  • There is no way to pull custom field values with *.search. See above.
    • There is no way to edit non-custom field values with *.edit. The underlying transactions haven't been modularized yet; they should be, then EditEngine should get appropriate EditField definitions.
    • There's no way to identify which custom fields can be edited. This overlaps with T13248, but is also a Conduit API Console UI problem. The web UI should have some way to inspect parameter variations per object subtype for available subtypes.
      • As a workaround, you can try to edit an invalid field. The error message will identify valid fields.
    • There's no way to create steps with *.edit because you can't specify a step type. See T13449 for a general variation of the "type is required to initialize objects" problem.
Nov 3 2020, 8:49 PM · Conduit, Harbormaster
epriestley added a revision to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit: D21489: Add a basic "harbormaster.step.edit" API method.
Nov 3 2020, 8:46 PM · Conduit, Harbormaster
epriestley renamed T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit from Expose "harbormaster.buildstep.edit" and "harbormaster.buildstep.search" over Conduit to Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
Nov 3 2020, 8:45 PM · Conduit, Harbormaster
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.

HarbormasterBuildStepCoreCustomField emits no fields if a BuildStep has no attached Implementation object. This dates from D15352 and is conceptually reasonable ("don't crash if a build step exists but the implementation no longer does") but should probably be represented differently (e.g., an explicit "InvalidImplementation").

Nov 3 2020, 8:18 PM · Conduit, Harbormaster
epriestley triaged T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit as Normal priority.
Nov 3 2020, 8:17 PM · Conduit, Harbormaster

Oct 26 2020

altendky added a comment to T5508: Add branch name parameter to Harbormaster "Make HTTP Request" build step.

I think I've got a small tidbit to add on a specific use-case with Jenkins. I had been using pipeline builds which are working nicely but I just tried to setup a multi-branch pipeline build and this requires the branch name in the Jenkins URL of the HTTP request triggering the build. I suspect in this case the proper thing to do would be to trigger and build twice. I guess that's more of an on-branch-change sort of situation than on-commit and using those triggers in Herald (they look to be present, I haven't used them) and having that information passed on to Harbormaster as mentioned could fill the need.

Oct 26 2020, 9:40 PM · Restricted Project, Harbormaster

Jul 16 2020

epriestley added a comment to T6769: Confusing UI when harbormaster fails but differential is accepted.

Please use Discourse to discuss Phabricator. (And please don't bump unrelated tasks from five and a half years ago.)

Jul 16 2020, 3:11 PM · Harbormaster
Kwisatz added a comment to T6769: Confusing UI when harbormaster fails but differential is accepted.

Is this really a harbormaster problem though? I would have located it within Differential.

Jul 16 2020, 12:49 PM · Harbormaster