Page MenuHomePhabricator

HarbormasterProject
ActivePublic

Recent Activity

Wed, Jan 13

epriestley updated the task description for T13072: Merge Harbormaster BuildCommand into BuildMessage.
Wed, Jan 13, 8:39 PM · Harbormaster

Nov 3 2020

epriestley added a revision to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit: D21488: Add a basic "harbormaster.step.search" API method.
Nov 3 2020, 8:50 PM · Conduit, Harbormaster
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
  • There is no way to pull custom field values with *.search. See above.
    • There is no way to edit non-custom field values with *.edit. The underlying transactions haven't been modularized yet; they should be, then EditEngine should get appropriate EditField definitions.
    • There's no way to identify which custom fields can be edited. This overlaps with T13248, but is also a Conduit API Console UI problem. The web UI should have some way to inspect parameter variations per object subtype for available subtypes.
      • As a workaround, you can try to edit an invalid field. The error message will identify valid fields.
    • There's no way to create steps with *.edit because you can't specify a step type. See T13449 for a general variation of the "type is required to initialize objects" problem.
Nov 3 2020, 8:49 PM · Conduit, Harbormaster
epriestley added a revision to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit: D21489: Add a basic "harbormaster.step.edit" API method.
Nov 3 2020, 8:46 PM · Conduit, Harbormaster
epriestley renamed T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit from Expose "harbormaster.buildstep.edit" and "harbormaster.buildstep.search" over Conduit to Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
Nov 3 2020, 8:45 PM · Conduit, Harbormaster
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.

HarbormasterBuildStepCoreCustomField emits no fields if a BuildStep has no attached Implementation object. This dates from D15352 and is conceptually reasonable ("don't crash if a build step exists but the implementation no longer does") but should probably be represented differently (e.g., an explicit "InvalidImplementation").

Nov 3 2020, 8:18 PM · Conduit, Harbormaster
epriestley triaged T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit as Normal priority.
Nov 3 2020, 8:17 PM · Conduit, Harbormaster

Oct 26 2020

altendky added a comment to T5508: Add branch name parameter to Harbormaster "Make HTTP Request" build step.

I think I've got a small tidbit to add on a specific use-case with Jenkins. I had been using pipeline builds which are working nicely but I just tried to setup a multi-branch pipeline build and this requires the branch name in the Jenkins URL of the HTTP request triggering the build. I suspect in this case the proper thing to do would be to trigger and build twice. I guess that's more of an on-branch-change sort of situation than on-commit and using those triggers in Herald (they look to be present, I haven't used them) and having that information passed on to Harbormaster as mentioned could fill the need.

Oct 26 2020, 9:40 PM · Restricted Project, Harbormaster

Jul 16 2020

epriestley added a comment to T6769: Confusing UI when harbormaster fails but differential is accepted.

Please use Discourse to discuss Phabricator. (And please don't bump unrelated tasks from five and a half years ago.)

Jul 16 2020, 3:11 PM · Harbormaster
Kwisatz added a comment to T6769: Confusing UI when harbormaster fails but differential is accepted.

Is this really a harbormaster problem though? I would have located it within Differential.

Jul 16 2020, 12:49 PM · Harbormaster

Jun 4 2020

epriestley moved T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff from Backlog to arc land on the Arcanist board.
Jun 4 2020, 3:10 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Restricted Project

May 20 2020

epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D21281: Drop old "differential_commit" table.
May 20 2020, 7:30 PM · Diffusion, Harbormaster, Herald, Audit

Apr 30 2020

epriestley added a comment to T13526: Error raised when "HarbormasterBuildPlanBehavior->getPlanOption()" is reachable with no plan.

See https://discourse.phabricator-community.org/t/typeerror-w-arc-diff-when-build-plan-view-policy-does-not-contain-user/3820/. The reproduction case is "policy makes the build plan invisible".

Apr 30 2020, 3:46 PM · Harbormaster
epriestley added a revision to T13526: Error raised when "HarbormasterBuildPlanBehavior->getPlanOption()" is reachable with no plan: D21194: Stabilize fatals when a build has a build plan the viewer can't see because of policy restrictions.
Apr 30 2020, 2:47 PM · Harbormaster

Apr 28 2020

epriestley added a comment to T13526: Error raised when "HarbormasterBuildPlanBehavior->getPlanOption()" is reachable with no plan.

I'm having trouble reproducing figuring out how to reproduce this locally.

Apr 28 2020, 11:05 AM · Harbormaster
epriestley triaged T13526: Error raised when "HarbormasterBuildPlanBehavior->getPlanOption()" is reachable with no plan as Low priority.
Apr 28 2020, 10:57 AM · Harbormaster

Feb 24 2020

epriestley added a comment to T13188: CircleCI 1.0 sunsets on August 31, 2018; CircleCI 2.0 can not work with Phabricator.

See also PHI1605 (internal), which provides some evidence that:

Feb 24 2020, 5:05 PM · Guides, Harbormaster

Feb 13 2020

epriestley closed T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential, a subtask of T9123: Build Phabricator in Harbormaster (v2), as Resolved.
Feb 13 2020, 12:20 AM · Prioritized, Harbormaster

Feb 7 2020

epriestley added a comment to T13426: Add a "Saved States" indirection layer on top of "Staging Areas".

A saved state is likely something like this:

Feb 7 2020, 4:54 PM · Harbormaster, Drydock, Arcanist
epriestley added a comment to T11402: Garbage collect and/or compress/archive harbormaster build unit messages.

I'd like to leave behind a "Results were GC'd on X/Y/Z" message when we GC these so it's clear what's going on.

Feb 7 2020, 2:07 PM · Restricted Project, Harbormaster, Feature Request

Feb 5 2020

epriestley added a revision to T10635: Loading differential revision slow when lots of unit test messages exist: D20970: In summary interfaces, don't render very large inline remarkup details for unit test messages.
Feb 5 2020, 3:45 PM · Restricted Project, Haskell.org, Harbormaster, Performance
epriestley triaged T10635: Loading differential revision slow when lots of unit test messages exist as Wishlist priority.
Feb 5 2020, 3:41 PM · Restricted Project, Haskell.org, Harbormaster, Performance

Feb 4 2020

epriestley added a comment to T10635: Loading differential revision slow when lots of unit test messages exist.

See also PHI1628, which reports that a 4MB blob of test details is slow to render.

Feb 4 2020, 8:48 PM · Restricted Project, Haskell.org, Harbormaster, Performance

Jan 30 2020

epriestley closed T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml) as Wontfix.

We have no open customer requests for this and it's very complex, so I don't currently plan to implement it.

Jan 30 2020, 2:59 PM · Restricted Project, Harbormaster
PhoneixS added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

Another use case :

Jan 30 2020, 12:37 PM · Restricted Project, Harbormaster

Oct 29 2019

epriestley added a revision to T13438: Implement "harbormaster.artifact.search": D20878: Roughly implement "harbormaster.artifact.search".
Oct 29 2019, 8:30 PM · Harbormaster
epriestley triaged T13438: Implement "harbormaster.artifact.search" as Low priority.
Oct 29 2019, 8:29 PM · Harbormaster

Sep 27 2019

epriestley added a comment to T13426: Add a "Saved States" indirection layer on top of "Staging Areas".

One broad problem here is "chain of custody" issues in T182. A "Saved State" can easily accommodate multiple representations, and the plan above imagines using Drydock to build tags/branches out of non-repository representations, so we'd have cases where a given "Saved State" has a way to build it with a "patch list" (from the client) or a "ref pointer" (from Drydock).

Sep 27 2019, 6:43 PM · Harbormaster, Drydock, Arcanist
epriestley triaged T13426: Add a "Saved States" indirection layer on top of "Staging Areas" as Normal priority.
Sep 27 2019, 6:28 PM · Harbormaster, Drydock, Arcanist

Sep 25 2019

epriestley added a comment to T13424: Support builds with TeamCity in Harbormaster.

The problem isn't that it's in rough shape (I'm fine with bringing rough stuff upstream), but that it's something I may eventually want to license as a paid extension. I generally want to stop bringing "free glue for paid systems" upstream (T13229).

Sep 25 2019, 2:22 PM · Harbormaster
swisspol added a comment to T13424: Support builds with TeamCity in Harbormaster.

How about landing this as a prototype?

Sep 25 2019, 4:46 AM · Harbormaster

Sep 23 2019

epriestley added a comment to T13424: Support builds with TeamCity in Harbormaster.

(This has been made to exist, at least roughly; see PHI1448.)

Sep 23 2019, 4:34 PM · Harbormaster
epriestley closed T12011: Support builds with Travis CI, a subtask of T9456: Evaluate upstream support for third-party build systems, as Wontfix.
Sep 23 2019, 4:33 PM · Restricted Project, Harbormaster
epriestley closed T12011: Support builds with Travis CI as Wontfix.

TravisCI sold to Idera and is no longer "cool".

Sep 23 2019, 4:33 PM · Harbormaster, Feature Request
epriestley closed T9456: Evaluate upstream support for third-party build systems as Resolved.

I generally don't plan to upstream any more support for third-party build tools, since I don't think a future where Phabricator is free glue for a bunch of paid systems is desirable. The pathways forward here are either:

Sep 23 2019, 4:29 PM · Restricted Project, Harbormaster
epriestley added a subtask for T9456: Evaluate upstream support for third-party build systems: T13424: Support builds with TeamCity in Harbormaster.
Sep 23 2019, 3:42 PM · Restricted Project, Harbormaster
epriestley added a parent task for T13424: Support builds with TeamCity in Harbormaster: T9456: Evaluate upstream support for third-party build systems.
Sep 23 2019, 3:41 PM · Harbormaster
epriestley triaged T13424: Support builds with TeamCity in Harbormaster as Low priority.
Sep 23 2019, 3:41 PM · Harbormaster

Aug 29 2019

pasik added a comment to T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.

Also an example how "per-push notification" is implemented in Github events/webhooks:

Aug 29 2019, 6:18 PM · Restricted Project, Harbormaster
pasik added a comment to T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.

I actually found my way here from discourse where the need for this was discussed:

Aug 29 2019, 6:04 PM · Restricted Project, Harbormaster

Aug 20 2019

epriestley updated the task description for T13072: Merge Harbormaster BuildCommand into BuildMessage.
Aug 20 2019, 3:50 PM · Harbormaster

Aug 8 2019

epriestley updated the task description for T13072: Merge Harbormaster BuildCommand into BuildMessage.
Aug 8 2019, 2:27 PM · Harbormaster

Jul 24 2019

epriestley closed T13348: "Restart All Builds" is misleading in the presence of non-restartable builds as Resolved by committing rPf6621a5fdcff: Tailor "Restart All Builds" for the complex realities of modern build restart….
Jul 24 2019, 4:25 PM · Harbormaster
epriestley added a revision to T13348: "Restart All Builds" is misleading in the presence of non-restartable builds: D20679: Tailor "Restart All Builds" for the complex realities of modern build restart rules.
Jul 24 2019, 3:14 PM · Harbormaster

Jul 23 2019

epriestley triaged T13348: "Restart All Builds" is misleading in the presence of non-restartable builds as Normal priority.
Jul 23 2019, 1:18 PM · Harbormaster

Jul 12 2019

epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T9124: Support uploading build log data via the Harbormaster API, as Resolved.
Jul 12 2019, 4:28 PM · Restricted Project, Harbormaster

May 17 2019

epriestley closed T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time as Resolved.

This stuff is largely resolved, but survived by a few remaining issues in T13290.

May 17 2019, 2:18 PM · Diffusion, Harbormaster, Herald, Audit

May 3 2019

epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20491: Hide the "added a commit/revision" stories from feed and mail.
May 3 2019, 3:00 PM · Diffusion, Harbormaster, Herald, Audit
epriestley moved T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time from Backlog to Next on the Herald board.
May 3 2019, 5:11 AM · Diffusion, Harbormaster, Herald, Audit

May 1 2019

epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20490: Fix the direction of the commit/revision edge.
May 1 2019, 3:47 PM · Diffusion, Harbormaster, Herald, Audit