Page MenuHomePhabricator

Merge the "HarbormasterBuildCommand" table into "HarbormasterBuildMessage"
ClosedPublic

Authored by epriestley on Jul 13 2021, 10:48 PM.
Tags
None
Referenced Files
F18855251: D21684.id51645.diff
Sat, Nov 1, 4:35 AM
F18830314: D21684.diff
Sat, Oct 25, 6:05 AM
F18828713: D21684.diff
Fri, Oct 24, 5:47 PM
F18827621: D21684.id.diff
Fri, Oct 24, 11:08 AM
F18795489: D21684.id.diff
Fri, Oct 17, 2:04 AM
F18792236: D21684.diff
Thu, Oct 16, 7:14 PM
F18775411: D21684.id51699.diff
Fri, Oct 10, 6:58 PM
F18734427: D21684.id.diff
Sep 30 2025, 10:53 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. These two similar tables don't make sense to keep separate. Instead, make Build a valid receiver for BuildMessage objects.

These tables are practically the same, so this is straightforward: just copy the rows in and then drop the old table.

(This table was trivial and ephemeral anyway, so I'm not bothering to do the usual "keep it around for a couple years just in case".)

Test Plan
  • Populated BuildCommand table, ran migration, saw Builds end up in the proper transitional state (e.g., pausing, aborting, restarting) with appropriate queued messages.
  • Queued new messages by clicking UI buttons.
  • Ran BuildWorkers, saw them process messages and mark them as consumed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 13 2021, 10:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:17 PM
This revision was automatically updated to reflect the committed changes.