Page MenuHomePhabricator

Modularize almost all Harbormaster build message workflows and UI/UX
ClosedPublic

Authored by epriestley on Jul 16 2021, 1:30 AM.
Tags
None
Referenced Files
F17843721: D21691.diff
Sun, Jul 27, 1:16 AM
Unknown Object (File)
May 28 2025, 6:32 PM
Unknown Object (File)
May 27 2025, 11:28 AM
Unknown Object (File)
Apr 27 2025, 12:45 PM
Unknown Object (File)
Apr 24 2025, 6:29 PM
Unknown Object (File)
Apr 23 2025, 9:14 PM
Unknown Object (File)
Apr 23 2025, 8:56 AM
Unknown Object (File)
Apr 18 2025, 11:21 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. Push nearly all Harbormaster build message logic into the new per-message transaction classes.

Test Plan
  • Issued every message to Buildables.
  • Issued every message to Builds.
  • Looked at a big pile of error messages, couldn't find any typos.
  • Grepped for affected symbols, etc.
  • Ran bin/harbormaster restart ....

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 16 2021, 1:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:18 PM
This revision was automatically updated to reflect the committed changes.