Page MenuHomePhabricator

Modularize almost all Harbormaster build message workflows and UI/UX
ClosedPublic

Authored by epriestley on Jul 16 2021, 1:30 AM.
Tags
None
Referenced Files
F18810319: D21691.diff
Sun, Oct 19, 9:02 PM
F18807649: D21691.diff
Sun, Oct 19, 2:42 AM
F18791284: D21691.diff
Thu, Oct 16, 8:54 AM
F18781066: D21691.id51653.diff
Sun, Oct 12, 9:17 PM
F18774795: D21691.id51704.diff
Fri, Oct 10, 5:03 PM
F18734433: D21691.id.diff
Sep 30 2025, 10:54 PM
F18622365: D21691.id.diff
Sep 15 2025, 11:30 AM
F18594675: D21691.id.diff
Sep 12 2025, 6:57 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. Push nearly all Harbormaster build message logic into the new per-message transaction classes.

Test Plan
  • Issued every message to Buildables.
  • Issued every message to Builds.
  • Looked at a big pile of error messages, couldn't find any typos.
  • Grepped for affected symbols, etc.
  • Ran bin/harbormaster restart ....

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 16 2021, 1:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:18 PM
This revision was automatically updated to reflect the committed changes.