Page MenuHomePhabricator

Modularize almost all Harbormaster build message workflows and UI/UX

Authored by epriestley on Jul 16 2021, 1:30 AM.
Referenced Files
F11522371: D21691.diff
Fri, Feb 3, 2:38 AM
Unknown Object (File)
Sat, Jan 28, 4:39 PM
Unknown Object (File)
Tue, Jan 24, 2:59 PM
Unknown Object (File)
Thu, Jan 19, 12:45 PM
Unknown Object (File)
Thu, Jan 19, 11:23 AM
Unknown Object (File)
Wed, Jan 11, 4:45 AM
Unknown Object (File)
Wed, Jan 11, 4:42 AM
Unknown Object (File)
Wed, Jan 11, 4:42 AM
Restricted Owners Package



Ref T13072. Push nearly all Harbormaster build message logic into the new per-message transaction classes.

Test Plan
  • Issued every message to Buildables.
  • Issued every message to Builds.
  • Looked at a big pile of error messages, couldn't find any typos.
  • Grepped for affected symbols, etc.
  • Ran bin/harbormaster restart ....

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 16 2021, 1:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:18 PM
This revision was automatically updated to reflect the committed changes.