Page MenuHomePhabricator

Modularize almost all Harbormaster build message workflows and UI/UX
ClosedPublic

Authored by epriestley on Jul 16 2021, 1:30 AM.
Tags
None
Referenced Files
F19049711: D21691.id51704.diff
Thu, Nov 27, 6:00 PM
F18998561: D21691.id.diff
Thu, Nov 20, 7:02 PM
F18974921: D21691.diff
Sun, Nov 16, 1:16 AM
F18936799: D21691.diff
Mon, Nov 10, 9:16 PM
F18933060: D21691.id51653.diff
Mon, Nov 10, 10:21 AM
F18810319: D21691.diff
Oct 19 2025, 9:02 PM
F18807649: D21691.diff
Oct 19 2025, 2:42 AM
F18791284: D21691.diff
Oct 16 2025, 8:54 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. Push nearly all Harbormaster build message logic into the new per-message transaction classes.

Test Plan
  • Issued every message to Buildables.
  • Issued every message to Builds.
  • Looked at a big pile of error messages, couldn't find any typos.
  • Grepped for affected symbols, etc.
  • Ran bin/harbormaster restart ....

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 16 2021, 1:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:18 PM
This revision was automatically updated to reflect the committed changes.