Page MenuHomePhabricator

Modularize almost all Harbormaster build message workflows and UI/UX
ClosedPublic

Authored by epriestley on Jul 16 2021, 1:30 AM.
Tags
None
Referenced Files
F14041865: D21691.diff
Mon, Nov 11, 10:16 PM
F14035916: D21691.diff
Sun, Nov 10, 8:02 AM
F14028086: D21691.diff
Fri, Nov 8, 11:46 AM
F14026057: D21691.diff
Thu, Nov 7, 10:59 PM
F14014525: D21691.diff
Sun, Nov 3, 5:58 AM
F13993298: D21691.id51653.diff
Tue, Oct 22, 9:56 PM
Unknown Object (File)
Oct 9 2024, 2:16 PM
Unknown Object (File)
Sep 6 2024, 9:02 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. Push nearly all Harbormaster build message logic into the new per-message transaction classes.

Test Plan
  • Issued every message to Buildables.
  • Issued every message to Builds.
  • Looked at a big pile of error messages, couldn't find any typos.
  • Grepped for affected symbols, etc.
  • Ran bin/harbormaster restart ....

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 16 2021, 1:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:18 PM
This revision was automatically updated to reflect the committed changes.