Page MenuHomePhabricator

Modularize individual Harbormaster build messages
ClosedPublic

Authored by epriestley on Jul 15 2021, 10:24 PM.

Details

Summary

Ref T13072. Further modularize build messages by applying each one in a separate transaction type.

This makes it easier to add new types of messages (although I have no particular plans to do this, offhand) and reduces the amount of switch-boilerplate.

This will probably also simplify validating "harbormaster.sendmessage".

Test Plan
  • Applied all commands.
  • Ran migration, saw transactions render properly

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 15 2021, 10:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:17 PM
This revision was automatically updated to reflect the committed changes.