Page MenuHomePhabricator

Modularize individual Harbormaster build messages
ClosedPublic

Authored by epriestley on Jul 15 2021, 10:24 PM.
Tags
None
Referenced Files
F19872177: D21690.diff
Sun, Mar 15, 12:16 PM
F19813854: D21690.id51703.diff
Wed, Mar 4, 11:12 AM
F19813853: D21690.id51652.diff
Wed, Mar 4, 11:12 AM
F19813852: D21690.id.diff
Wed, Mar 4, 11:12 AM
F19812821: D21690.diff
Wed, Mar 4, 6:30 AM
F19805402: D21690.diff
Mon, Mar 2, 10:43 PM
F19569332: D21690.diff
Jan 31 2026, 10:58 PM
F19087121: D21690.id51703.diff
Dec 2 2025, 11:50 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. Further modularize build messages by applying each one in a separate transaction type.

This makes it easier to add new types of messages (although I have no particular plans to do this, offhand) and reduces the amount of switch-boilerplate.

This will probably also simplify validating "harbormaster.sendmessage".

Test Plan
  • Applied all commands.
  • Ran migration, saw transactions render properly

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 15 2021, 10:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:17 PM
This revision was automatically updated to reflect the committed changes.