Page MenuHomePhabricator

Modularize individual Harbormaster build messages
ClosedPublic

Authored by epriestley on Jul 15 2021, 10:24 PM.
Tags
None
Referenced Files
F11519441: D21690.diff
Thu, Feb 2, 9:01 AM
Unknown Object (File)
Sat, Jan 28, 4:40 PM
Unknown Object (File)
Tue, Jan 24, 2:59 PM
Unknown Object (File)
Thu, Jan 19, 12:45 PM
Unknown Object (File)
Wed, Jan 11, 4:40 AM
Unknown Object (File)
Wed, Jan 11, 4:38 AM
Unknown Object (File)
Wed, Jan 11, 4:37 AM
Unknown Object (File)
Sun, Jan 8, 7:05 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. Further modularize build messages by applying each one in a separate transaction type.

This makes it easier to add new types of messages (although I have no particular plans to do this, offhand) and reduces the amount of switch-boilerplate.

This will probably also simplify validating "harbormaster.sendmessage".

Test Plan
  • Applied all commands.
  • Ran migration, saw transactions render properly

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 15 2021, 10:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:17 PM
This revision was automatically updated to reflect the committed changes.