Page MenuHomePhabricator

Modularize individual Harbormaster build messages
ClosedPublic

Authored by epriestley on Jul 15 2021, 10:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 28, 11:48 AM
Unknown Object (File)
Tue, May 27, 4:14 PM
Unknown Object (File)
Mon, May 5, 4:26 PM
Unknown Object (File)
Apr 24 2025, 10:23 AM
Unknown Object (File)
Apr 23 2025, 3:42 PM
Unknown Object (File)
Apr 7 2025, 6:05 AM
Unknown Object (File)
Apr 6 2025, 5:20 AM
Unknown Object (File)
Apr 4 2025, 4:14 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. Further modularize build messages by applying each one in a separate transaction type.

This makes it easier to add new types of messages (although I have no particular plans to do this, offhand) and reduces the amount of switch-boilerplate.

This will probably also simplify validating "harbormaster.sendmessage".

Test Plan
  • Applied all commands.
  • Ran migration, saw transactions render properly

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 15 2021, 10:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:17 PM
This revision was automatically updated to reflect the committed changes.