Page MenuHomePhabricator
Differential D21694

Modularize "HarbormasterBuildableTransaction"
ClosedPublic
Actions

Authored by epriestley on Jul 16 2021, 4:00 PM.
Tags
None
Referenced Files
F18750215: D21694.id.diff
Sat, Oct 4, 6:57 AM
F18746184: D21694.id51707.diff
Fri, Oct 3, 11:44 AM
F18734437: D21694.id.diff
Tue, Sep 30, 10:54 PM
F18653824: D21694.diff
Sun, Sep 21, 8:01 PM
F18647998: D21694.id.diff
Fri, Sep 19, 3:32 PM
F18632349: D21694.id51657.diff
Tue, Sep 16, 5:47 PM
F18594703: D21694.diff
Sep 12 2025, 7:04 PM
F18591971: D21694.diff
Sep 12 2025, 10:56 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13072: Merge Harbormaster BuildCommand into BuildMessage
Commits
rP346ffc51e100: Modularize "HarbormasterBuildableTransaction"
Summary

Ref T13072. Trivially convert this into a modular transaction type.

Test Plan

Issued commands to a buildable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 16 2021, 4:00 PM
Owners added a subscriber: Restricted Owners Package.Jul 16 2021, 4:00 PM
Harbormaster completed remote builds in B25460: Diff 51657.Jul 16 2021, 4:01 PM
epriestley requested review of this revision.Jul 16 2021, 4:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:18 PM
Closed by commit rP346ffc51e100: Modularize "HarbormasterBuildableTransaction" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP346ffc51e100: Modularize "HarbormasterBuildableTransaction".

Revision Contents
Changeset List

Diff 51707

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableActionController.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildableTransactionEditor.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterBuildableTransaction.php

Loading...
View Options

src/applications/harbormaster/xaction/buildable/HarbormasterBuildableMessageTransaction.php

Loading...
View Options

src/applications/harbormaster/xaction/buildable/HarbormasterBuildableTransactionType.php

Loading...
Phabricator · Built by Phacility