Page MenuHomePhabricator
Differential D21694

Modularize "HarbormasterBuildableTransaction"
ClosedPublic
Actions

Authored by epriestley on Jul 16 2021, 4:00 PM.
Tags
None
Referenced Files
F18178984: D21694.id51657.diff
Sat, Aug 16, 2:44 AM
F18178982: D21694.id.diff
Sat, Aug 16, 2:44 AM
F18106568: D21694.diff
Sun, Aug 10, 11:09 PM
F18104508: D21694.diff
Sun, Aug 10, 12:52 PM
F18043755: D21694.id51657.diff
Sun, Aug 3, 6:21 AM
F17899335: D21694.diff
Tue, Jul 29, 8:36 AM
F17885202: D21694.id51657.diff
Jul 29 2025, 12:16 AM
F17848480: D21694.id51707.diff
Jul 27 2025, 7:27 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13072: Merge Harbormaster BuildCommand into BuildMessage
Commits
rP346ffc51e100: Modularize "HarbormasterBuildableTransaction"
Summary

Ref T13072. Trivially convert this into a modular transaction type.

Test Plan

Issued commands to a buildable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 16 2021, 4:00 PM
Owners added a subscriber: Restricted Owners Package.Jul 16 2021, 4:00 PM
Harbormaster completed remote builds in B25460: Diff 51657.Jul 16 2021, 4:01 PM
epriestley requested review of this revision.Jul 16 2021, 4:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:18 PM
Closed by commit rP346ffc51e100: Modularize "HarbormasterBuildableTransaction" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP346ffc51e100: Modularize "HarbormasterBuildableTransaction".

Revision Contents
Changeset List

Diff 51707

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableActionController.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildableTransactionEditor.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterBuildableTransaction.php

Loading...
View Options

src/applications/harbormaster/xaction/buildable/HarbormasterBuildableMessageTransaction.php

Loading...
View Options

src/applications/harbormaster/xaction/buildable/HarbormasterBuildableTransactionType.php

Loading...
Phabricator · Built by Phacility