Page MenuHomePhabricator

MercurialProject
ActivePublic

Recent Activity

Feb 18 2019

vostok4 added a comment to T6118: Support for Mercurial extensions in hosted repositories.

I'd propose for simplicity that the focus switch from largefiles to lfs support for Mercurial repositories. lfs has been added to Phabricator for Git already T7789 and it seems that there'd be less work involved to piggyback on that.

Feb 18 2019, 10:55 PM · Mercurial, Diffusion

Oct 25 2018

epriestley triaged T13214: When there is no remote Mercurial URI, `hg paths default` exits with an error code as Low priority.
Oct 25 2018, 1:54 AM · Mercurial, Arcanist

May 16 2018

cspeckmim added a comment to T9548: Support Mercurial's bundle2 wire protocol.

Mercurial 4.6 has added hg help internals.bundle2 which will render a book to your console with details about the format/protocol. I did a high-speed skim and then tried out hg help internals.changegroup on a whim which produced an even longer book about the stream protocol (SSH only maybe?).

May 16 2018, 1:13 AM · Diffusion, Mercurial

Apr 11 2018

DanielO added a comment to T9450: "abort: not a Mercurial bundle" with Mercurial 3.5>=.

Actually turns out that the work around isn't reliable - I still get that error occasionally (I'm using SSH)

Apr 11 2018, 2:48 AM · Mercurial
DanielO added a comment to T9450: "abort: not a Mercurial bundle" with Mercurial 3.5>=.

The same problem occurred on my site with the latest Phabricator and the latest Mercurial 3.7.2 installed on both sides.

Interestingly, it can be cured setting a special development debug flag for in the Mercurial configuration file:
in /etc/mercurial/hgrc or in vcs-user's ${HOME}/.hgrc adding the following snippet

[devel]
bundle2.debug = true

caused a hg push to a hosted Phabricator repository to work without a problem. But do not ask me, why.

Apr 11 2018, 2:14 AM · Mercurial

Mar 11 2018

kvaster added a comment to T13036: Fix issues with recent Mercurial wire protocol versions.

For recent versions of mercurial to work over http I had to force httpheader=1024 in code which filters bundle2 capabilities.

Mar 11 2018, 8:21 PM · Mercurial

Mar 5 2018

epriestley moved T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export" from Backlog to Diff Parsing on the Arcanist board.
Mar 5 2018, 2:16 PM · Arcanist, Mercurial, Differential, Conduit, Feature Request
epriestley moved T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit from Backlog to arc patch on the Arcanist board.
Mar 5 2018, 2:15 PM · Arcanist, Mercurial, Bug Report

Jan 25 2018

epriestley closed T13036: Fix issues with recent Mercurial wire protocol versions as Resolved.

Presuming this is resolved since we've seen at least some confirmation that it fixed issues and aren't aware of any remaining outstanding problems.

Jan 25 2018, 2:56 AM · Mercurial

Jan 16 2018

epriestley updated the task description for T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .
Jan 16 2018, 10:20 PM · Git, Mercurial, Arcanist
epriestley added a comment to T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .

I'm not totally sure all variants of this are fixed, but I don't know how to reproduce any remaining issues.

Jan 16 2018, 10:15 PM · Git, Mercurial, Arcanist
epriestley closed T8768: Under Mercurial, `arc patch` mishandles files with spaces in them as Resolved by committing rARC2e02332216c6: Add trailing tabs when generating synthetic Git diffs for files with spaces.
Jan 16 2018, 9:57 PM · Git, Mercurial, Arcanist
epriestley added a comment to T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .

I filed a summary of this in the Mercurial upstream to waste someone else's time so I feel better:

Jan 16 2018, 5:21 PM · Git, Mercurial, Arcanist
epriestley added a comment to T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .

This is an explicit behavior in Mercurial and dates from 2007:

Jan 16 2018, 4:49 PM · Git, Mercurial, Arcanist
epriestley added a revision to T8768: Under Mercurial, `arc patch` mishandles files with spaces in them : D18869: Add trailing tabs when generating synthetic Git diffs for files with spaces.
Jan 16 2018, 4:26 PM · Git, Mercurial, Arcanist
epriestley added a comment to T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .

The rule Git uses appears to literally be "does the filename include a space":

Jan 16 2018, 4:01 PM · Git, Mercurial, Arcanist
epriestley renamed T8768: Under Mercurial, `arc patch` mishandles files with spaces in them from `arc patch` fails to add two files starting by the same word, then a space on hg to Under Mercurial, `arc patch` mishandles files with spaces in them .
Jan 16 2018, 3:42 PM · Git, Mercurial, Arcanist

Jan 9 2018

epriestley closed T8303: Mercurial hooks as Invalid.

I'm going to close this since it was mostly answered and the remaining questions (about custom extension development) are outside the scope of modern support. See T13039 for a followup about numeric fields in Herald.

Jan 9 2018, 4:55 PM · Mercurial, Diffusion
epriestley updated the task description for T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.
Jan 9 2018, 4:44 PM · Mercurial, Arcanist
epriestley closed T9555: Exception with 'arc land' after manually rebasing a revision and resolving conflicts, leaves repository in unclean state as Invalid.

Ah, thanks! This is probably effectively covered by T9948 anyway -- one of the major changes for the Git flavor of that (T9657) was "put things back the way they were when anything goes wrong, even if we discard merge/rebase work", and that seems like a better behavior. I'll make a note there just in case.

Jan 9 2018, 4:42 PM · Arcanist, Mercurial

Jan 8 2018

cspeckmim added a comment to T9555: Exception with 'arc land' after manually rebasing a revision and resolving conflicts, leaves repository in unclean state.

I tried a few scenarios for this and wasn't able to reproduce

  1. Single commit in diff that creates conflict
  2. Multiple commits in diff that all create conflicts
  3. Single commit in diff where first commit does not create conflict but second does
Jan 8 2018, 5:58 PM · Arcanist, Mercurial

Jan 5 2018

epriestley moved T8768: Under Mercurial, `arc patch` mishandles files with spaces in them from Backlog to arc patch on the Mercurial board.
Jan 5 2018, 6:56 PM · Git, Mercurial, Arcanist
epriestley moved T12453: Using `arc patch` will leave behind a bookmark when answering 'No' in attempt to apply to current state in Mercurial repository from Backlog to arc patch on the Mercurial board.
Jan 5 2018, 6:56 PM · Arcanist, Mercurial, Bug Report
epriestley moved T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit from Backlog to arc patch on the Mercurial board.
Jan 5 2018, 6:56 PM · Arcanist, Mercurial, Bug Report
epriestley moved T9555: Exception with 'arc land' after manually rebasing a revision and resolving conflicts, leaves repository in unclean state from Backlog to arc land on the Mercurial board.
Jan 5 2018, 6:55 PM · Arcanist, Mercurial
epriestley moved T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads from Backlog to arc land on the Mercurial board.
Jan 5 2018, 6:55 PM · Mercurial, Arcanist

Jan 4 2018

epriestley added a comment to T13036: Fix issues with recent Mercurial wire protocol versions.

After D18857, I'm not aware of any remaining, reproducible issues with Mercurial. If you're still encountering protocol issues after upgrading through D18857, let me know how to reproduce the problem you're seeing.

Jan 4 2018, 10:32 PM · Mercurial
epriestley closed T9548: Support Mercurial's bundle2 wire protocol as Resolved.

T13036 is a more focused rebrand of this issue, since this has a lot of philosophy and not a lot of actionable reproduction steps. The three line fix in D18857 may have resolved these issues.

Jan 4 2018, 10:30 PM · Diffusion, Mercurial
epriestley added a comment to T13036: Fix issues with recent Mercurial wire protocol versions.

Mercurial's protocol negotiation presumably considers the size of the change being transmitted in selecting the protocol format

Jan 4 2018, 10:28 PM · Mercurial
epriestley added a revision to T13036: Fix issues with recent Mercurial wire protocol versions: D18859: Add a couple of clarifying comments to the Mercurial protocol parser.
Jan 4 2018, 10:13 PM · Mercurial
epriestley added a revision to T13036: Fix issues with recent Mercurial wire protocol versions: D18857: Fix a Mercurial wire protocol parser issue when we receive a length frame before any data.
Jan 4 2018, 10:06 PM · Mercurial
epriestley added a comment to T13036: Fix issues with recent Mercurial wire protocol versions.

I think D18857 fixes the pipe issues. Here's the problem:

Jan 4 2018, 10:04 PM · Mercurial
epriestley added a revision to T13036: Fix issues with recent Mercurial wire protocol versions: D18856: Remove an obsolete comment about Mercurial SSH error behavior.
Jan 4 2018, 8:50 PM · Mercurial
epriestley added a revision to T13036: Fix issues with recent Mercurial wire protocol versions: D18855: Remove nonfunctional Mercurial "bundle2" capability filtering from SSH pathway.
Jan 4 2018, 8:27 PM · Mercurial
epriestley added a comment to T13036: Fix issues with recent Mercurial wire protocol versions.

Here's some evidence [that filtering bundle2] doesn't work:
we attempt to filter the protocol and tell the client that we don't support bundle2

Jan 4 2018, 8:20 PM · Mercurial
epriestley triaged T13036: Fix issues with recent Mercurial wire protocol versions as Normal priority.
Jan 4 2018, 7:59 PM · Mercurial
epriestley renamed T10900: Repository content search with `hg grep` returns matches found in old versions of files from Grep file content returns matches found in old versions of files to Repository content search with `hg grep` returns matches found in old versions of files.
Jan 4 2018, 7:40 PM · Mercurial, Diffusion
epriestley moved T10900: Repository content search with `hg grep` returns matches found in old versions of files from Backlog to Far Future on the Mercurial board.
Jan 4 2018, 7:40 PM · Mercurial, Diffusion
epriestley added a comment to T10900: Repository content search with `hg grep` returns matches found in old versions of files.

Actually, this is less crazy than I thought.

Jan 4 2018, 7:39 PM · Mercurial, Diffusion
epriestley added a comment to T10900: Repository content search with `hg grep` returns matches found in old versions of files.

This appears to date back to the introduction of the feature in D5738, where I suggested we use ancestors() without a legitimate reason (or maybe very old Mercurial had weird behavior).

Jan 4 2018, 7:26 PM · Mercurial, Diffusion
epriestley moved T10753: Remove Mercurial daemon working copy operations from Backlog to Clustering on the Mercurial board.
Jan 4 2018, 7:19 PM · Infrastructure, Daemons, Diffusion, Mercurial
epriestley moved T6118: Support for Mercurial extensions in hosted repositories from Backlog to Far Future on the Mercurial board.
Jan 4 2018, 7:14 PM · Mercurial, Diffusion
epriestley merged task T6112: Arcanist can not upload binaries when use Mercurial on Windows into T8298: Fix Windows Escaping.
Jan 4 2018, 7:14 PM · Mercurial, Arcanist
epriestley closed T7407: Problem with Mercurial 3.1.2 as Invalid.

We can't reproduce this, and can't fix issues we can't reproduce.

Jan 4 2018, 7:12 PM · Mercurial

Nov 21 2017

quark.zju added a comment to T13012: Mercurial "--config" and "--debugger" command injection vulnerability.

That's a good point! I wish it was designed like that since the beginning. I guess it won't happen with the current compatibility rules since it is likely to break automation.

Nov 21 2017, 11:03 PM · Mercurial, Security
epriestley added a comment to T13012: Mercurial "--config" and "--debugger" command injection vulnerability.

In theory, you could require --config appear between hg and foo in hg foo .... This is already a valid position for --config (for example, hg --config x=y foo is valid), and already not a valid position for foo flags (for example, hg --branch default log is not valid).

Nov 21 2017, 9:26 PM · Mercurial, Security
quark.zju added a comment to T13012: Mercurial "--config" and "--debugger" command injection vulnerability.

https://phab.mercurial-scm.org/D1483 should make it possible to use -- to defend against non-flag user input. For inputs that are flags, use the form --flag=X and avoid --flag X.

Nov 21 2017, 9:09 PM · Mercurial, Security

Nov 13 2017

epriestley closed T13012: Mercurial "--config" and "--debugger" command injection vulnerability as Resolved.

We'll use the hardened mode once it's available, but I don't think we expect to take any further action here until then.

Nov 13 2017, 9:01 PM · Mercurial, Security

Nov 10 2017

epriestley updated the task description for T13012: Mercurial "--config" and "--debugger" command injection vulnerability.
Nov 10 2017, 5:04 PM · Mercurial, Security
epriestley updated the task description for T13012: Mercurial "--config" and "--debugger" command injection vulnerability.
Nov 10 2017, 5:03 PM · Mercurial, Security