Page MenuHomePhabricator

WikimediaOrganization
ActivePublic

Details

Description

The Wikimedia Foundation adopted Phabricator as our developer collaboration platform. This project organizes our feedback upstream.

https://phabricator.wikimedia.org and https://www.mediawiki.org/wiki/Phabricator

Recent Activity

Thu, May 21

epriestley closed T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does) as Resolved.

I think (?) this was pretty much resolved by the last round of changes. See T13291 for some followups.

Thu, May 21, 4:03 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia

Jul 31 2019

epriestley closed T4900: Workboards updating in real time as Resolved.

See T13357 for followup.

Jul 31 2019, 8:13 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20689: Don't try to emit project board update events if there are no projects to update.
Jul 31 2019, 7:42 PM · Workboards (v3), User Delight, Wikimedia

Jul 24 2019

epriestley added a revision to T4900: Workboards updating in real time: D20681: Fix an issue where editing cards on a workboard with implicit column ordering could reorder cards improperly.
Jul 24 2019, 6:11 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

There's currently a bug (likely related to D20652 or D20654?) where normal edits aren't respecting card order correctly during the redraw. I suspect this is just an order parameter getting lost somewhere.

Jul 24 2019, 5:31 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20680: When a task card is edited, emit update events for old boards and parent boards.
Jul 24 2019, 5:29 PM · Workboards (v3), User Delight, Wikimedia

Jul 17 2019

epriestley added a revision to T4900: Workboards updating in real time: D20656: Make workboard real-time updates mostly work.
Jul 17 2019, 8:09 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

a logical clock to complement the wall-time clocks

Jul 17 2019, 6:25 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

From D20653:

Jul 17 2019, 6:15 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20654: Make reloading workboards with "R" respect workboard ordering.
Jul 17 2019, 6:04 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20653: When updating a workboard with "R", send the client visible set with version numbers.
Jul 17 2019, 5:53 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20652: Move "BoardResponseEngine" toward a more comprehensive update model.
Jul 17 2019, 5:39 PM · Workboards (v3), User Delight, Wikimedia

Jul 3 2019

epriestley added a comment to T4900: Workboards updating in real time.

Just thinking out loud:

Jul 3 2019, 5:54 PM · Workboards (v3), User Delight, Wikimedia

Jul 2 2019

epriestley added a revision to T4900: Workboards updating in real time: D20639: Make pressing "R" on your keyboard reload the card state on workboards.
Jul 2 2019, 8:58 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20638: Remove obsolete "options" from workboard "updateCard()" call.
Jul 2 2019, 5:20 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

Here's roughly where I'm headed next. I'm planning to:

Jul 2 2019, 5:18 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

The "default" controller currently needs to "force" the URI parameters...
The "filter" controller currently needs to "force" the URI parameters...
The "apply" flow, where a new custom filter is applied...

Jul 2 2019, 4:32 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20637: Remove remnants of clumsy old URI state handling from workboards.
Jul 2 2019, 4:30 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20636: Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..." in the workboard UI.
Jul 2 2019, 3:32 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20635: Move workboard "Move Tasks to Column..." workflow to a separate controller.
Jul 2 2019, 2:43 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20634: Move workboard "Bulk Edit Tasks" workflow to a separate controller.
Jul 2 2019, 1:16 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20633: Move workboard "View as Query" workflow to a separate controller.
Jul 2 2019, 12:50 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20632: Move workboard "filter" workflow to a separate controller.
Jul 2 2019, 12:30 PM · Workboards (v3), User Delight, Wikimedia

Jun 29 2019

epriestley added a revision to T4900: Workboards updating in real time: D20629: Give the workboard "default" workflows more modern state handling.
Jun 29 2019, 10:35 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

A couple of weird cases on state management:

Jun 29 2019, 10:14 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Jun 29 2019, 10:12 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20627: Remove property "id" from Workboard View controller.
Jun 29 2019, 9:20 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: D20626: Remove unused property "slug" from Workboard View controller.
Jun 29 2019, 8:07 PM · Workboards (v3), User Delight, Wikimedia

Jun 19 2019

epriestley added a comment to T4411: Adding a CC to a Maniphest Task should give View rights for that user.

See also T13317.

Jun 19 2019, 6:20 PM · Wikimedia, Policy
epriestley closed T9720: Provide a way to link to Diffusion files, a subtask of T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does), as Resolved.
Jun 19 2019, 5:32 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia

May 10 2019

epriestley added a parent task for T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): T13285: Service failures in JIRA can cascade into service failures in Phabricator.
May 10 2019, 2:15 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia

May 9 2019

epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): D20512: Specialize rendering of self-URIs in the form "/X123".
May 9 2019, 8:34 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): D20511: Provide an extension point for handling hyperlinks in remarkup in a special way.
May 9 2019, 7:59 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a subtask for T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): T9720: Provide a way to link to Diffusion files.
May 9 2019, 6:31 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a comment to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).

PHI1224 describes a somewhat-adjacent situation: an install would like a way for external automated tooling to reference source files and generate editor links for them.

May 9 2019, 6:31 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley claimed T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 9 2019, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley removed a parent task for T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): T7443: Include full link to Maniphest tasks in commit messages.
May 9 2019, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): D20510: When a user pastes a Phabricator URI into the search box, redirect to the URI.
May 9 2019, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): D20509: Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class.
May 9 2019, 6:21 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia

May 3 2019

epriestley closed T7703: Policy checks may execute incompletely for non-viewers, a subtask of T6183: Allow any user to watch projects, as Resolved.
May 3 2019, 4:53 AM · Wikimedia, Projects
epriestley closed T7703: Policy checks may execute incompletely for non-viewers, a subtask of T8377: Build the core "Spaces" Application, as Resolved.
May 3 2019, 4:53 AM · Spaces, Wikimedia, Policy

Apr 30 2019

epriestley removed a parent task for T4171: Building reporting and data systems: T6821: Allow querying for open Maniphest tasks with an assignee set for ages ("cookie licking").
Apr 30 2019, 8:57 PM · Restricted Project, FreeBSD, Wikimedia, Facts
epriestley closed T4171: Building reporting and data systems as Resolved.

This is approximately coming into existence and this task no longer serves much of a purpose. See T13083 / T13279 for followups.

Apr 30 2019, 8:57 PM · Restricted Project, FreeBSD, Wikimedia, Facts
epriestley closed T1562: Build "Facts", an ETL pipeline and charting application as Resolved.

This now approximately exists and is no longer of much use as a standalone task. See T13279 and elsewhere for followups.

Apr 30 2019, 8:52 PM · Restricted Project, Wikimedia, Facts
epriestley closed T1562: Build "Facts", an ETL pipeline and charting application, a subtask of T4171: Building reporting and data systems, as Resolved.
Apr 30 2019, 8:52 PM · Restricted Project, FreeBSD, Wikimedia, Facts
epriestley closed T1562: Build "Facts", an ETL pipeline and charting application, a subtask of T6041: Metrics for Maniphest, as Resolved.
Apr 30 2019, 8:52 PM · Wikimedia, Facts, Maniphest

Apr 27 2019

epriestley moved T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does) from Backlog to Next on the Remarkup board.
Apr 27 2019, 5:12 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley closed T10571: Default quote action breaks text between lists as Resolved.

I believe this was resolved by D20327 / D20393.

Apr 27 2019, 5:11 PM · Remarkup, Wikimedia

Mar 11 2019

epriestley closed T6502: Policy to define who can move cards in a workboard as Wontfix.

To summarize the state of the world here:

Mar 11 2019, 2:18 PM · Projects, Wikimedia, Policy, Workboards
epriestley closed T6502: Policy to define who can move cards in a workboard, a subtask of T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)", as Wontfix.
Mar 11 2019, 2:18 PM · Projects, Wikimedia, Workboards