Page MenuHomePhabricator

ConduitProject
ActivePublic

Members (2)

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

API access to Phabricator goodness.

Recent Activity

Jun 1 2021

epriestley added a comment to T13650: Unhandled Exception accessing Conduit's dashboard.panel.edit: "Attempting to use a panel in a way that requires an implementation, but the panel implementation ("") is unknown to Phabricator.".

D21668 should improve this behavior, although it's not an ideal or complete fix.

Jun 1 2021, 6:49 AM · Conduit
epriestley added a revision to T13650: Unhandled Exception accessing Conduit's dashboard.panel.edit: "Attempting to use a panel in a way that requires an implementation, but the panel implementation ("") is unknown to Phabricator.": D21668: Correct an issue where "dashboard.panel.edit" fatals in the API console.
Jun 1 2021, 6:40 AM · Conduit
epriestley claimed T13650: Unhandled Exception accessing Conduit's dashboard.panel.edit: "Attempting to use a panel in a way that requires an implementation, but the panel implementation ("") is unknown to Phabricator.".
Jun 1 2021, 6:35 AM · Conduit

Apr 9 2021

aklapper created T13650: Unhandled Exception accessing Conduit's dashboard.panel.edit: "Attempting to use a panel in a way that requires an implementation, but the panel implementation ("") is unknown to Phabricator.".
Apr 9 2021, 2:05 PM · Conduit

Mar 26 2021

epriestley closed T13639: Allow revisions to be queried by affected path via the API as Resolved.

This is now in stable; presuming it works until evidence to the contrary emerges.

Mar 26 2021, 6:08 PM · Conduit, Differential

Mar 17 2021

epriestley closed T9499: Revision repository is not updated when it is changed in the UI as Resolved.

The modern differential.revision.search API returns the repository for the revision.

Mar 17 2021, 7:23 PM · Differential, Conduit
epriestley added a revision to T9499: Revision repository is not updated when it is changed in the UI: D21638: When using "Update Diff" from the web UI, prefill "Repository" properly.
Mar 17 2021, 7:19 PM · Differential, Conduit
epriestley moved T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export" from Backlog to Diff Parsing on the Differential board.
Mar 17 2021, 7:07 PM · Arcanist, Mercurial, Differential, Conduit, Feature Request
epriestley moved T9499: Revision repository is not updated when it is changed in the UI from Backlog to Next on the Differential board.
Mar 17 2021, 7:03 PM · Differential, Conduit

Mar 15 2021

epriestley updated the task description for T13639: Allow revisions to be queried by affected path via the API.
Mar 15 2021, 11:13 PM · Conduit, Differential
epriestley updated the task description for T13639: Allow revisions to be queried by affected path via the API.
Mar 15 2021, 11:12 PM · Conduit, Differential
epriestley updated the task description for T13639: Allow revisions to be queried by affected path via the API.
Mar 15 2021, 11:12 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21621: Expose "affectedPaths" to "differential.revision.search" Conduit API method.
Mar 15 2021, 11:02 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21620: Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove "withPath()" from DifferentialRevisionQuery.
Mar 15 2021, 10:57 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21619: Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the revision view.
Mar 15 2021, 10:52 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21618: Update "AffectedPath" table when a revision's repository changes.
Mar 15 2021, 10:47 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21617: Update table schema for "AffectedPath" table.
Mar 15 2021, 10:37 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21616: Move "Affected Path" index updates to a separate class.
Mar 15 2021, 8:59 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21615: Add a debug view of the "Affected Path" index to Differential.
Mar 15 2021, 8:44 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21614: Lift peculiar side effect of path indexing out of indexer.
Mar 15 2021, 5:50 PM · Conduit, Differential
epriestley moved T13639: Allow revisions to be queried by affected path via the API from Backlog to Next on the Differential board.
Mar 15 2021, 5:07 PM · Conduit, Differential

Mar 14 2021

epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21612: Retitle "Recently Open Revisions" panel to "Recent Open Revisions".
Mar 14 2021, 8:02 PM · Conduit, Differential
epriestley added a comment to T13639: Allow revisions to be queried by affected path via the API.

I'm likely to break the paths constraint for frozen API method differential.query. This was added by D2788 as a Facebook-specific patch with no rationale that I can dig up, and the author didn't have any related changes from around that time.

Mar 14 2021, 7:54 PM · Conduit, Differential
epriestley triaged T13639: Allow revisions to be queried by affected path via the API as Wishlist priority.
Mar 14 2021, 7:50 PM · Conduit, Differential

Feb 16 2021

epriestley closed T13607: Provide additional query constraints in "harbormaster.target.search" as Resolved.

Yep, that's more constraints.

Feb 16 2021, 8:34 PM · Harbormaster, Conduit
epriestley added a revision to T13607: Provide additional query constraints in "harbormaster.target.search": D21559: Add more constraints to "harbormaster.target.search".
Feb 16 2021, 8:06 PM · Harbormaster, Conduit
epriestley triaged T13607: Provide additional query constraints in "harbormaster.target.search" as Normal priority.
Feb 16 2021, 7:47 PM · Harbormaster, Conduit

Nov 3 2020

epriestley added a revision to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit: D21488: Add a basic "harbormaster.step.search" API method.
Nov 3 2020, 8:50 PM · Conduit, Harbormaster
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
  • There is no way to pull custom field values with *.search. See above.
    • There is no way to edit non-custom field values with *.edit. The underlying transactions haven't been modularized yet; they should be, then EditEngine should get appropriate EditField definitions.
    • There's no way to identify which custom fields can be edited. This overlaps with T13248, but is also a Conduit API Console UI problem. The web UI should have some way to inspect parameter variations per object subtype for available subtypes.
      • As a workaround, you can try to edit an invalid field. The error message will identify valid fields.
    • There's no way to create steps with *.edit because you can't specify a step type. See T13449 for a general variation of the "type is required to initialize objects" problem.
Nov 3 2020, 8:49 PM · Conduit, Harbormaster
epriestley added a revision to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit: D21489: Add a basic "harbormaster.step.edit" API method.
Nov 3 2020, 8:46 PM · Conduit, Harbormaster
epriestley renamed T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit from Expose "harbormaster.buildstep.edit" and "harbormaster.buildstep.search" over Conduit to Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.
Nov 3 2020, 8:45 PM · Conduit, Harbormaster
epriestley added a comment to T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit.

HarbormasterBuildStepCoreCustomField emits no fields if a BuildStep has no attached Implementation object. This dates from D15352 and is conceptually reasonable ("don't crash if a build step exists but the implementation no longer does") but should probably be represented differently (e.g., an explicit "InvalidImplementation").

Nov 3 2020, 8:18 PM · Conduit, Harbormaster
epriestley triaged T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit as Normal priority.
Nov 3 2020, 8:17 PM · Conduit, Harbormaster

Sep 17 2020

epriestley added a revision to T13582: Exception handling in ConduitFuture for raw HTTP exceptions lacks tailoring: D21467: In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions.
Sep 17 2020, 8:19 PM · Arcanist, Conduit
epriestley triaged T13582: Exception handling in ConduitFuture for raw HTTP exceptions lacks tailoring as Low priority.
Sep 17 2020, 8:17 PM · Arcanist, Conduit

Apr 15 2020

epriestley closed T13507: Compress Conduit client requests as Resolved.

One possible improvement remains here: in streaming mode, HTTPSFuture will not "Accept-Encoding: gzip" and can not inflate responses. Today, this only applies to arc download.

Apr 15 2020, 6:58 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: D21125: Compress file downloads if the client sends "Accept-Encoding: gzip" and we guess the file might compress alright.
Apr 15 2020, 6:35 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: D21122: Disable automatic decoding of "Content-Encoding" responses during "Accept-Encoding" setup test.
Apr 15 2020, 12:28 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: D21121: Allow HTTPFuture callers to disable processing of "Content-Encoding" response headers.
Apr 15 2020, 12:16 PM · Performance, Conduit

Apr 14 2020

epriestley added a comment to T13507: Compress Conduit client requests.

There's also one minor related concern in PHI1638 that I want to take care of here, since it's adjacent.

Apr 14 2020, 11:52 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: D21120: In Conduit responses, assert that Phabricator supports a "gzip" capability.
Apr 14 2020, 11:47 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: D21119: If the Conduit server asserts it has the "gzip" capability, compress requests.
Apr 14 2020, 11:45 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: D21118: If the Conduit client supports gzip, make calls with "Accept-Encoding: gzip".
Apr 14 2020, 11:21 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: D21117: In "phutil_loggable_string()", encode every byte above 0x7F.
Apr 14 2020, 9:52 PM · Performance, Conduit
epriestley added a comment to T13507: Compress Conduit client requests.

In fairness, "SetInputFilter DEFLATE" is documented as uniquely opinionated, if you catch this box and read between the lines a little bit:

Apr 14 2020, 9:45 PM · Performance, Conduit
epriestley added a comment to T13507: Compress Conduit client requests.

A grand aventure in PHI1679 led to identifying the Apache "SetInputFilter DEFLATE" directive as a problem with implementing compression.

Apr 14 2020, 9:40 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: D21116: Add a setup warning to detect "SetInputFilter DEFLATE" and other "Content-Encoding" request mangling.
Apr 14 2020, 9:25 PM · Performance, Conduit

Apr 11 2020

epriestley closed T11968: Decide the fate of FutureGraph as Resolved.

"FutureGraph" is dead. Long live "HardpointEngine".

Apr 11 2020, 2:41 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley closed T11968: Decide the fate of FutureGraph, a subtask of T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching, as Resolved.
Apr 11 2020, 2:41 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11968: Decide the fate of FutureGraph: D21083: Remove "RefQuery" and all "HardpointLoader" code.
Apr 11 2020, 1:44 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist