Page MenuHomePhabricator

In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
ClosedPublic

Authored by epriestley on Sep 17 2020, 8:19 PM.
Tags
None
Referenced Files
F15555772: D21467.id51096.diff
Mon, Apr 28, 1:00 PM
F15549045: D21467.id.diff
Sun, Apr 27, 3:33 AM
F15544612: D21467.diff
Sat, Apr 26, 6:18 AM
F15512082: D21467.id51097.diff
Thu, Apr 17, 7:58 AM
F15453443: D21467.id51097.diff
Mar 29 2025, 11:49 AM
F15450285: D21467.id51096.diff
Mar 28 2025, 2:52 PM
F15443481: D21467.id.diff
Mar 27 2025, 4:38 AM
F15439255: D21467.diff
Mar 26 2025, 6:35 AM
Subscribers
None

Details

Summary

Ref T13582. When this code is reached with a raw HTTP exception, it currently fatals.

Test Plan
  • Ran arc branches --conduit-uri=http://example.org (a bad Conduit URI).
  • Before: hard fatal with a bad method call.
  • After: non-Conduit exception raised to user. Not ideal, but a step forward.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable