Page MenuHomePhabricator

In ConduitCallFuture, only call Conduit exception messages on Conduit exceptions
ClosedPublic

Authored by epriestley on Sep 17 2020, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 10:59 PM
Unknown Object (File)
Sun, Dec 8, 1:48 PM
Unknown Object (File)
Mon, Dec 2, 4:09 PM
Unknown Object (File)
Mon, Nov 25, 1:03 AM
Unknown Object (File)
Sat, Nov 23, 2:11 PM
Unknown Object (File)
Nov 22 2024, 7:17 AM
Unknown Object (File)
Nov 21 2024, 1:45 PM
Unknown Object (File)
Nov 20 2024, 7:05 AM
Subscribers
None

Details

Summary

Ref T13582. When this code is reached with a raw HTTP exception, it currently fatals.

Test Plan
  • Ran arc branches --conduit-uri=http://example.org (a bad Conduit URI).
  • Before: hard fatal with a bad method call.
  • After: non-Conduit exception raised to user. Not ideal, but a step forward.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable