Page MenuHomePhabricator

Correct an issue where "dashboard.panel.edit" fatals in the API console
ClosedPublic

Authored by epriestley on Jun 1 2021, 6:40 AM.
Tags
None
Referenced Files
F15457038: D21668.diff
Sun, Mar 30, 1:55 PM
F15452333: D21668.id51567.diff
Sat, Mar 29, 3:53 AM
F15446321: D21668.id.diff
Thu, Mar 27, 6:22 PM
F15443045: D21668.diff
Thu, Mar 27, 1:53 AM
F15426334: D21668.diff
Sun, Mar 23, 8:02 AM
F15424267: D21668.id51566.diff
Sat, Mar 22, 9:13 PM
F15421712: D21668.id51566.diff
Sat, Mar 22, 1:47 AM
F15410099: D21668.diff
Wed, Mar 19, 6:46 AM
Subscribers
None

Details

Summary

Ref T13650. Currently, viewing the API console help page for this method fatals because it constructs a generic, untyped panel.

As a step toward improving this, generate a concrete panel type instead. This isn't the best possible fix, see T13650 for discussion.

Test Plan

Viewed "dashboard.panel.edit" API page, now saw a usable page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable