If the Conduit server asserts it has the "gzip" capability, compress requests
ClosedPublic
Actions

Authored by epriestley on Apr 14 2020, 11:45 PM.

Details

Reviewers: None
Maniphest Tasks: T13507: Compress Conduit client requests
Commits: rARC377ed2ed8db7: If the Conduit server asserts it has the "gzip" capability, compress requests

Summary

Ref T13507. For various messy reasons we can't blindly assume the server supports "gzip" -- but if the server tells us it does, we're on firmer ground.

If the server returns an "X-Conduit-Capabilities: gzip" header and we have compression support locally, compress subsequent requests.

This restores D21073, which was reverted by D21076.

Test Plan

With a gzip-asserting server, added debugging code and ran various "arc" commands. Saw the 2nd..Nth calls hit compression code.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 14 2020, 11:45 PM

Harbormaster completed remote builds in B24114: Diff 50296.Apr 14 2020, 11:45 PM

epriestley requested review of this revision.Apr 14 2020, 11:45 PM

epriestley mentioned this in D21120: In Conduit responses, assert that Phabricator supports a "gzip" capability.Apr 14 2020, 11:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2020, 11:50 PM

Closed by commit rARC377ed2ed8db7: If the Conduit server asserts it has the "gzip" capability, compress requests (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC377ed2ed8db7: If the Conduit server asserts it has the "gzip" capability, compress requests.

epriestley mentioned this in rP0ea6d131e072: In Conduit responses, assert that Phabricator supports a "gzip" capability.

Revision Contents
Changeset List

Path

Size

src/

conduit/

ConduitClient.php

24 lines

ConduitFuture.php

14 lines

Diff 50298

View Options

src/conduit/ConduitClient.php