Page MenuHomePhabricator

If the Conduit server asserts it has the "gzip" capability, compress requests
ClosedPublic

Authored by epriestley on Apr 14 2020, 11:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 8:58 AM
Unknown Object (File)
Sun, Feb 9, 8:58 AM
Unknown Object (File)
Sun, Feb 9, 8:58 AM
Unknown Object (File)
Fri, Jan 31, 5:34 PM
Unknown Object (File)
Mon, Jan 27, 7:31 PM
Unknown Object (File)
Sun, Jan 26, 5:03 AM
Unknown Object (File)
Sat, Jan 25, 7:06 AM
Unknown Object (File)
Sat, Jan 25, 7:06 AM
Subscribers
None

Details

Summary

Ref T13507. For various messy reasons we can't blindly assume the server supports "gzip" -- but if the server tells us it does, we're on firmer ground.

If the server returns an "X-Conduit-Capabilities: gzip" header and we have compression support locally, compress subsequent requests.

This restores D21073, which was reverted by D21076.

Test Plan

With a gzip-asserting server, added debugging code and ran various "arc" commands. Saw the 2nd..Nth calls hit compression code.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable