Page MenuHomePhabricator

Profile Menu ItemProject
ArchivedPublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Configurable set of navigation elements re-used throughout Phabricator on Home, Profile, Projects, and the Quick Create menu.

Recent Activity

Mar 29 2019

epriestley archived Profile Menu Item.
Mar 29 2019, 4:34 PM

Mar 27 2019

epriestley closed T12167: Unable to edit menu items on mobile as Resolved by committing rP6bb9d3ac67a1: Allow users to add "ProfileMenu" items on mobile.
Mar 27 2019, 11:06 PM · Profile Menu Item, Bug Report
epriestley closed T12745: Conpherence menu item is available for creation even if Conpherence is not installed as Resolved by committing rP6648942bc885: Don't allow "Conpherence" menu items to be added to editable menus if….
Mar 27 2019, 11:01 PM · Profile Menu Item, Customer Impact
epriestley added a revision to T12167: Unable to edit menu items on mobile: D20338: Allow users to add "ProfileMenu" items on mobile.
Mar 27 2019, 9:12 PM · Profile Menu Item, Bug Report
epriestley claimed T12167: Unable to edit menu items on mobile.
Mar 27 2019, 9:09 PM · Profile Menu Item, Bug Report
epriestley added a comment to T12745: Conpherence menu item is available for creation even if Conpherence is not installed.

(Sorry, typo'd my own name into another @ep....)

Mar 27 2019, 6:29 PM · Profile Menu Item, Customer Impact
epriestley claimed T12745: Conpherence menu item is available for creation even if Conpherence is not installed.
Mar 27 2019, 6:28 PM · Profile Menu Item, Customer Impact
epriestley reassigned T12745: Conpherence menu item is available for creation even if Conpherence is not installed from chad to epramono.
Mar 27 2019, 6:28 PM · Profile Menu Item, Customer Impact
epriestley added a revision to T12745: Conpherence menu item is available for creation even if Conpherence is not installed: D20337: Don't allow "Conpherence" menu items to be added to editable menus if Conpherence is not installed.
Mar 27 2019, 6:27 PM · Profile Menu Item, Customer Impact

Feb 16 2019

epriestley closed T12165: Maybe add a (fullscreen workboard) menu item or URL for link as Wontfix.

It sounds like real-time updates will more-or-less moot this.

Feb 16 2019, 1:39 PM · Workboards, Profile Menu Item

Dec 23 2017

epriestley closed T13033: Disabling both "Workboard" and "Project Details" causes project's /tag/ProjectName url to fatal as Resolved by committing rP84cf49387984: Allow "Manage" to be the default menu item for projects.
Dec 23 2017, 7:37 PM · Profile Menu Item, Projects
epriestley added a revision to T13033: Disabling both "Workboard" and "Project Details" causes project's /tag/ProjectName url to fatal: D18843: Allow "Manage" to be the default menu item for projects.
Dec 23 2017, 4:44 PM · Profile Menu Item, Projects

Dec 22 2017

20after4 added a comment to T13033: Disabling both "Workboard" and "Project Details" causes project's /tag/ProjectName url to fatal.

D18836 probably isn't the right solution, however, it's the only straightforward fix I could come up with. I didn't dig into the details of why it 404s when I fix the code in PhabricatorProjectViewController to avoid the fatal. The patch is probably good enough for Wikimedia, however, I'm not sure if it's good enough for upstream.

Dec 22 2017, 3:26 PM · Profile Menu Item, Projects
20after4 added projects to T13033: Disabling both "Workboard" and "Project Details" causes project's /tag/ProjectName url to fatal: Projects, Profile Menu Item.
Dec 22 2017, 3:10 PM · Profile Menu Item, Projects

Dec 7 2017

lpriestley added a revision to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one: D18821: WIP Menu item that is a link to a state of a builtin menu item should display consistent selection behavior.
Dec 7 2017, 10:18 PM · Dashboards

Nov 23 2017

aik099 added a comment to T12098: Create Revision from FavoritesMenuItem doesn't work.

Obviously not a particularly important issue, but this now will populate a link in the favorites menu which leads to an exception:

Nov 23 2017, 7:28 AM · Dashboards, Differential
sshannin added a comment to T12098: Create Revision from FavoritesMenuItem doesn't work.

Obviously not a particularly important issue, but this now will populate a link in the favorites menu which leads to an exception:

Nov 23 2017, 3:33 AM · Dashboards, Differential

Aug 22 2017

chad added a comment to T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.

Somewhat related, if you have a disabled "Home" as your top item, we still show that regardless of the active dashboard below it.

Aug 22 2017, 10:23 PM · Policy, Dashboards, Bug Report

Aug 10 2017

epriestley added a comment to T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.

T12956 has another situation where letting MenuItem generate 2+ items may be bad: we want to let a menu item steal the selection, but it's muddy to implement if each MenuItem can return several actual views.

Aug 10 2017, 1:38 PM · Policy, Dashboards, Bug Report

Aug 5 2017

rfreebern added a revision to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one: D18346: Override project nav menu filter if link item matching URI exists.
Aug 5 2017, 2:15 PM · Dashboards
chad added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

remind me to add some more icons for Link.

Aug 5 2017, 12:51 AM · Dashboards
chad added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

That looks pretty hawt.

Aug 5 2017, 12:50 AM · Dashboards

Aug 4 2017

epriestley added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

Happy to take a look if you found a reasonable way to get access to $request. If you're reading $_REQUEST['__path__'] directly or something though the eventual upstream version probably won't look too similar.

Aug 4 2017, 7:51 PM · Dashboards
rfreebern added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

I've written a patch to make this work for the project sidebar nav for my organization's install. I don't want to take up your time with it if it's not helpful, but let me know if you'd like me to push a diff.

Aug 4 2017, 7:36 PM · Dashboards

Aug 2 2017

chad edited projects for T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one, added: Profile Menu Item; removed Workboards.
Aug 2 2017, 5:19 PM · Dashboards

Jul 27 2017

epriestley closed T12136: What to do with "Application Counts" with MenuItem, a subtask of T11957: Add MenuEngine to Home, as Wontfix.
Jul 27 2017, 4:42 PM · Profile Menu Item, Dashboards
epriestley closed T12136: What to do with "Application Counts" with MenuItem as Wontfix.

Dropping these doesn't seem to have caused any major pushback.

Jul 27 2017, 4:42 PM · Profile Menu Item
epriestley closed T12208: Collapsable Menu Item as Resolved.

This presumably counts as "not much interest" or should move to Discourse now or something, maybe.

Jul 27 2017, 4:32 PM · Profile Menu Item
epriestley merged T12308: Access forbidden on homepage if the first dashboard in menu is not visible to user into T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.
Jul 27 2017, 4:25 PM · Policy, Dashboards, Bug Report
epriestley merged task T12308: Access forbidden on homepage if the first dashboard in menu is not visible to user into T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.
Jul 27 2017, 4:25 PM · Dashboards, Profile Menu Item, Bug Report

Jul 9 2017

chad removed the image for Profile Menu Item.
Jul 9 2017, 7:41 PM

Jun 26 2017

epriestley lowered the priority of T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out from Normal to Low.

For private reasons affecting the reporting install, this no longer has customer impact.

Jun 26 2017, 2:02 PM · Policy, Dashboards, Bug Report

Jun 23 2017

epriestley triaged T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out as Normal priority.
Jun 23 2017, 7:16 PM · Policy, Dashboards, Bug Report

May 30 2017

neilfitz added a comment to T12423: Bring MenuItem customization options to User Profiles.

Thanks! That should be perfect.

May 30 2017, 9:17 PM · Dashboards, Restricted Project, Profile
chad added a revision to T12423: Bring MenuItem customization options to User Profiles: D18046: Group Maniphest Tasks by Priority on Profiles.
May 30 2017, 9:13 PM · Dashboards, Restricted Project, Profile
chad added a comment to T12423: Bring MenuItem customization options to User Profiles.

Possibly also, add a "See All" link to ApplicationSearch

May 30 2017, 8:53 PM · Dashboards, Restricted Project, Profile
chad added a comment to T12423: Bring MenuItem customization options to User Profiles.

Sounds reasonable to just improve that.

May 30 2017, 8:52 PM · Dashboards, Restricted Project, Profile
neilfitz added a project to T12423: Bring MenuItem customization options to User Profiles: Restricted Project.

Hey, we're also interested in this by way of T12545 (which was merged in above). A couple of our teams have historically assigned their oncall/tech-debt tasks to a mailing list user, and used the priority-sorted view of those tasks to run their oncall shifts. That workflow no longer works with the reverse-chronological sort.

May 30 2017, 8:44 PM · Dashboards, Restricted Project, Profile

May 23 2017

chad moved T12745: Conpherence menu item is available for creation even if Conpherence is not installed from Backlog to Nits on the Customer Impact board.
May 23 2017, 9:17 PM · Profile Menu Item, Customer Impact
epriestley added a comment to T12745: Conpherence menu item is available for creation even if Conpherence is not installed.

I've been busy with important emoji research.

May 23 2017, 6:11 PM · Profile Menu Item, Customer Impact
chad added a comment to T12745: Conpherence menu item is available for creation even if Conpherence is not installed.

Hows Nuance coming?

May 23 2017, 6:10 PM · Profile Menu Item, Customer Impact
epriestley added a comment to T12745: Conpherence menu item is available for creation even if Conpherence is not installed.

sorry maybe I am supposed to use these now 😱 😱 😱 😱

May 23 2017, 6:05 PM · Profile Menu Item, Customer Impact
epriestley added a comment to T12745: Conpherence menu item is available for creation even if Conpherence is not installed.

We un-install it on admin.phacility.com. :) :) :) :)

May 23 2017, 6:03 PM · Profile Menu Item, Customer Impact
chad added a comment to T12745: Conpherence menu item is available for creation even if Conpherence is not installed.

Hmm, we shouldn't allow Dashboards to be un-installed.

May 23 2017, 5:52 PM · Profile Menu Item, Customer Impact
epriestley added a comment to T12745: Conpherence menu item is available for creation even if Conpherence is not installed.

(The "Dashboard" item may also be affected.)

May 23 2017, 5:50 PM · Profile Menu Item, Customer Impact
chad claimed T12745: Conpherence menu item is available for creation even if Conpherence is not installed.
May 23 2017, 5:13 PM · Profile Menu Item, Customer Impact
epriestley created T12745: Conpherence menu item is available for creation even if Conpherence is not installed.
May 23 2017, 5:01 PM · Profile Menu Item, Customer Impact

May 21 2017

chad added a revision to T12423: Bring MenuItem customization options to User Profiles: D17987: Add Revisions to User Profiles.
May 21 2017, 12:07 AM · Dashboards, Restricted Project, Profile

May 10 2017

chad merged T12700: Bring back diff results from the user page into T12423: Bring MenuItem customization options to User Profiles.
May 10 2017, 2:34 AM · Dashboards, Restricted Project, Profile

Apr 12 2017

epriestley merged T12545: People > Assigned Tasks are not ordered by priority into T12423: Bring MenuItem customization options to User Profiles.
Apr 12 2017, 5:28 PM · Dashboards, Restricted Project, Profile