Really awesome.

This one is totally my bad.
My intention was to make it less spooky to migrate individual pieces to the section construct (since the API remained largely the same), but the API weirdness was not worth it, and didn't even achieve that goal

Badly designed workaround for an issue we had

The use case for it was related to CI, but it's not relevant anymore

My favorite commit of 2015.

It was a screenshot taken on a retina Mac. It had some mapping image on it. The whole thing was around 5mb.

It would be nice (and maybe pretty complex) for (3) to work if you happen to use S3 (which would work if you instance is behind VPN), although right now the Phabricator guide does not recommend using it.

What about inlining the images with data:base64 ?
Sure it will make emails with images bigger, but it will always work and most emails don't have macros.

project.query does not emits the auxiliary dictionary, so there's no way of getting custom field value with the api :(

Looks good, although it won't fix inline links (in comments and such)

ping

This causes Phabricator to blow up on our install
Call to undefined method JsonLintLexer::len()
callstack:

...
phutil_json_decode() /Users/tal/dev/phabricator/phabricator/src/applications/differential/customfield/DifferentialAuditorsField.php:24
PhutilJSONParser->parse() /Users/tal/dev/phabricator/libphutil/src/utils/utils.php:1053
JsonLintJsonParser->parse() /Users/tal/dev/phabricator/libphutil/src/parser/PhutilJSONParser.php:27
JsonLintJsonParser->lex() /Users/tal/dev/phabricator/libphutil/externals/jsonlint/src/Seld/JsonLint/JsonParser.php:178

• removed server config option for html email

• cleaned out escaping and removed colorful headers

my arcanist seems to be messed up?

• cosmetics

really fix it

wops

• added per-user config and removed diff colorization (will come back again in a separate patch)

Actually I think I can test the rendering with something like litmus, so it should be pretty easy to verify this one.

Awesome! Can you arc patch D9375 locally and see if:

Cool. I'll chop em up and send patches.

I mean, make v1 also do diffs (because they are so easy compared to remarkup), which is pretty much D9375 plus minor fixes plus per-user config. I can also rip that part out if you'd prefer, although we found it to be useful.

Yeah, this needs some poking around, although I'm leaning towards teaching PhutilRemarkupBlockRule how to render things for email.
There's just one render target right now I think. The text rendering just dumps the remarkup as is.

• Cool, I'll add the formatting option.
• Correctly rendering remarkup blocks might be a little hairy, as it requires inlining CSS. Maybe we need to teach PhutilRemarkupBlockRule how to render tags for email, or figure out some post-processing css inline pass?

resend

rebased

rebase

One click instead of two (it works as advertised)

can we get a way to do a one-click "add task to column"?

few fixes + rebase

oops! I did search for it, but my feng shui was misaligned.

Awesome! I've really wanted this :)

FWIW, we've been running this since I've submitted the diff, and it abolished Mail.app threading issues, and we haven't seen any issues elsewhere.

I see. Is there a ticket for the filter-by-project reworking? I couldn't find one

added support for colorized diffs for inline comments
added PhabricatorMetaMTAMailSection helper for building email sections

We have the exact same issue. it makes Phabricator "feel" spammy.

One clarification: the only requirement for this to work is knowing what the Message-ID of the message is.

ping? There's totally tests for it :D

@chad: yeah, that's fair. It also needs testing across more email clients to verify that it doesn't break replies and threading.

D9375 works reasonably well, but need to verify that it doesn't break reply-by-email in popular email client (see differential review for details)

I personally dislike it the addition to the body, as it adds more metadata to scroll through before I can get into the comments.

What about something like T5244?
We use [REPO/BRANCH] [Differential] <...> for our email subjects, and it's super convenient.

REALLY TOTALLY REBASE

rebased

Looks kinda like this

Is there any interest in this patch?
We've been dogfooding it for a while now, and it works pretty well (we also reply from emails a lot).

• show up in help --full

• moved config parsing to pre-workflow phase
• clean up patch a bit

rebased

missed some commits

--set-config -> --config

Not that useful :D

Oh damn!

fixed sloppy newline

send all commits

• getFullGitDiff() now explicitly gets base and head revisions. This provides a slightly cleaner API, and allows fetching a diff against the working copy.