Page MenuHomePhabricator

made email commands extraction a bit more lax
Needs RevisionPublic

Authored by talshiri on Jun 6 2014, 2:04 AM.

Details

Summary

allows !command to also appear at the end, and be less sensitive about whitespaces

Test Plan

wrote unit tests.

Diff Detail

Repository
rP Phabricator
Branch
friendlier_reply_commands
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 1188
Build 1188: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

talshiri retitled this revision from to made email commands extraction a bit more lax.
talshiri updated this object.
talshiri edited the test plan for this revision. (Show Details)
talshiri added a reviewer: epriestley.

ping? There's totally tests for it :D

I wanted to go in a slightly different direction with this, here's the half-a-diff I have locally that I haven't had a chance to finish/test yet:

https://secure.phabricator.com/differential/diff/23440/

In particular, the rules are:

  • !command is parsed on any line, but must appear at the beginning of the line.
  • Multiple !commands are allowed to appear in a message (e.g., !assign + !close).
  • Words after !command are interpreted as arguments.

In particular, I don't think "just chatting about !reject" should trigger a reject. The other stuff makes this more flexible in the future.

epriestley edited edge metadata.

This is obsoleted by changes connected to T7199.

This revision now requires changes to proceed.May 17 2015, 1:32 PM