allows !command to also appear at the end, and be less sensitive about whitespaces
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4699: Improve email interaction with Maniphest
wrote unit tests.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- friendlier_reply_commands
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1188 Build 1188: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I wanted to go in a slightly different direction with this, here's the half-a-diff I have locally that I haven't had a chance to finish/test yet:
https://secure.phabricator.com/differential/diff/23440/
In particular, the rules are:
- !command is parsed on any line, but must appear at the beginning of the line.
- Multiple !commands are allowed to appear in a message (e.g., !assign + !close).
- Words after !command are interpreted as arguments.
In particular, I don't think "just chatting about !reject" should trigger a reject. The other stuff makes this more flexible in the future.